Commit graph

925 commits

Author SHA1 Message Date
Jeff Mitchell 18c96d66f9 changelog++ 2018-05-16 13:31:56 -04:00
Jeff Mitchell a0c5ac1211 changelog++ 2018-05-16 12:14:22 -04:00
Jeff Mitchell f7e37de648 Re-add capability to unwrap pre-0.6.2 wrapping tokens 2018-05-15 20:01:58 -04:00
Jeff Mitchell 6b2593ff54 changelog++ 2018-05-11 11:58:52 -04:00
Tyler Marshall 407550bd89 Fix minor spelling mistake (#4548) 2018-05-10 13:42:01 -07:00
Jeff Mitchell ae3fed38fe changelog++ 2018-05-10 15:40:45 -04:00
Jeff Mitchell af802275bd
Fix response wrapping from K/V version 2 (#4511)
This takes place in two parts, since working on this exposed an issue
with response wrapping when there is a raw body set. The changes are (in
diff order):

* A CurrentWrappingLookupFunc has been added to return the current
value. This is necessary for the lookahead call since we don't want the
lookahead call to be wrapped.

* Support for unwrapping < 0.6.2 tokens via the API/CLI has been
removed, because we now have backends returning 404s with data and can't
rely on the 404 trick. These can still be read manually via
cubbyhole/response.

* KV preflight version request now ensures that its calls is not
wrapped, and restores any given function after.

* When responding with a raw body, instead of always base64-decoding a
string value and erroring on failure, on failure we assume that it
simply wasn't a base64-encoded value and use it as is.

* A test that fails on master and works now that ensures that raw body
responses that are wrapped and then unwrapped return the expected
values.

* A flag for response data that indicates to the wrapping handling that
the data contained therein is already JSON decoded (more later).

* RespondWithStatusCode now defaults to a string so that the value is
HMAC'd during audit. The function always JSON encodes the body, so
before now it was always returning []byte which would skip HMACing. We
don't know what's in the data, so this is a "better safe than sorry"
issue. If different behavior is needed, backends can always manually
populate the data instead of relying on the helper function.

* We now check unwrapped data after unwrapping to see if there were raw
flags. If so, we try to detect whether the value can be unbase64'd. The
reason is that if it can it was probably originally a []byte and
shouldn't be audit HMAC'd; if not, it was probably originally a string
and should be. In either case, we then set the value as the raw body and
hit the flag indicating that it's already been JSON decoded so not to
try again before auditing. Doing it this way ensures the right typing.

* There is now a check to see if the data coming from unwrapping is
already JSON decoded and if so the decoding is skipped before setting
the audit response.
2018-05-10 15:40:03 -04:00
Jeff Mitchell eecdbb0ee8 changelog++ 2018-05-09 10:55:44 -04:00
Jeff Mitchell 2cc4f20f18 Revert "changelog++"
This reverts commit cd603e299cbe7377ed27cf702ba23dc8cdcc4a33.
2018-05-07 16:11:18 -04:00
Jeff Mitchell 767d241fda changelog++ 2018-05-07 14:02:47 -04:00
Chris Hoffman d4265b59ab
changelog++ 2018-05-07 13:54:29 -04:00
Chris Hoffman caa48d3e60
changelog++ 2018-05-07 13:27:54 -04:00
Jeff Mitchell b894050c21 changelog++ 2018-05-04 13:26:39 -04:00
vishalnayak 9fcda0c1f0 changelog++ 2018-05-04 10:17:18 -04:00
Jeff Mitchell ef8f23a0b2 changelog++ 2018-05-04 10:09:43 -04:00
Jeff Mitchell 3d56e0eb5f changelog++ 2018-05-01 11:24:02 -04:00
Jeff Mitchell cdece25b98 changelog++ 2018-04-26 16:26:44 -04:00
Jeff Mitchell b20a5d05bd changelog++ 2018-04-25 15:49:02 -04:00
Jeff Mitchell 8d90f441ba changelog++ 2018-04-25 12:09:49 -04:00
Jeff Mitchell 21357cba1b changelog++ 2018-04-25 03:14:20 -04:00
Jeff Mitchell c8b7594811 Fix date in CL 2018-04-25 02:45:11 -04:00
Jeff Mitchell edf531f552 changelog++ 2018-04-25 00:43:13 -04:00
Matthew Irish f2bc5d9b25
Update CHANGELOG.md 2018-04-24 22:24:07 -05:00
Jeff Mitchell e29bf3df61 changelog++ 2018-04-24 22:42:26 -04:00
vishalnayak 34a26c64a8 changelog++ 2018-04-24 19:17:27 -04:00
Matthew Irish f61ea271d7
changelog++ 2018-04-24 16:35:03 -05:00
Matthew Irish 6c83f3b7e7
changelog++ 2018-04-24 10:04:05 -05:00
Jeff Mitchell fbb5e201f5 changelog++ 2018-04-23 18:05:08 -04:00
Jeff Mitchell 89816ca76c changelog++ 2018-04-23 18:02:26 -04:00
Jeff Mitchell 182d960ecc changelog++ 2018-04-23 18:01:08 -04:00
Jeff Mitchell 3e6a9d5e09 changelog++ 2018-04-23 15:05:50 -04:00
vishalnayak 5cc02fd64b changelog++ 2018-04-23 13:52:11 -04:00
Calvin Leung Huang 72e70afe21 changelog++ 2018-04-23 10:31:08 -04:00
Jeff Mitchell bb8fa74a53 changelog++ 2018-04-23 10:11:45 -04:00
Jeff Mitchell 1cacd517f8 changelog++ 2018-04-21 10:51:47 -04:00
Matthew Irish 5fd178b423
changelog++ 2018-04-19 20:55:31 -05:00
Jeff Mitchell 6eb2f2f8a3 changelog++ 2018-04-18 16:35:36 -04:00
Matthew Irish 4c9e6c52ab
changelog++ 2018-04-18 14:31:35 -05:00
vishalnayak e1d857fed9 changelog++ 2018-04-18 13:11:40 -04:00
Jeff Mitchell cfd8021a6b changelog++ 2018-04-17 18:53:50 -04:00
vishalnayak 90d50b8eed changelog++ 2018-04-17 12:04:01 -04:00
Jeff Mitchell 8e1aea5eb3 changelog++ 2018-04-17 11:58:37 -04:00
vishalnayak 2ffc74c887 changelog++ 2018-04-17 11:19:54 -04:00
Jeff Mitchell 56addaf97c changelog++ 2018-04-13 21:51:08 -04:00
Benjamin Lupton 5f1be19fbf changelog: fixed some spelling mistakes (#4331) 2018-04-10 16:09:44 -04:00
Chris Hoffman 556c035cb5
changelog++ 2018-04-10 14:11:53 -04:00
Jeff Mitchell c56abb0dd8 Add more info to upgrade guide and changelog 2018-04-10 12:09:54 -04:00
Brian Kassouf d441d2784c
changelog++ 2018-04-10 08:22:38 -07:00
Brian Kassouf 940fca5884
changelog++ 2018-04-10 08:09:50 -07:00
Brian Kassouf 79a78ee23f
changelog++ 2018-04-10 08:03:51 -07:00