luxolus
/
open-vault
2
0
Fork 0
Code Issues 1 Pull Requests Releases Activity

VAULT-12542 Add info encouraging users to upgrade if agent version is different to server (#18684) 

* VAULT-12542 Add info encouraging users to upgrade if agent version is different to server

* VAULT-12542 Changelog

* VAULT-12542 Language update
This commit is contained in:
Violet Hynes 2023-01-13 09:49:36 -05:00 committed by GitHub
parent cd30860cb6
commit e8aa9c6429
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/18684.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:improvement
agent: Add note in logs when starting Vault Agent indicating if the version differs to the Vault Server.
```

13
command/agent.go
View File

@ -250,7 +250,7 @@ func (c *AgentCommand) Run(args []string) int {
return 0
}
// Ignore any setting of agent's address. This client is used by the agent
// Ignore any setting of Agent's address. This client is used by the Agent
// to reach out to Vault. This should never loop back to agent.
c.flagAgentAddress = ""
client, err := c.Client()
@ -261,6 +261,17 @@ func (c *AgentCommand) Run(args []string) int {
return 1
}
serverHealth, err := client.Sys().Health()
if err == nil {
// We don't exit on error here, as this is not worth stopping Agent over
serverVersion := serverHealth.Version
agentVersion := version.GetVersion().VersionNumber()
if serverVersion != agentVersion {
c.UI.Info("==> Note: Vault Agent version does not match Vault server version. " +
fmt.Sprintf("Vault Agent version: %s, Vault server version: %s", agentVersion, serverVersion))
}
}
// ctx and cancelFunc are passed to the AuthHandler, SinkServer, and
// TemplateServer that periodically listen for ctx.Done() to fire and shut
// down accordingly.