fix TypeCommaIntSlice panic caused by json.Number input (#15072)

* fix TypeCommaIntSlice panic caused by json.Number input

* add changelog entry
This commit is contained in:
Chris Capurso 2022-04-18 16:43:16 -04:00 committed by GitHub
parent 46591ec54d
commit d9280b0fb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 0 deletions

3
changelog/15072.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
core: Fix panic caused by parsing JSON integers for fields defined as comma-delimited integers
```

View File

@ -243,6 +243,12 @@ func (d *FieldData) getPrimitive(k string, schema *FieldSchema) (interface{}, bo
case TypeCommaIntSlice:
var result []int
jsonIn, ok := raw.(json.Number)
if ok {
raw = jsonIn.String()
}
config := &mapstructure.DecoderConfig{
Result: &result,
WeaklyTypedInput: true,

View File

@ -593,6 +593,19 @@ func TestFieldDataGet(t *testing.T) {
[]int{},
false,
},
"comma int slice type, json number": {
map[string]*FieldSchema{
"foo": {Type: TypeCommaIntSlice},
},
map[string]interface{}{
"foo": json.Number("1"),
},
"foo",
[]int{1},
false,
},
"name string type, valid string": {
map[string]*FieldSchema{
"foo": {Type: TypeNameString},