luxolus
/
open-vault
2
0
Fork 0
Code Issues 1 Pull Requests Releases Activity

UI: update host to new doc link location (developer.hashicorp.com/) (#18374) 

* change host for doc link

* add todo to LearnLink

* add changelog
This commit is contained in:
claire bontempo 2022-12-14 15:25:16 -08:00 committed by GitHub
parent 5715cc9e54
commit d91e69d183
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/18374.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:improvement
ui: update DocLink component to use new host url: developer.hashicorp.com
```

2
ui/lib/core/addon/components/doc-link.js
View File

@ -13,7 +13,7 @@ import ExternalLink from './external-link';
* *
*/ */
export default class DocLinkComponent extends ExternalLink { export default class DocLinkComponent extends ExternalLink {
host = 'https://www.vaultproject.io'; host = 'https://developer.hashicorp.com';
get href() { get href() {
return `${this.host}${this.args.path}`; return `${this.host}${this.args.path}`;

1
ui/lib/core/addon/components/learn-link.js
View File

@ -13,6 +13,7 @@ import ExternalLink from './external-link';
* *
*/ */
// TODO update host to 'https://developer.hashicorp.com' once updated paths are established
export default class LearnLinkComponent extends ExternalLink { export default class LearnLinkComponent extends ExternalLink {
host = 'https://learn.hashicorp.com'; host = 'https://learn.hashicorp.com';

4
ui/tests/integration/components/form-field-label-test.js
View File

@ -39,6 +39,8 @@ module('Integration | Component | form-field-label', function (hooks) {
assert.dom('a').doesNotExist('docLink hidden when not provided'); assert.dom('a').doesNotExist('docLink hidden when not provided');
this.set('docLink', '/doc/path'); this.set('docLink', '/doc/path');
assert.dom('.sub-text').includesText('See our documentation for help', 'Doc link text renders'); assert.dom('.sub-text').includesText('See our documentation for help', 'Doc link text renders');
assert.dom('a').hasAttribute('href', 'https://www.vaultproject.io' + this.docLink, 'Doc link renders'); assert
.dom('a')
.hasAttribute('href', 'https://developer.hashicorp.com' + this.docLink, 'Doc link renders');
}); });
}); });