luxolus
/
open-vault
2
0
Fork 0
Code Issues 1 Pull Requests Releases Activity

Info table row typography (#12908) 

* updates info table row value font

* adds changelog

* updates tests

* attempts to fix flaky mount-secret-backend acceptance test
This commit is contained in:
Jordan Reimer 2021-10-22 15:16:02 -06:00 committed by GitHub
parent bfde3eddbc
commit d098bb19f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/12908.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:improvement
ui: Updates font for table row value fields
```

4
ui/lib/core/addon/templates/components/info-table-row.hbs
View File

@ -55,7 +55,7 @@
@horizontalPosition="left" @horizontalPosition="left"
as |T|> as |T|>
<T.trigger @tabindex=false> <T.trigger @tabindex=false>
<code class="is-word-break has-text-black" data-test-row-value="{{label}}">{{value}}</code> <span class="is-word-break has-text-black" data-test-row-value="{{label}}">{{value}}</span>
</T.trigger> </T.trigger>
<T.content @class="tool-tip"> <T.content @class="tool-tip">
<CopyButton <CopyButton
@ -73,7 +73,7 @@
</T.content> </T.content>
</ToolTip> </ToolTip>
{{else}} {{else}}
<code class="is-word-break has-text-black" data-test-row-value="{{label}}">{{value}}</code> <span class="is-word-break has-text-black" data-test-row-value="{{label}}">{{value}}</span>
{{/if}} {{/if}}
{{/if}} {{/if}}
{{/if}} {{/if}}

2
ui/tests/acceptance/settings/mount-secret-backend-test.js
View File

@ -128,7 +128,7 @@ module('Acceptance | settings/mount-secret-backend', function(hooks) {
`write sys/policies/acl/kv-v2-degrade policy=${btoa(V2_POLICY)}`, `write sys/policies/acl/kv-v2-degrade policy=${btoa(V2_POLICY)}`,
'write -field=client_token auth/token/create policies=kv-v2-degrade', 'write -field=client_token auth/token/create policies=kv-v2-degrade',
]); ]);
await settled();
let userToken = consoleComponent.lastLogOutput; let userToken = consoleComponent.lastLogOutput;
await logout.visit(); await logout.visit();
await authPage.login(userToken); await authPage.login(userToken);

6
ui/tests/integration/components/info-table-row-test.js
View File

@ -47,8 +47,7 @@ module('Integration | Component | InfoTableRow', function(hooks) {
/>`); />`);
assert.dom('[data-test-component="info-table-row"]').exists(); assert.dom('[data-test-component="info-table-row"]').exists();
let string = document.querySelector('code').textContent; assert.dom('[data-test-row-value]').hasText(VALUE, 'renders value as passed through');
assert.equal(string, VALUE, 'renders value as passed through');
this.set('value', ''); this.set('value', '');
assert assert
@ -101,8 +100,7 @@ module('Integration | Component | InfoTableRow', function(hooks) {
@label={{label}} @label={{label}}
@isLink={{true}} @isLink={{true}}
/>`); />`);
let string = document.querySelector('code').textContent; assert.dom('[data-test-row-value]').hasText(VALUE, 'renders value in code element and not in a tag');
assert.equal(string, VALUE, 'renders value in code element and not in a tag');
}); });
test('it renders links if isLink is true and type is array', async function(assert) { test('it renders links if isLink is true and type is array', async function(assert) {