CLI to take days as a unit of time (#20477)

* CLI to take days as a unit of time

* CL
This commit is contained in:
Hamid Ghaf 2023-05-04 08:03:37 -07:00 committed by GitHub
parent 544ae3461f
commit bf96f63649
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 2 deletions

3
changelog/20477.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
cli: CLI should take days as a unit of time for ttl like flags
```

View File

@ -594,7 +594,7 @@ type DurationVar struct {
func (f *FlagSet) DurationVar(i *DurationVar) {
initial := i.Default
if v, exist := os.LookupEnv(i.EnvVar); exist {
if d, err := time.ParseDuration(appendDurationSuffix(v)); err == nil {
if d, err := parseutil.ParseDurationSecond(v); err == nil {
initial = d
}
}
@ -634,7 +634,7 @@ func (d *durationValue) Set(s string) error {
s = "-1"
}
v, err := time.ParseDuration(appendDurationSuffix(s))
v, err := parseutil.ParseDurationSecond(s)
if err != nil {
return err
}

View File

@ -71,6 +71,12 @@ func TestTokenCreateCommand_Run(t *testing.T) {
"not present in secret",
1,
},
{
"ttl",
[]string{"-ttl", "1d", "-explicit-max-ttl", "2d"},
"token",
0,
},
}
t.Run("validations", func(t *testing.T) {