luxolus/open-vault
2
0
Fork 0
Code Issues 1 Pull requests Releases Activity

On change of configuration rotate the database type

Browse source
This commit is contained in:
Brian Kassouf 2017-04-03 18:30:38 -07:00
parent d7dd0ab35c
commit b506bd7790
1 changed files with 7 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
builtin/logical/database/path_config_connection.go
View file

@ -243,29 +243,23 @@ func (b *databaseBackend) connectionWriteHandler(factory dbs.Factory) framework.
}
if verifyConnection {
return logical.ErrorResponse(err.Error()), nil
return logical.ErrorResponse("Could not verify connection"), nil
}
}
if _, ok := b.connections[name]; ok {
newType := db.Type()
// Don't update connection until the reset api is hit, close for
// now.
err = db.Close()
// Close and remove the old connection
err := b.connections[name].Close()
if err != nil {
return nil, err
}
// Don't allow the connection type to change
if b.connections[name].Type() != newType {
return logical.ErrorResponse("Can not change type of existing connection."), nil
}
} else {
// Save the new connection
b.connections[name] = db
delete(b.connections, name)
}
// Save the new connection
b.connections[name] = db
// Store it
entry, err := logical.StorageEntryJSON(fmt.Sprintf("dbs/%s", name), config)
if err != nil {