From 9bc24be343d802c3d83bcdc8bd6544d971b1b872 Mon Sep 17 00:00:00 2001
From: Jeff Mitchell <jeffrey.mitchell@gmail.com>
Date: Fri, 15 Apr 2016 17:04:29 +0000
Subject: [PATCH] Move recovery info behind the barrier

---
 vault/init.go | 51 ++++++++++++++++++++++++++-------------------------
 1 file changed, 26 insertions(+), 25 deletions(-)

diff --git a/vault/init.go b/vault/init.go
index 370b63f64..a943a0422 100644
--- a/vault/init.go
+++ b/vault/init.go
@@ -171,31 +171,6 @@ func (c *Core) Initialize(barrierConfig, recoveryConfig *SealConfig) (*InitResul
 		SecretShares: barrierUnsealKeys,
 	}
 
-	// Save the configuration regardless, but only generate a key if it's not
-	// disabled
-	if c.seal.RecoveryKeySupported() {
-		err = c.seal.SetRecoveryConfig(recoveryConfig)
-		if err != nil {
-			c.logger.Printf("[ERR] core: failed to save recovery configuration: %v", err)
-			return nil, fmt.Errorf("recovery configuration saving failed: %v", err)
-		}
-
-		if recoveryConfig.SecretShares > 0 {
-			recoveryKey, recoveryUnsealKeys, err := c.generateShares(recoveryConfig)
-			if err != nil {
-				c.logger.Printf("[ERR] core: %v", err)
-				return nil, err
-			}
-
-			err = c.seal.SetRecoveryKey(recoveryKey)
-			if err != nil {
-				return nil, err
-			}
-
-			results.RecoveryShares = recoveryUnsealKeys
-		}
-	}
-
 	// Initialize the barrier
 	if err := c.barrier.Initialize(barrierKey); err != nil {
 		c.logger.Printf("[ERR] core: failed to initialize barrier: %v", err)
@@ -223,6 +198,32 @@ func (c *Core) Initialize(barrierConfig, recoveryConfig *SealConfig) (*InitResul
 		return nil, err
 	}
 
+	// Save the configuration regardless, but only generate a key if it's not
+	// disabled. When using recovery keys they are stored in the barrier, so
+	// this must happen post-unseal.
+	if c.seal.RecoveryKeySupported() {
+		err = c.seal.SetRecoveryConfig(recoveryConfig)
+		if err != nil {
+			c.logger.Printf("[ERR] core: failed to save recovery configuration: %v", err)
+			return nil, fmt.Errorf("recovery configuration saving failed: %v", err)
+		}
+
+		if recoveryConfig.SecretShares > 0 {
+			recoveryKey, recoveryUnsealKeys, err := c.generateShares(recoveryConfig)
+			if err != nil {
+				c.logger.Printf("[ERR] core: %v", err)
+				return nil, err
+			}
+
+			err = c.seal.SetRecoveryKey(recoveryKey)
+			if err != nil {
+				return nil, err
+			}
+
+			results.RecoveryShares = recoveryUnsealKeys
+		}
+	}
+
 	// Generate a new root token
 	rootToken, err := c.tokenStore.rootToken()
 	if err != nil {