From 96dfbfbd0280c4b89e5d82f82a229de268ad6b61 Mon Sep 17 00:00:00 2001 From: davidadeleon <56207066+davidadeleon@users.noreply.github.com> Date: Mon, 24 Jan 2022 10:51:35 -0500 Subject: [PATCH] Raft/fix raft telemetry metric unit (#13749) Converting raft time metrics to Milliseconds over Default Nanoseconds to maintain consistency --- changelog/13749.txt | 3 +++ physical/raft/raft.go | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 changelog/13749.txt diff --git a/changelog/13749.txt b/changelog/13749.txt new file mode 100644 index 000000000..f76079925 --- /dev/null +++ b/changelog/13749.txt @@ -0,0 +1,3 @@ +```release-note:bug +storage/raft: Units for bolt metrics now given in milliseconds instead of nanoseconds +``` diff --git a/physical/raft/raft.go b/physical/raft/raft.go index 2b2de78ac..41138dd80 100644 --- a/physical/raft/raft.go +++ b/physical/raft/raft.go @@ -509,12 +509,12 @@ func (b *RaftBackend) collectMetricsWithStats(stats bolt.Stats, sink *metricsuti sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "node", "count"}, float32(txstats.NodeCount), labels) sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "node", "dereferences"}, float32(txstats.NodeDeref), labels) sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "rebalance", "count"}, float32(txstats.Rebalance), labels) - sink.AddSampleWithLabels([]string{"raft_storage", "bolt", "rebalance", "time"}, float32(txstats.RebalanceTime), labels) + sink.AddSampleWithLabels([]string{"raft_storage", "bolt", "rebalance", "time"}, float32(txstats.RebalanceTime.Milliseconds()), labels) sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "split", "count"}, float32(txstats.Split), labels) sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "spill", "count"}, float32(txstats.Spill), labels) - sink.AddSampleWithLabels([]string{"raft_storage", "bolt", "spill", "time"}, float32(txstats.SpillTime), labels) + sink.AddSampleWithLabels([]string{"raft_storage", "bolt", "spill", "time"}, float32(txstats.SpillTime.Milliseconds()), labels) sink.SetGaugeWithLabels([]string{"raft_storage", "bolt", "write", "count"}, float32(txstats.Write), labels) - sink.AddSampleWithLabels([]string{"raft_storage", "bolt", "write", "time"}, float32(txstats.WriteTime), labels) + sink.AddSampleWithLabels([]string{"raft_storage", "bolt", "write", "time"}, float32(txstats.WriteTime.Milliseconds()), labels) } // RaftServer has information about a server in the Raft configuration