Don't serialize the full connection state, instead just the peer certificates, and parse them on the other side
This commit is contained in:
parent
e7261bc31f
commit
8d6244f8e7
|
@ -3,6 +3,7 @@ package requestutil
|
|||
import (
|
||||
"bytes"
|
||||
"crypto/tls"
|
||||
"crypto/x509"
|
||||
"net/http"
|
||||
"net/url"
|
||||
|
||||
|
@ -38,8 +39,8 @@ type ForwardedRequest struct {
|
|||
// The remote address
|
||||
RemoteAddr string `json:"remote_addr"`
|
||||
|
||||
// The client's TLS connection state
|
||||
ConnectionState *tls.ConnectionState `json:"connection_state"`
|
||||
// The client's TLS peer certificates
|
||||
PeerCertificates [][]byte `json:"peer_certificates"`
|
||||
}
|
||||
|
||||
// GenerateForwardedRequest generates a new http.Request that contains the
|
||||
|
@ -51,7 +52,13 @@ func GenerateForwardedRequest(req *http.Request, addr string) (*http.Request, er
|
|||
Header: req.Header,
|
||||
Host: req.Host,
|
||||
RemoteAddr: req.RemoteAddr,
|
||||
ConnectionState: req.TLS,
|
||||
}
|
||||
|
||||
if req.TLS.PeerCertificates != nil && len(req.TLS.PeerCertificates) > 0 {
|
||||
fq.PeerCertificates = make([][]byte, len(req.TLS.PeerCertificates))
|
||||
for i, cert := range req.TLS.PeerCertificates {
|
||||
fq.PeerCertificates[i] = cert.Raw
|
||||
}
|
||||
}
|
||||
|
||||
buf := bytes.NewBuffer(nil)
|
||||
|
@ -107,7 +114,19 @@ func ParseForwardedRequest(req *http.Request) (*http.Request, error) {
|
|||
Body: buf,
|
||||
Host: fq.Host,
|
||||
RemoteAddr: fq.RemoteAddr,
|
||||
TLS: fq.ConnectionState,
|
||||
}
|
||||
|
||||
if fq.PeerCertificates != nil && len(fq.PeerCertificates) > 0 {
|
||||
ret.TLS = &tls.ConnectionState{
|
||||
PeerCertificates: make([]*x509.Certificate, len(fq.PeerCertificates)),
|
||||
}
|
||||
for i, certBytes := range fq.PeerCertificates {
|
||||
cert, err := x509.ParseCertificate(certBytes)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
req.TLS.PeerCertificates[i] = cert
|
||||
}
|
||||
}
|
||||
|
||||
return ret, nil
|
||||
|
|
Loading…
Reference in a new issue