luxolus
/
open-vault
2
0
Fork 0
Code Issues 1 Pull Requests Releases Activity

Allow AWS secret engine to send empty policy document (#23470) (#23509) 

* fix

* changelog

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
This commit is contained in:
Angel Garbarino 2023-10-08 13:10:35 -06:00 committed by GitHub
parent f4453384cb
commit 89de6267c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changelog/23470.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
ui: Fix AWS secret engine to allow empty policy_document field.
```

2
ui/app/helpers/jsonify.js
View File

@ -6,6 +6,8 @@
import { helper as buildHelper } from '@ember/component/helper'; import { helper as buildHelper } from '@ember/component/helper';
export function jsonify([target]) { export function jsonify([target]) {
// aws secret engine needs to be able to send an empty json value on the field policy_document
if (!target) return;
return JSON.parse(target); return JSON.parse(target);
} }

2
ui/app/models/role-aws.js
View File

@ -54,7 +54,7 @@ export default Model.extend({
editType: 'json', editType: 'json',
helpText: helpText:
'A policy is an object in AWS that, when associated with an identity or resource, defines their permissions.', 'A policy is an object in AWS that, when associated with an identity or resource, defines their permissions.',
defaultValue: '{\n}', // Cannot have a default_value on policy_document because in some cases AWS expects this value to be empty.
}), }),
fields: computed('credentialType', function () { fields: computed('credentialType', function () {
const credentialType = this.credentialType; const credentialType = this.credentialType;