From 87c96495157827b8403a494b8454defe2cd347a0 Mon Sep 17 00:00:00 2001 From: Jordan Reimer Date: Thu, 2 Mar 2023 13:59:35 -0700 Subject: [PATCH] Configure Ember Data ID Generation (#19428) * adds initializer to configure ember data id generation * updates comments * adds changelog entry * adds check for id to ember data identifier config --- changelog/19428.txt | 3 +++ ui/app/initializers/ember-data-identifiers.js | 26 +++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 changelog/19428.txt create mode 100644 ui/app/initializers/ember-data-identifiers.js diff --git a/changelog/19428.txt b/changelog/19428.txt new file mode 100644 index 000000000..c1ae6d54b --- /dev/null +++ b/changelog/19428.txt @@ -0,0 +1,3 @@ +```release-note:bug +ui: Fixes crypto.randomUUID error in unsecure contexts from third party ember-data library +``` \ No newline at end of file diff --git a/ui/app/initializers/ember-data-identifiers.js b/ui/app/initializers/ember-data-identifiers.js new file mode 100644 index 000000000..c22c2af7f --- /dev/null +++ b/ui/app/initializers/ember-data-identifiers.js @@ -0,0 +1,26 @@ +import { setIdentifierGenerationMethod } from '@ember-data/store'; +import { dasherize } from '@ember/string'; +import { v4 as uuidv4 } from 'uuid'; + +export function initialize() { + // see this GH issue for more information https://github.com/emberjs/data/issues/8106 + // Ember Data uses uuidv4 library to generate ids which relies on the crypto API which is no available in unsecure contexts + // the suggested polyfill was added in 4.6.2 so until we upgrade we need to define our own id generation method + // https://api.emberjs.com/ember-data/4.5/classes/IdentifierCache/methods/getOrCreateRecordIdentifier?anchor=getOrCreateRecordIdentifier + // the uuid library was brought in to replace other usages of crypto in the app so it is safe to use in unsecure contexts + // adapted from defaultGenerationMethod -- https://github.com/emberjs/data/blob/v4.5.0/packages/store/addon/-private/identifier-cache.ts#LL82-L94C2 + setIdentifierGenerationMethod((data) => { + if (data.lid) { + return data.lid; + } + if (data.id) { + return `@lid:${dasherize(data.type)}-${data.id}`; + } + return uuidv4(); + }); +} + +export default { + name: 'ember-data-identifiers', + initialize, +};