luxolus/open-vault
2
0
Fork 0
Code Issues 1 Pull requests Releases Activity

fixing the test for the wrong IAM Role ARN

Browse source
This commit is contained in:
Ivan Fuyivara 2016-06-14 18:17:41 +00:00
parent 0ffbef0ccd
commit 74e84113db
1 changed files with 21 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
builtin/credential/aws-ec2/backend_test.go
View file

@ -1131,7 +1131,7 @@ func TestBackendAcc_LoginAndWhitelistIdentity(t *testing.T) {
"policies": "root", "policies": "root",
"max_ttl": "120s", "max_ttl": "120s",
"bound_ami_id": "wrong_ami_id", "bound_ami_id": "wrong_ami_id",
"bound_iam_role_arn" : "wront_iam_role_arn", "bound_iam_role_arn" : iamARN,
} }
roleReq := &logical.Request{ roleReq := &logical.Request{
@ -1169,8 +1169,6 @@ func TestBackendAcc_LoginAndWhitelistIdentity(t *testing.T) {
// Place the correct AMI ID on the role // Place the correct AMI ID on the role
data["bound_ami_id"] = amiID data["bound_ami_id"] = amiID
// Place the correct IAM Role ARN on the role
data["bound_iam_role_arn"] = iamARN
resp, err = b.HandleRequest(roleReq) resp, err = b.HandleRequest(roleReq)
if err != nil || (resp != nil && resp.IsError()) { if err != nil || (resp != nil && resp.IsError()) {
t.Fatalf("bad: failed to create role: resp:%#v\nerr:%v", resp, err) t.Fatalf("bad: failed to create role: resp:%#v\nerr:%v", resp, err)
@ -1185,6 +1183,26 @@ func TestBackendAcc_LoginAndWhitelistIdentity(t *testing.T) {
t.Fatalf("first login attempt failed") t.Fatalf("first login attempt failed")
} }
// Place the wrong IAM Role ARN on the role
data["bound_iam_role_arn"] = "wrong_iam_role_arn"
resp, err = b.HandleRequest(roleReq)
if err != nil || (resp != nil && resp.IsError()) {
t.Fatalf("bad: failed to create role: resp:%#v\nerr:%v", resp, err)
}
// Attempt to login and expect a fail because IAM Role ARN is wrong
resp, err = b.HandleRequest(loginRequest)
if err != nil || resp == nil || (resp != nil && !resp.IsError()) {
t.Fatalf("bad: expected error response: resp:%#v\nerr:%v", resp, err)
}
// Place the correct IAM Role ARN
data["bound_iam_role_arn"] = iamARN
resp, err = b.HandleRequest(roleReq)
if err != nil || (resp != nil && resp.IsError()) {
t.Fatalf("bad: failed to create role: resp:%#v\nerr:%v", resp, err)
}
// Attempt to login again and see if it succeeds // Attempt to login again and see if it succeeds
resp, err = b.HandleRequest(loginRequest) resp, err = b.HandleRequest(loginRequest)
if err != nil { if err != nil {