fix race condition in string generator helper (#19875)

* fix race condition in string generator helper

* add changelog

changelog/19875.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+helper/random: Fix race condition in string generator helper
+```

helper/random/string_generator.go

@@ -10,6 +10,7 @@ import (
 	"io"
 	"math"
 	"sort"
+	"sync"
 	"time"
 	"unicode"
 
@@ -80,6 +81,7 @@ type StringGenerator struct {
 
 	// CharsetRule to choose runes from. This is computed from the rules, not directly configurable
 	charset     runes
+	charsetLock sync.RWMutex
 }
 
 // Generate a random string from the charset and adhering to the provided rules.
@@ -119,7 +121,10 @@ func (g *StringGenerator) generate(rng io.Reader) (str string, err error) {
 	// If performance improvements need to be made, this can be changed to read a batch of
 	// potential strings at once rather than one at a time. This will significantly
 	// improve performance, but at the cost of added complexity.
-	candidate, err := randomRunes(rng, g.charset, g.Length)
+	g.charsetLock.RLock()
+	charset := g.charset
+	g.charsetLock.RUnlock()
+	candidate, err := randomRunes(rng, charset, g.Length)
 	if err != nil {
 		return "", fmt.Errorf("unable to generate random characters: %w", err)
 	}
@@ -232,6 +237,8 @@ func (g *StringGenerator) validateConfig() (err error) {
 		merr = multierror.Append(merr, fmt.Errorf("specified rules require at least %d characters but %d is specified", minLen, g.Length))
 	}
 
+	g.charsetLock.Lock()
+	defer g.charsetLock.Unlock()
 	// Ensure we have a charset & all characters are printable
 	if len(g.charset) == 0 {
 		// Yes this is mutating the generator but this is done so we don't have to compute this on every generation