luxolus
/
open-vault
2
0
Fork 0
Code Issues 1 Pull Requests Releases Activity

recognize ed25519 key type and return PKCS8 format (#13257) 

* return pkcs8 format for ed25519 curve

convertRespToPKCS8 does not recognize the ed25519 key. Changes
to recognize ed25519 key and return its PKCS8 format
This commit is contained in:
Navaneeth Rameshan 2021-11-24 20:24:06 +01:00 committed by GitHub
parent fe981470ad
commit 4e05632881
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builtin/logical/pki/cert_util.go
View File

@ -1183,6 +1183,12 @@ func convertRespToPKCS8(resp *logical.Response) error {
signer, err = x509.ParsePKCS1PrivateKey(keyData)
case certutil.ECPrivateKey:
signer, err = x509.ParseECPrivateKey(keyData)
case certutil.Ed25519PrivateKey:
k, err := x509.ParsePKCS8PrivateKey(keyData)
if err != nil {
return fmt.Errorf("error converting response to pkcs8: error parsing previous key: %w", err)
}
signer = k.(crypto.Signer)
default:
return fmt.Errorf("unknown private key type %q", privKeyType)
}

3
changelog/13257.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
secrets/pki: Recognize ed25519 when requesting a response in PKCS8 format
```