From 42f7def9aa59d6f778f495685b950a09e96bd0e5 Mon Sep 17 00:00:00 2001
From: Christopher Swenson <christopher.swenson@hashicorp.com>
Date: Thu, 4 May 2023 13:23:06 -0700
Subject: [PATCH] Keep symbols by default (#20519)

By reversing the logic and adding a `REMOVE_SYMBOLS` environment
variable that, when set, will remove symbols.

This has been requested to re-enable Dynatrace support, which
requires symbols are intact.

Sadly this increases the size (on my mac) from 192,609,682 bytes
to 236,696,722 bytes (+23% increase).

I confirmed that this adds symbols back, and that `dlv` will load
the Vault binary.
---
 changelog/20519.txt  | 3 +++
 scripts/ci-helper.sh | 7 +++----
 2 files changed, 6 insertions(+), 4 deletions(-)
 create mode 100644 changelog/20519.txt

diff --git a/changelog/20519.txt b/changelog/20519.txt
new file mode 100644
index 000000000..92f7c2918
--- /dev/null
+++ b/changelog/20519.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+Add debug symbols back to builds to fix Dynatrace support
+```
diff --git a/scripts/ci-helper.sh b/scripts/ci-helper.sh
index 7130fd5e3..4e33a8e8a 100755
--- a/scripts/ci-helper.sh
+++ b/scripts/ci-helper.sh
@@ -154,17 +154,16 @@ function build() {
   prerelease=$(version_pre)
   build_date=$(build_date)
   : "${GO_TAGS:=""}"
-  : "${KEEP_SYMBOLS:=""}"
+  : "${REMOVE_SYMBOLS:=""}"
 
   # Build our ldflags
   msg="--> Building Vault v$version, revision $revision, built $build_date"
 
   # Keep the symbol and dwarf information by default
-  # TODO: maybe add REMOVE_SYMBOLS?
-  if [ -n "$KEEP_SYMBOLS" ]; then
+  if [ -n "$REMOVE_SYMBOLS" ]; then
     ldflags="-s -w "
   else
-    ldflags="-s -w "
+    ldflags=""
   fi
 
   ldflags="${ldflags}-X github.com/hashicorp/vault/version.Version=$version -X github.com/hashicorp/vault/version.GitCommit=$revision -X github.com/hashicorp/vault/version.BuildDate=$build_date"