Revert #13679 since TestCluster_ListenForRequest now fails intermittently in alarming ways. (#13714)

This commit is contained in:
Nick Cabatoff 2022-01-20 08:34:40 -05:00 committed by GitHub
parent 194c9e32d3
commit 4230749d9e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 6 deletions

View File

@ -1,3 +0,0 @@
```release-note:bug
core: Fix how we report the cluster listener is done, prevents `bind: address already in use` errors.
```

View File

@ -6,6 +6,8 @@ import (
"crypto/x509"
"errors"
"fmt"
"github.com/hashicorp/vault/sdk/helper/certutil"
"github.com/hashicorp/vault/sdk/helper/tlsutil"
"net"
"net/url"
"os"
@ -14,9 +16,7 @@ import (
"time"
log "github.com/hashicorp/go-hclog"
"github.com/hashicorp/vault/sdk/helper/certutil"
"github.com/hashicorp/vault/sdk/helper/consts"
"github.com/hashicorp/vault/sdk/helper/tlsutil"
"golang.org/x/net/http2"
)
@ -279,9 +279,9 @@ func (cl *Listener) Run(ctx context.Context) error {
// Start our listening loop
go func(closeCh chan struct{}, tlsLn net.Listener) {
defer func() {
cl.shutdownWg.Done()
tlsLn.Close()
close(closeCh)
cl.shutdownWg.Done()
}()
// baseDelay is the initial delay after an Accept() error before attempting again