luxolus/open-vault
2
0
Fork 0
Code Issues 1 Pull requests Releases Activity

add a check to prevent panics (#5471)

Browse source
This commit is contained in:
Becca Petrin 2018-10-05 09:23:06 -07:00 committed by Jeff Mitchell
parent 380796f4fe
commit 3e3c195773
2 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
helper/ldaputil/client.go
View file

@ -377,6 +377,10 @@ func (c *Client) GetLdapGroups(cfg *ConfigEntry, conn Connection, userDN string,
// EscapeLDAPValue is exported because a plugin uses it outside this package. // EscapeLDAPValue is exported because a plugin uses it outside this package.
func EscapeLDAPValue(input string) string { func EscapeLDAPValue(input string) string {
if input == "" {
return ""
}
// RFC4514 forbids un-escaped: // RFC4514 forbids un-escaped:
// - leading space or hash // - leading space or hash
// - trailing space // - trailing space

1
helper/ldaputil/client_test.go
View file

@ -11,6 +11,7 @@ func TestLDAPEscape(t *testing.T) {
"test,hel+lo": "test\\,hel\\+lo", "test,hel+lo": "test\\,hel\\+lo",
"test\\hello": "test\\\\hello", "test\\hello": "test\\\\hello",
" test ": "\\ test \\ ", " test ": "\\ test \\ ",
"": "",
} }
for test, answer := range testcases { for test, answer := range testcases {