Backport 1.14.3: confirm delete modal for namespaces (#23109)

* Possible soln 1: add a class w/ min height instead of calculated height

* Remove confirm-height style

* Add changelog

* Fix changelog

* Possible soln 2: apply style using native js

* Remove copyright since 1.14 didnt have
This commit is contained in:
Kianna 2023-09-20 08:15:52 -07:00 committed by GitHub
parent 693ba0eddc
commit 3ba22f14e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 7 deletions

3
changelog/23066.txt Normal file
View File

@ -0,0 +1,3 @@
```release-note:bug
ui: Fix the issue where confirm delete dropdown is being cut off
```

View File

@ -32,9 +32,6 @@ export default Component.extend({
openTrigger: null, openTrigger: null,
height: 0, height: 0,
focusTrigger: null, focusTrigger: null,
style: computed('height', function () {
return `height: ${this.height}px`;
}),
wormholeReference: null, wormholeReference: null,
wormholeId: computed('elementId', function () { wormholeId: computed('elementId', function () {
return `confirm-${this.elementId}`; return `confirm-${this.elementId}`;
@ -51,7 +48,7 @@ export default Component.extend({
const height = this.openTrigger const height = this.openTrigger
? this.element.querySelector('.confirm-overlay').clientHeight ? this.element.querySelector('.confirm-overlay').clientHeight
: this.element.querySelector('.confirm').clientHeight; : this.element.querySelector('.confirm').clientHeight;
this.set('height', height); this.element.querySelector('.confirm-wrapper').style = `height: ${height}px;`;
}, },
actions: { actions: {
onTrigger: function (itemId, e) { onTrigger: function (itemId, e) {

View File

@ -1,6 +1,4 @@
{{! template-lint-disable no-inline-styles}} <div class="confirm-wrapper">
<div class="confirm-wrapper" style={{sanitized-html this.style}}>
<div class="confirm {{if this.openTrigger 'show-confirm'}}" ...attributes> <div class="confirm {{if this.openTrigger 'show-confirm'}}" ...attributes>
{{yield {{yield
(hash (hash