luxolus
/
open-vault
2
0
Fork 0
Code Issues 1 Pull Requests Releases Activity

Fix delete role issue on transform (#10417) 

* Fix bug where adding and then removing a new role on a transformation when no other roles have been created causes an error

* Update test on search-select to reflect new behavior which does not add created options to list on delete

* Add changelog
This commit is contained in:
Chelsea Shaw 2020-11-23 10:38:09 -06:00 committed by GitHub
parent dad10ddabc
commit 2e47e39cf7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
changelog/10417.txt Normal file
View File

@ -0,0 +1,4 @@
```release-note:bug
ui: Fix bug in Transform secret engine when a new role is added and then removed from a transformation
```

6
ui/lib/core/addon/components/search-select.js
View File

@ -136,7 +136,7 @@ export default Component.extend({
this.onChange(val); this.onChange(val);
}, },
createOption(optionId) { createOption(optionId) {
let newOption = { name: optionId, id: optionId }; let newOption = { name: optionId, id: optionId, new: true };
this.selectedOptions.pushObject(newOption); this.selectedOptions.pushObject(newOption);
this.handleChange(); this.handleChange();
}, },
@ -147,7 +147,9 @@ export default Component.extend({
}, },
discardSelection(selected) { discardSelection(selected) {
this.selectedOptions.removeObject(selected); this.selectedOptions.removeObject(selected);
this.options.pushObject(selected); if (!selected.new) {
this.options.pushObject(selected);
}
this.handleChange(); this.handleChange();
}, },
constructSuggestion(id) { constructSuggestion(id) {

4
ui/tests/integration/components/search-select-test.js
View File

@ -162,7 +162,7 @@ module('Integration | Component | search select', function(hooks) {
assert.equal(component.options.length, 3, 'shows all options'); assert.equal(component.options.length, 3, 'shows all options');
}); });
test('it adds created item to list items on create and reinserts into drop down on delete', async function(assert) { test('it adds created item to list items on create and removes without adding back to options on delete', async function(assert) {
const models = ['identity/entity']; const models = ['identity/entity'];
this.set('models', models); this.set('models', models);
this.set('onChange', sinon.spy()); this.set('onChange', sinon.spy());
@ -180,7 +180,7 @@ module('Integration | Component | search select', function(hooks) {
assert.equal(component.selectedOptions.length, 0, 'there are no selected options'); assert.equal(component.selectedOptions.length, 0, 'there are no selected options');
assert.ok(this.onChange.calledWith([])); assert.ok(this.onChange.calledWith([]));
await clickTrigger(); await clickTrigger();
assert.equal(component.options.length, 4, 'shows all options, including created option'); assert.equal(component.options.length, 3, 'does not add deleted option back to list');
}); });
test('it uses fallback component if endpoint 403s', async function(assert) { test('it uses fallback component if endpoint 403s', async function(assert) {