Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
package vault_test
|
|
|
|
|
|
|
|
import (
|
2017-08-08 04:18:59 +00:00
|
|
|
"fmt"
|
2017-12-15 18:31:57 +00:00
|
|
|
"io/ioutil"
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
"os"
|
2017-12-15 18:31:57 +00:00
|
|
|
"path/filepath"
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
"testing"
|
2017-09-01 05:02:03 +00:00
|
|
|
"time"
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
|
2018-04-20 18:19:04 +00:00
|
|
|
"github.com/go-test/deep"
|
2021-11-30 19:49:58 +00:00
|
|
|
"github.com/hashicorp/go-hclog"
|
2018-04-20 18:19:04 +00:00
|
|
|
"github.com/hashicorp/vault/api"
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
"github.com/hashicorp/vault/builtin/plugin"
|
2018-09-18 03:03:00 +00:00
|
|
|
"github.com/hashicorp/vault/helper/namespace"
|
2017-07-31 15:28:06 +00:00
|
|
|
vaulthttp "github.com/hashicorp/vault/http"
|
2019-04-13 07:44:06 +00:00
|
|
|
"github.com/hashicorp/vault/sdk/helper/consts"
|
2021-11-30 19:49:58 +00:00
|
|
|
"github.com/hashicorp/vault/sdk/helper/logging"
|
2019-04-13 07:44:06 +00:00
|
|
|
"github.com/hashicorp/vault/sdk/helper/pluginutil"
|
2019-04-12 21:54:35 +00:00
|
|
|
"github.com/hashicorp/vault/sdk/logical"
|
2021-11-30 19:49:58 +00:00
|
|
|
"github.com/hashicorp/vault/sdk/physical"
|
|
|
|
"github.com/hashicorp/vault/sdk/physical/inmem"
|
2019-04-12 21:54:35 +00:00
|
|
|
lplugin "github.com/hashicorp/vault/sdk/plugin"
|
|
|
|
"github.com/hashicorp/vault/sdk/plugin/mock"
|
2022-02-14 20:26:57 +00:00
|
|
|
"github.com/hashicorp/vault/sdk/version"
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
"github.com/hashicorp/vault/vault"
|
|
|
|
)
|
|
|
|
|
2018-09-20 17:50:29 +00:00
|
|
|
const (
|
|
|
|
expectedEnvKey = "FOO"
|
|
|
|
expectedEnvValue = "BAR"
|
|
|
|
)
|
|
|
|
|
2017-08-16 02:10:32 +00:00
|
|
|
func TestSystemBackend_Plugin_secret(t *testing.T) {
|
2017-09-01 05:02:03 +00:00
|
|
|
cluster := testSystemBackendMock(t, 1, 1, logical.TypeLogical)
|
2017-07-31 15:28:06 +00:00
|
|
|
defer cluster.Cleanup()
|
2017-09-01 05:02:03 +00:00
|
|
|
|
|
|
|
core := cluster.Cores[0]
|
|
|
|
|
|
|
|
// Make a request to lazy load the plugin
|
|
|
|
req := logical.TestRequest(t, logical.ReadOperation, "mock-0/internal")
|
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err := core.HandleRequest(namespace.RootContext(nil), req)
|
2017-09-01 05:02:03 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp == nil {
|
|
|
|
t.Fatalf("bad: response should not be nil")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Seal the cluster
|
|
|
|
cluster.EnsureCoresSealed(t)
|
|
|
|
|
|
|
|
// Unseal the cluster
|
|
|
|
barrierKeys := cluster.BarrierKeys
|
|
|
|
for _, core := range cluster.Cores {
|
|
|
|
for _, key := range barrierKeys {
|
|
|
|
_, err := core.Unseal(vault.TestKeyCopy(key))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
2018-07-24 20:57:25 +00:00
|
|
|
if core.Sealed() {
|
2017-09-01 05:02:03 +00:00
|
|
|
t.Fatal("should not be sealed")
|
|
|
|
}
|
|
|
|
// Wait for active so post-unseal takes place
|
|
|
|
// If it fails, it means unseal process failed
|
|
|
|
vault.TestWaitActive(t, core.Core)
|
|
|
|
}
|
2017-08-16 02:10:32 +00:00
|
|
|
}
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
|
2017-08-16 02:10:32 +00:00
|
|
|
func TestSystemBackend_Plugin_auth(t *testing.T) {
|
2017-09-01 05:02:03 +00:00
|
|
|
cluster := testSystemBackendMock(t, 1, 1, logical.TypeCredential)
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
|
|
|
|
core := cluster.Cores[0]
|
|
|
|
|
|
|
|
// Make a request to lazy load the plugin
|
|
|
|
req := logical.TestRequest(t, logical.ReadOperation, "auth/mock-0/internal")
|
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err := core.HandleRequest(namespace.RootContext(nil), req)
|
2017-09-01 05:02:03 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp == nil {
|
|
|
|
t.Fatalf("bad: response should not be nil")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Seal the cluster
|
|
|
|
cluster.EnsureCoresSealed(t)
|
|
|
|
|
|
|
|
// Unseal the cluster
|
|
|
|
barrierKeys := cluster.BarrierKeys
|
|
|
|
for _, core := range cluster.Cores {
|
|
|
|
for _, key := range barrierKeys {
|
|
|
|
_, err := core.Unseal(vault.TestKeyCopy(key))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
2018-07-24 20:57:25 +00:00
|
|
|
if core.Sealed() {
|
2017-09-01 05:02:03 +00:00
|
|
|
t.Fatal("should not be sealed")
|
|
|
|
}
|
|
|
|
// Wait for active so post-unseal takes place
|
|
|
|
// If it fails, it means unseal process failed
|
|
|
|
vault.TestWaitActive(t, core.Core)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-12-10 18:48:30 +00:00
|
|
|
func TestSystemBackend_Plugin_MissingBinary(t *testing.T) {
|
|
|
|
cluster := testSystemBackendMock(t, 1, 1, logical.TypeLogical)
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
|
|
|
|
core := cluster.Cores[0]
|
|
|
|
|
|
|
|
// Make a request to lazy load the plugin
|
|
|
|
req := logical.TestRequest(t, logical.ReadOperation, "mock-0/internal")
|
|
|
|
req.ClientToken = core.Client.Token()
|
|
|
|
resp, err := core.HandleRequest(namespace.RootContext(nil), req)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp == nil {
|
|
|
|
t.Fatalf("bad: response should not be nil")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Seal the cluster
|
|
|
|
cluster.EnsureCoresSealed(t)
|
|
|
|
|
|
|
|
// Simulate removal of the plugin binary. Use os.Args to determine file name
|
|
|
|
// since that's how we create the file for catalog registration in the test
|
|
|
|
// helper.
|
|
|
|
pluginFileName := filepath.Base(os.Args[0])
|
|
|
|
err = os.Remove(filepath.Join(cluster.TempDir, pluginFileName))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Unseal the cluster
|
|
|
|
cluster.UnsealCores(t)
|
|
|
|
|
|
|
|
// Make a request against on tune after it is removed
|
|
|
|
req = logical.TestRequest(t, logical.ReadOperation, "sys/mounts/mock-0/tune")
|
|
|
|
req.ClientToken = core.Client.Token()
|
|
|
|
resp, err = core.HandleRequest(namespace.RootContext(nil), req)
|
|
|
|
if err == nil {
|
|
|
|
t.Fatalf("expected error")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-09-01 05:02:03 +00:00
|
|
|
func TestSystemBackend_Plugin_MismatchType(t *testing.T) {
|
|
|
|
cluster := testSystemBackendMock(t, 1, 1, logical.TypeLogical)
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
|
|
|
|
core := cluster.Cores[0]
|
|
|
|
|
2018-11-07 01:21:24 +00:00
|
|
|
// Add a credential backend with the same name
|
|
|
|
vault.TestAddTestPlugin(t, core.Core, "mock-plugin", consts.PluginTypeCredential, "TestBackend_PluginMainCredentials", []string{}, "")
|
2017-09-01 05:02:03 +00:00
|
|
|
|
|
|
|
// Make a request to lazy load the now-credential plugin
|
|
|
|
// and expect an error
|
|
|
|
req := logical.TestRequest(t, logical.ReadOperation, "mock-0/internal")
|
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
_, err := core.HandleRequest(namespace.RootContext(nil), req)
|
2018-11-07 01:21:24 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("adding a same-named plugin of a different type should be no problem: %s", err)
|
2017-09-01 05:02:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Sleep a bit before cleanup is called
|
|
|
|
time.Sleep(1 * time.Second)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSystemBackend_Plugin_CatalogRemoved(t *testing.T) {
|
|
|
|
t.Run("secret", func(t *testing.T) {
|
|
|
|
testPlugin_CatalogRemoved(t, logical.TypeLogical, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("auth", func(t *testing.T) {
|
|
|
|
testPlugin_CatalogRemoved(t, logical.TypeCredential, false)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("secret-mount-existing", func(t *testing.T) {
|
|
|
|
testPlugin_CatalogRemoved(t, logical.TypeLogical, true)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("auth-mount-existing", func(t *testing.T) {
|
|
|
|
testPlugin_CatalogRemoved(t, logical.TypeCredential, true)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func testPlugin_CatalogRemoved(t *testing.T, btype logical.BackendType, testMount bool) {
|
|
|
|
cluster := testSystemBackendMock(t, 1, 1, btype)
|
2017-08-16 02:10:32 +00:00
|
|
|
defer cluster.Cleanup()
|
2017-09-01 05:02:03 +00:00
|
|
|
|
|
|
|
core := cluster.Cores[0]
|
|
|
|
|
|
|
|
// Remove the plugin from the catalog
|
2018-11-07 01:21:24 +00:00
|
|
|
req := logical.TestRequest(t, logical.DeleteOperation, "sys/plugins/catalog/database/mock-plugin")
|
2017-09-01 05:02:03 +00:00
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err := core.HandleRequest(namespace.RootContext(nil), req)
|
2017-09-01 05:02:03 +00:00
|
|
|
if err != nil || (resp != nil && resp.IsError()) {
|
|
|
|
t.Fatalf("err:%v resp:%#v", err, resp)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Seal the cluster
|
|
|
|
cluster.EnsureCoresSealed(t)
|
|
|
|
|
|
|
|
// Unseal the cluster
|
|
|
|
barrierKeys := cluster.BarrierKeys
|
|
|
|
for _, core := range cluster.Cores {
|
|
|
|
for _, key := range barrierKeys {
|
|
|
|
_, err := core.Unseal(vault.TestKeyCopy(key))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
2018-07-24 20:57:25 +00:00
|
|
|
if core.Sealed() {
|
2017-09-01 05:02:03 +00:00
|
|
|
t.Fatal("should not be sealed")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-06 23:06:09 +00:00
|
|
|
// Wait for active so post-unseal takes place
|
|
|
|
// If it fails, it means unseal process failed
|
|
|
|
vault.TestWaitActive(t, core.Core)
|
|
|
|
|
2017-09-01 05:02:03 +00:00
|
|
|
if testMount {
|
|
|
|
// Mount the plugin at the same path after plugin is re-added to the catalog
|
|
|
|
// and expect an error due to existing path.
|
|
|
|
var err error
|
|
|
|
switch btype {
|
|
|
|
case logical.TypeLogical:
|
2017-12-15 18:31:57 +00:00
|
|
|
// Add plugin back to the catalog
|
2018-11-07 01:21:24 +00:00
|
|
|
vault.TestAddTestPlugin(t, core.Core, "mock-plugin", consts.PluginTypeSecrets, "TestBackend_PluginMainLogical", []string{}, "")
|
2017-09-01 05:02:03 +00:00
|
|
|
_, err = core.Client.Logical().Write("sys/mounts/mock-0", map[string]interface{}{
|
2018-11-07 01:21:24 +00:00
|
|
|
"type": "test",
|
2017-09-01 05:02:03 +00:00
|
|
|
})
|
|
|
|
case logical.TypeCredential:
|
2017-12-15 18:31:57 +00:00
|
|
|
// Add plugin back to the catalog
|
2018-11-07 01:21:24 +00:00
|
|
|
vault.TestAddTestPlugin(t, core.Core, "mock-plugin", consts.PluginTypeCredential, "TestBackend_PluginMainCredentials", []string{}, "")
|
2017-09-01 05:02:03 +00:00
|
|
|
_, err = core.Client.Logical().Write("sys/auth/mock-0", map[string]interface{}{
|
2018-11-07 01:21:24 +00:00
|
|
|
"type": "test",
|
2017-09-01 05:02:03 +00:00
|
|
|
})
|
|
|
|
}
|
|
|
|
if err == nil {
|
|
|
|
t.Fatal("expected error when mounting on existing path")
|
|
|
|
}
|
|
|
|
}
|
2017-08-16 02:10:32 +00:00
|
|
|
}
|
2017-07-31 15:28:06 +00:00
|
|
|
|
2017-12-15 18:31:57 +00:00
|
|
|
func TestSystemBackend_Plugin_continueOnError(t *testing.T) {
|
|
|
|
t.Run("secret", func(t *testing.T) {
|
|
|
|
t.Run("sha256_mismatch", func(t *testing.T) {
|
2021-05-27 18:37:45 +00:00
|
|
|
testPlugin_continueOnError(t, logical.TypeLogical, true, "mock-plugin", consts.PluginTypeSecrets)
|
2017-12-15 18:31:57 +00:00
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("missing_plugin", func(t *testing.T) {
|
2021-05-27 18:37:45 +00:00
|
|
|
testPlugin_continueOnError(t, logical.TypeLogical, false, "mock-plugin", consts.PluginTypeSecrets)
|
2017-12-15 18:31:57 +00:00
|
|
|
})
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("auth", func(t *testing.T) {
|
|
|
|
t.Run("sha256_mismatch", func(t *testing.T) {
|
2021-05-27 18:37:45 +00:00
|
|
|
testPlugin_continueOnError(t, logical.TypeCredential, true, "mock-plugin", consts.PluginTypeCredential)
|
2017-12-15 18:31:57 +00:00
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("missing_plugin", func(t *testing.T) {
|
2021-05-27 18:37:45 +00:00
|
|
|
testPlugin_continueOnError(t, logical.TypeCredential, false, "mock-plugin", consts.PluginTypeCredential)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("sha256_mismatch", func(t *testing.T) {
|
|
|
|
testPlugin_continueOnError(t, logical.TypeCredential, true, "oidc", consts.PluginTypeCredential)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("missing_plugin", func(t *testing.T) {
|
|
|
|
testPlugin_continueOnError(t, logical.TypeCredential, false, "oidc", consts.PluginTypeCredential)
|
2017-12-15 18:31:57 +00:00
|
|
|
})
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2021-05-27 18:37:45 +00:00
|
|
|
func testPlugin_continueOnError(t *testing.T, btype logical.BackendType, mismatch bool, mountPoint string, pluginType consts.PluginType) {
|
2017-12-15 18:31:57 +00:00
|
|
|
cluster := testSystemBackendMock(t, 1, 1, btype)
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
|
|
|
|
core := cluster.Cores[0]
|
|
|
|
|
|
|
|
// Get the registered plugin
|
2018-11-07 01:21:24 +00:00
|
|
|
req := logical.TestRequest(t, logical.ReadOperation, fmt.Sprintf("sys/plugins/catalog/%s/mock-plugin", pluginType))
|
2017-12-15 18:31:57 +00:00
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err := core.HandleRequest(namespace.RootContext(nil), req)
|
2017-12-15 18:31:57 +00:00
|
|
|
if err != nil || resp == nil || (resp != nil && resp.IsError()) {
|
|
|
|
t.Fatalf("err:%v resp:%#v", err, resp)
|
|
|
|
}
|
|
|
|
|
|
|
|
command, ok := resp.Data["command"].(string)
|
|
|
|
if !ok || command == "" {
|
|
|
|
t.Fatal("invalid command")
|
|
|
|
}
|
|
|
|
|
2021-05-27 18:37:45 +00:00
|
|
|
// Mount credential type plugins
|
|
|
|
switch btype {
|
|
|
|
case logical.TypeCredential:
|
|
|
|
vault.TestAddTestPlugin(t, core.Core, mountPoint, consts.PluginTypeCredential, "TestBackend_PluginMainCredentials", []string{}, cluster.TempDir)
|
|
|
|
_, err = core.Client.Logical().Write(fmt.Sprintf("sys/auth/%s", mountPoint), map[string]interface{}{
|
|
|
|
"type": "mock-plugin",
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err:%v", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-20 18:54:10 +00:00
|
|
|
// Trigger a sha256 mismatch or missing plugin error
|
2017-12-15 18:31:57 +00:00
|
|
|
if mismatch {
|
2021-05-27 18:37:45 +00:00
|
|
|
req = logical.TestRequest(t, logical.UpdateOperation, fmt.Sprintf("sys/plugins/catalog/%s/mock-plugin", pluginType))
|
2017-12-15 18:31:57 +00:00
|
|
|
req.Data = map[string]interface{}{
|
|
|
|
"sha256": "d17bd7334758e53e6fbab15745d2520765c06e296f2ce8e25b7919effa0ac216",
|
|
|
|
"command": filepath.Base(command),
|
|
|
|
}
|
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err = core.HandleRequest(namespace.RootContext(nil), req)
|
2017-12-15 18:31:57 +00:00
|
|
|
if err != nil || (resp != nil && resp.IsError()) {
|
|
|
|
t.Fatalf("err:%v resp:%#v", err, resp)
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
err := os.Remove(filepath.Join(cluster.TempDir, filepath.Base(command)))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Seal the cluster
|
|
|
|
cluster.EnsureCoresSealed(t)
|
|
|
|
|
|
|
|
// Unseal the cluster
|
|
|
|
barrierKeys := cluster.BarrierKeys
|
|
|
|
for _, core := range cluster.Cores {
|
|
|
|
for _, key := range barrierKeys {
|
|
|
|
_, err := core.Unseal(vault.TestKeyCopy(key))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
2018-07-24 20:57:25 +00:00
|
|
|
if core.Sealed() {
|
2017-12-15 18:31:57 +00:00
|
|
|
t.Fatal("should not be sealed")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-06 23:06:09 +00:00
|
|
|
// Wait for active so post-unseal takes place
|
|
|
|
// If it fails, it means unseal process failed
|
|
|
|
vault.TestWaitActive(t, core.Core)
|
|
|
|
|
2017-12-15 18:31:57 +00:00
|
|
|
// Re-add the plugin to the catalog
|
|
|
|
switch btype {
|
|
|
|
case logical.TypeLogical:
|
2018-11-07 01:21:24 +00:00
|
|
|
vault.TestAddTestPlugin(t, core.Core, "mock-plugin", consts.PluginTypeSecrets, "TestBackend_PluginMainLogical", []string{}, cluster.TempDir)
|
2017-12-15 18:31:57 +00:00
|
|
|
case logical.TypeCredential:
|
2018-11-07 01:21:24 +00:00
|
|
|
vault.TestAddTestPlugin(t, core.Core, "mock-plugin", consts.PluginTypeCredential, "TestBackend_PluginMainCredentials", []string{}, cluster.TempDir)
|
2017-12-15 18:31:57 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Reload the plugin
|
|
|
|
req = logical.TestRequest(t, logical.UpdateOperation, "sys/plugins/reload/backend")
|
|
|
|
req.Data = map[string]interface{}{
|
|
|
|
"plugin": "mock-plugin",
|
|
|
|
}
|
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err = core.HandleRequest(namespace.RootContext(nil), req)
|
2017-12-15 18:31:57 +00:00
|
|
|
if err != nil || (resp != nil && resp.IsError()) {
|
|
|
|
t.Fatalf("err:%v resp:%#v", err, resp)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make a request to lazy load the plugin
|
|
|
|
var reqPath string
|
|
|
|
switch btype {
|
|
|
|
case logical.TypeLogical:
|
|
|
|
reqPath = "mock-0/internal"
|
|
|
|
case logical.TypeCredential:
|
|
|
|
reqPath = "auth/mock-0/internal"
|
|
|
|
}
|
|
|
|
|
|
|
|
req = logical.TestRequest(t, logical.ReadOperation, reqPath)
|
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err = core.HandleRequest(namespace.RootContext(nil), req)
|
2017-12-15 18:31:57 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp == nil {
|
|
|
|
t.Fatalf("bad: response should not be nil")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-08-16 02:10:32 +00:00
|
|
|
func TestSystemBackend_Plugin_autoReload(t *testing.T) {
|
2017-09-01 05:02:03 +00:00
|
|
|
cluster := testSystemBackendMock(t, 1, 1, logical.TypeLogical)
|
2017-08-16 02:10:32 +00:00
|
|
|
defer cluster.Cleanup()
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
|
2017-08-16 02:10:32 +00:00
|
|
|
core := cluster.Cores[0]
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
|
2017-08-16 02:10:32 +00:00
|
|
|
// Update internal value
|
|
|
|
req := logical.TestRequest(t, logical.UpdateOperation, "mock-0/internal")
|
|
|
|
req.ClientToken = core.Client.Token()
|
|
|
|
req.Data["value"] = "baz"
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err := core.HandleRequest(namespace.RootContext(nil), req)
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp != nil {
|
|
|
|
t.Fatalf("bad: %v", resp)
|
|
|
|
}
|
2017-08-16 02:10:32 +00:00
|
|
|
|
|
|
|
// Call errors/rpc endpoint to trigger reload
|
|
|
|
req = logical.TestRequest(t, logical.ReadOperation, "mock-0/errors/rpc")
|
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err = core.HandleRequest(namespace.RootContext(nil), req)
|
2017-08-16 02:10:32 +00:00
|
|
|
if err == nil {
|
|
|
|
t.Fatalf("expected error from error/rpc request")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check internal value to make sure it's reset
|
|
|
|
req = logical.TestRequest(t, logical.ReadOperation, "mock-0/internal")
|
|
|
|
req.ClientToken = core.Client.Token()
|
2018-09-18 03:03:00 +00:00
|
|
|
resp, err = core.HandleRequest(namespace.RootContext(nil), req)
|
2017-08-16 02:10:32 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp == nil {
|
|
|
|
t.Fatalf("bad: response should not be nil")
|
|
|
|
}
|
|
|
|
if resp.Data["value"].(string) == "baz" {
|
|
|
|
t.Fatal("did not expect backend internal value to be 'baz'")
|
|
|
|
}
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
}
|
|
|
|
|
2017-09-01 05:02:03 +00:00
|
|
|
func TestSystemBackend_Plugin_SealUnseal(t *testing.T) {
|
|
|
|
cluster := testSystemBackendMock(t, 1, 1, logical.TypeLogical)
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
|
|
|
|
// Seal the cluster
|
|
|
|
cluster.EnsureCoresSealed(t)
|
|
|
|
|
|
|
|
// Unseal the cluster
|
|
|
|
barrierKeys := cluster.BarrierKeys
|
|
|
|
for _, core := range cluster.Cores {
|
|
|
|
for _, key := range barrierKeys {
|
|
|
|
_, err := core.Unseal(vault.TestKeyCopy(key))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
2018-07-24 20:57:25 +00:00
|
|
|
if core.Sealed() {
|
2017-09-01 05:02:03 +00:00
|
|
|
t.Fatal("should not be sealed")
|
|
|
|
}
|
|
|
|
}
|
2018-03-06 23:06:09 +00:00
|
|
|
|
|
|
|
// Wait for active so post-unseal takes place
|
|
|
|
// If it fails, it means unseal process failed
|
|
|
|
vault.TestWaitActive(t, cluster.Cores[0].Core)
|
2017-09-01 05:02:03 +00:00
|
|
|
}
|
|
|
|
|
2017-08-16 02:10:32 +00:00
|
|
|
func TestSystemBackend_Plugin_reload(t *testing.T) {
|
2017-08-08 04:18:59 +00:00
|
|
|
data := map[string]interface{}{
|
|
|
|
"plugin": "mock-plugin",
|
|
|
|
}
|
|
|
|
t.Run("plugin", func(t *testing.T) { testSystemBackend_PluginReload(t, data) })
|
|
|
|
|
|
|
|
data = map[string]interface{}{
|
|
|
|
"mounts": "mock-0/,mock-1/",
|
|
|
|
}
|
|
|
|
t.Run("mounts", func(t *testing.T) { testSystemBackend_PluginReload(t, data) })
|
|
|
|
}
|
|
|
|
|
2017-09-01 05:02:03 +00:00
|
|
|
// Helper func to test different reload methods on plugin reload endpoint
|
2017-08-08 04:18:59 +00:00
|
|
|
func testSystemBackend_PluginReload(t *testing.T, reqData map[string]interface{}) {
|
2017-09-01 05:02:03 +00:00
|
|
|
cluster := testSystemBackendMock(t, 1, 2, logical.TypeLogical)
|
2017-08-08 04:18:59 +00:00
|
|
|
defer cluster.Cleanup()
|
|
|
|
|
|
|
|
core := cluster.Cores[0]
|
2017-08-16 02:10:32 +00:00
|
|
|
client := core.Client
|
2017-08-08 04:18:59 +00:00
|
|
|
|
|
|
|
for i := 0; i < 2; i++ {
|
|
|
|
// Update internal value in the backend
|
2017-08-16 02:10:32 +00:00
|
|
|
resp, err := client.Logical().Write(fmt.Sprintf("mock-%d/internal", i), map[string]interface{}{
|
|
|
|
"value": "baz",
|
|
|
|
})
|
2017-08-08 04:18:59 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp != nil {
|
|
|
|
t.Fatalf("bad: %v", resp)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Perform plugin reload
|
2017-08-16 16:40:38 +00:00
|
|
|
resp, err := client.Logical().Write("sys/plugins/reload/backend", reqData)
|
2017-08-08 04:18:59 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
2020-06-30 18:33:30 +00:00
|
|
|
if resp == nil {
|
2017-08-08 04:18:59 +00:00
|
|
|
t.Fatalf("bad: %v", resp)
|
|
|
|
}
|
2020-06-30 18:33:30 +00:00
|
|
|
if resp.Data["reload_id"] == nil {
|
|
|
|
t.Fatal("no reload_id in response")
|
|
|
|
}
|
2017-08-08 04:18:59 +00:00
|
|
|
|
|
|
|
for i := 0; i < 2; i++ {
|
|
|
|
// Ensure internal backed value is reset
|
2017-08-16 02:10:32 +00:00
|
|
|
resp, err := client.Logical().Read(fmt.Sprintf("mock-%d/internal", i))
|
2017-08-08 04:18:59 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp == nil {
|
|
|
|
t.Fatalf("bad: response should not be nil")
|
|
|
|
}
|
|
|
|
if resp.Data["value"].(string) == "baz" {
|
|
|
|
t.Fatal("did not expect backend internal value to be 'baz'")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// testSystemBackendMock returns a systemBackend with the desired number
|
2017-12-15 18:31:57 +00:00
|
|
|
// of mounted mock plugin backends. numMounts alternates between different
|
|
|
|
// ways of providing the plugin_name.
|
|
|
|
//
|
|
|
|
// The mounts are mounted at sys/mounts/mock-[numMounts] or sys/auth/mock-[numMounts]
|
2017-09-01 05:02:03 +00:00
|
|
|
func testSystemBackendMock(t *testing.T, numCores, numMounts int, backendType logical.BackendType) *vault.TestCluster {
|
2017-08-08 04:18:59 +00:00
|
|
|
coreConfig := &vault.CoreConfig{
|
|
|
|
LogicalBackends: map[string]logical.Factory{
|
|
|
|
"plugin": plugin.Factory,
|
|
|
|
},
|
2017-08-16 02:10:32 +00:00
|
|
|
CredentialBackends: map[string]logical.Factory{
|
|
|
|
"plugin": plugin.Factory,
|
|
|
|
},
|
2017-08-08 04:18:59 +00:00
|
|
|
}
|
|
|
|
|
2017-12-15 18:31:57 +00:00
|
|
|
// Create a tempdir, cluster.Cleanup will clean up this directory
|
|
|
|
tempDir, err := ioutil.TempDir("", "vault-test-cluster")
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
2017-08-08 04:18:59 +00:00
|
|
|
cluster := vault.NewTestCluster(t, coreConfig, &vault.TestClusterOptions{
|
2017-09-01 05:02:03 +00:00
|
|
|
HandlerFunc: vaulthttp.Handler,
|
|
|
|
KeepStandbysSealed: true,
|
|
|
|
NumCores: numCores,
|
2017-12-15 18:31:57 +00:00
|
|
|
TempDir: tempDir,
|
2017-08-08 04:18:59 +00:00
|
|
|
})
|
|
|
|
cluster.Start()
|
|
|
|
|
2017-08-16 02:10:32 +00:00
|
|
|
core := cluster.Cores[0]
|
|
|
|
vault.TestWaitActive(t, core.Core)
|
|
|
|
client := core.Client
|
2017-08-08 04:18:59 +00:00
|
|
|
|
|
|
|
os.Setenv(pluginutil.PluginCACertPEMEnv, cluster.CACertPEMFile)
|
|
|
|
|
2017-08-16 02:10:32 +00:00
|
|
|
switch backendType {
|
|
|
|
case logical.TypeLogical:
|
2018-11-07 01:21:24 +00:00
|
|
|
vault.TestAddTestPlugin(t, core.Core, "mock-plugin", consts.PluginTypeSecrets, "TestBackend_PluginMainLogical", []string{}, tempDir)
|
2017-08-16 02:10:32 +00:00
|
|
|
for i := 0; i < numMounts; i++ {
|
2017-08-31 16:16:59 +00:00
|
|
|
// Alternate input styles for plugin_name on every other mount
|
|
|
|
options := map[string]interface{}{
|
2018-11-07 01:21:24 +00:00
|
|
|
"type": "mock-plugin",
|
2017-08-31 16:16:59 +00:00
|
|
|
}
|
|
|
|
resp, err := client.Logical().Write(fmt.Sprintf("sys/mounts/mock-%d", i), options)
|
2017-08-16 02:10:32 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp != nil {
|
|
|
|
t.Fatalf("bad: %v", resp)
|
|
|
|
}
|
2017-08-08 04:18:59 +00:00
|
|
|
}
|
2017-08-16 02:10:32 +00:00
|
|
|
case logical.TypeCredential:
|
2018-11-07 01:21:24 +00:00
|
|
|
vault.TestAddTestPlugin(t, core.Core, "mock-plugin", consts.PluginTypeCredential, "TestBackend_PluginMainCredentials", []string{}, tempDir)
|
2017-08-16 02:10:32 +00:00
|
|
|
for i := 0; i < numMounts; i++ {
|
2017-08-31 16:16:59 +00:00
|
|
|
// Alternate input styles for plugin_name on every other mount
|
|
|
|
options := map[string]interface{}{
|
2018-11-07 01:21:24 +00:00
|
|
|
"type": "mock-plugin",
|
2017-08-31 16:16:59 +00:00
|
|
|
}
|
|
|
|
resp, err := client.Logical().Write(fmt.Sprintf("sys/auth/mock-%d", i), options)
|
2017-08-16 02:10:32 +00:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp != nil {
|
|
|
|
t.Fatalf("bad: %v", resp)
|
|
|
|
}
|
2017-08-08 04:18:59 +00:00
|
|
|
}
|
2017-08-16 02:10:32 +00:00
|
|
|
default:
|
|
|
|
t.Fatal("unknown backend type provided")
|
2017-08-08 04:18:59 +00:00
|
|
|
}
|
|
|
|
|
2017-08-16 02:10:32 +00:00
|
|
|
return cluster
|
2017-08-08 04:18:59 +00:00
|
|
|
}
|
|
|
|
|
2018-09-20 17:50:29 +00:00
|
|
|
func TestSystemBackend_Plugin_Env(t *testing.T) {
|
|
|
|
kvPair := fmt.Sprintf("%s=%s", expectedEnvKey, expectedEnvValue)
|
|
|
|
cluster := testSystemBackend_SingleCluster_Env(t, []string{kvPair})
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
}
|
|
|
|
|
|
|
|
// testSystemBackend_SingleCluster_Env is a helper func that returns a single
|
|
|
|
// cluster and a single mounted plugin logical backend.
|
|
|
|
func testSystemBackend_SingleCluster_Env(t *testing.T, env []string) *vault.TestCluster {
|
|
|
|
coreConfig := &vault.CoreConfig{
|
|
|
|
LogicalBackends: map[string]logical.Factory{
|
2018-11-07 01:21:24 +00:00
|
|
|
"test": plugin.Factory,
|
2018-09-20 17:50:29 +00:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
// Create a tempdir, cluster.Cleanup will clean up this directory
|
|
|
|
tempDir, err := ioutil.TempDir("", "vault-test-cluster")
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
cluster := vault.NewTestCluster(t, coreConfig, &vault.TestClusterOptions{
|
|
|
|
HandlerFunc: vaulthttp.Handler,
|
|
|
|
KeepStandbysSealed: true,
|
|
|
|
NumCores: 1,
|
|
|
|
TempDir: tempDir,
|
|
|
|
})
|
|
|
|
cluster.Start()
|
|
|
|
|
|
|
|
core := cluster.Cores[0]
|
|
|
|
vault.TestWaitActive(t, core.Core)
|
|
|
|
client := core.Client
|
|
|
|
|
|
|
|
os.Setenv(pluginutil.PluginCACertPEMEnv, cluster.CACertPEMFile)
|
|
|
|
|
2018-11-07 01:21:24 +00:00
|
|
|
vault.TestAddTestPlugin(t, core.Core, "mock-plugin", consts.PluginTypeSecrets, "TestBackend_PluginMainEnv", env, tempDir)
|
2018-09-20 17:50:29 +00:00
|
|
|
options := map[string]interface{}{
|
2018-11-07 01:21:24 +00:00
|
|
|
"type": "mock-plugin",
|
2018-09-20 17:50:29 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
resp, err := client.Logical().Write("sys/mounts/mock", options)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("err: %v", err)
|
|
|
|
}
|
|
|
|
if resp != nil {
|
|
|
|
t.Fatalf("bad: %v", resp)
|
|
|
|
}
|
|
|
|
|
|
|
|
return cluster
|
|
|
|
}
|
|
|
|
|
2017-08-08 04:18:59 +00:00
|
|
|
func TestBackend_PluginMainLogical(t *testing.T) {
|
2017-09-01 05:02:03 +00:00
|
|
|
args := []string{}
|
2018-03-20 18:54:10 +00:00
|
|
|
if os.Getenv(pluginutil.PluginUnwrapTokenEnv) == "" && os.Getenv(pluginutil.PluginMetadataModeEnv) != "true" {
|
2017-08-08 04:18:59 +00:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
caPEM := os.Getenv(pluginutil.PluginCACertPEMEnv)
|
|
|
|
if caPEM == "" {
|
|
|
|
t.Fatal("CA cert not passed in")
|
|
|
|
}
|
2017-09-01 05:02:03 +00:00
|
|
|
args = append(args, fmt.Sprintf("--ca-cert=%s", caPEM))
|
2017-08-08 04:18:59 +00:00
|
|
|
|
2019-04-15 18:10:07 +00:00
|
|
|
apiClientMeta := &api.PluginAPIClientMeta{}
|
2017-08-08 04:18:59 +00:00
|
|
|
flags := apiClientMeta.FlagSet()
|
|
|
|
flags.Parse(args)
|
|
|
|
tlsConfig := apiClientMeta.GetTLSConfig()
|
2019-04-12 21:54:35 +00:00
|
|
|
tlsProviderFunc := api.VaultPluginTLSProvider(tlsConfig)
|
2017-09-01 05:02:03 +00:00
|
|
|
|
|
|
|
factoryFunc := mock.FactoryType(logical.TypeLogical)
|
|
|
|
|
2017-08-08 04:18:59 +00:00
|
|
|
err := lplugin.Serve(&lplugin.ServeOpts{
|
|
|
|
BackendFactoryFunc: factoryFunc,
|
|
|
|
TLSProviderFunc: tlsProviderFunc,
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestBackend_PluginMainCredentials(t *testing.T) {
|
2017-09-01 05:02:03 +00:00
|
|
|
args := []string{}
|
2018-03-20 18:54:10 +00:00
|
|
|
if os.Getenv(pluginutil.PluginUnwrapTokenEnv) == "" && os.Getenv(pluginutil.PluginMetadataModeEnv) != "true" {
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2017-07-31 19:09:09 +00:00
|
|
|
caPEM := os.Getenv(pluginutil.PluginCACertPEMEnv)
|
|
|
|
if caPEM == "" {
|
2017-07-31 15:28:06 +00:00
|
|
|
t.Fatal("CA cert not passed in")
|
|
|
|
}
|
2017-09-01 05:02:03 +00:00
|
|
|
args = append(args, fmt.Sprintf("--ca-cert=%s", caPEM))
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
|
2019-04-15 18:10:07 +00:00
|
|
|
apiClientMeta := &api.PluginAPIClientMeta{}
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
flags := apiClientMeta.FlagSet()
|
|
|
|
flags.Parse(args)
|
|
|
|
tlsConfig := apiClientMeta.GetTLSConfig()
|
2019-04-12 21:54:35 +00:00
|
|
|
tlsProviderFunc := api.VaultPluginTLSProvider(tlsConfig)
|
2017-09-01 05:02:03 +00:00
|
|
|
|
|
|
|
factoryFunc := mock.FactoryType(logical.TypeCredential)
|
|
|
|
|
2017-07-31 19:31:44 +00:00
|
|
|
err := lplugin.Serve(&lplugin.ServeOpts{
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
BackendFactoryFunc: factoryFunc,
|
2018-09-20 17:50:29 +00:00
|
|
|
TLSProviderFunc: tlsProviderFunc,
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// TestBackend_PluginMainEnv is a mock plugin that simply checks for the existence of FOO env var.
|
|
|
|
func TestBackend_PluginMainEnv(t *testing.T) {
|
|
|
|
args := []string{}
|
|
|
|
if os.Getenv(pluginutil.PluginUnwrapTokenEnv) == "" && os.Getenv(pluginutil.PluginMetadataModeEnv) != "true" {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-09-25 16:22:34 +00:00
|
|
|
// Check on actual vs expected env var
|
|
|
|
actual := os.Getenv(expectedEnvKey)
|
|
|
|
if actual != expectedEnvValue {
|
|
|
|
t.Fatalf("expected: %q, got: %q", expectedEnvValue, actual)
|
|
|
|
}
|
|
|
|
|
2018-09-20 17:50:29 +00:00
|
|
|
caPEM := os.Getenv(pluginutil.PluginCACertPEMEnv)
|
|
|
|
if caPEM == "" {
|
|
|
|
t.Fatal("CA cert not passed in")
|
|
|
|
}
|
|
|
|
args = append(args, fmt.Sprintf("--ca-cert=%s", caPEM))
|
|
|
|
|
2019-04-15 18:10:07 +00:00
|
|
|
apiClientMeta := &api.PluginAPIClientMeta{}
|
2018-09-20 17:50:29 +00:00
|
|
|
flags := apiClientMeta.FlagSet()
|
|
|
|
flags.Parse(args)
|
|
|
|
tlsConfig := apiClientMeta.GetTLSConfig()
|
2019-04-12 21:54:35 +00:00
|
|
|
tlsProviderFunc := api.VaultPluginTLSProvider(tlsConfig)
|
2018-09-20 17:50:29 +00:00
|
|
|
|
|
|
|
factoryFunc := mock.FactoryType(logical.TypeLogical)
|
|
|
|
|
|
|
|
err := lplugin.Serve(&lplugin.ServeOpts{
|
|
|
|
BackendFactoryFunc: factoryFunc,
|
Backend plugin system (#2874)
* Add backend plugin changes
* Fix totp backend plugin tests
* Fix logical/plugin InvalidateKey test
* Fix plugin catalog CRUD test, fix NoopBackend
* Clean up commented code block
* Fix system backend mount test
* Set plugin_name to omitempty, fix handleMountTable config parsing
* Clean up comments, keep shim connections alive until cleanup
* Include pluginClient, disallow LookupPlugin call from within a plugin
* Add wrapper around backendPluginClient for proper cleanup
* Add logger shim tests
* Add logger, storage, and system shim tests
* Use pointer receivers for system view shim
* Use plugin name if no path is provided on mount
* Enable plugins for auth backends
* Add backend type attribute, move builtin/plugin/package
* Fix merge conflict
* Fix missing plugin name in mount config
* Add integration tests on enabling auth backend plugins
* Remove dependency cycle on mock-plugin
* Add passthrough backend plugin, use logical.BackendType to determine lease generation
* Remove vault package dependency on passthrough package
* Add basic impl test for passthrough plugin
* Incorporate feedback; set b.backend after shims creation on backendPluginServer
* Fix totp plugin test
* Add plugin backends docs
* Fix tests
* Fix builtin/plugin tests
* Remove flatten from PluginRunner fields
* Move mock plugin to logical/plugin, remove totp and passthrough plugins
* Move pluginMap into newPluginClient
* Do not create storage RPC connection on HandleRequest and HandleExistenceCheck
* Change shim logger's Fatal to no-op
* Change BackendType to uint32, match UX backend types
* Change framework.Backend Setup signature
* Add Setup func to logical.Backend interface
* Move OptionallyEnableMlock call into plugin.Serve, update docs and comments
* Remove commented var in plugin package
* RegisterLicense on logical.Backend interface (#3017)
* Add RegisterLicense to logical.Backend interface
* Update RegisterLicense to use callback func on framework.Backend
* Refactor framework.Backend.RegisterLicense
* plugin: Prevent plugin.SystemViewClient.ResponseWrapData from getting JWTs
* plugin: Revert BackendType to remove TypePassthrough and related references
* Fix typo in plugin backends docs
2017-07-20 17:28:40 +00:00
|
|
|
TLSProviderFunc: tlsProviderFunc,
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|
2018-04-20 18:19:04 +00:00
|
|
|
|
|
|
|
func TestSystemBackend_InternalUIResultantACL(t *testing.T) {
|
|
|
|
cluster := vault.NewTestCluster(t, nil, &vault.TestClusterOptions{
|
|
|
|
HandlerFunc: vaulthttp.Handler,
|
|
|
|
})
|
|
|
|
cluster.Start()
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
client := cluster.Cores[0].Client
|
|
|
|
|
|
|
|
resp, err := client.Auth().Token().Create(&api.TokenCreateRequest{
|
|
|
|
Policies: []string{"default"},
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
if resp == nil {
|
|
|
|
t.Fatal("nil response")
|
|
|
|
}
|
|
|
|
if resp.Auth == nil {
|
|
|
|
t.Fatal("nil auth")
|
|
|
|
}
|
|
|
|
if resp.Auth.ClientToken == "" {
|
|
|
|
t.Fatal("empty client token")
|
|
|
|
}
|
|
|
|
|
|
|
|
client.SetToken(resp.Auth.ClientToken)
|
|
|
|
|
|
|
|
resp, err = client.Logical().Read("sys/internal/ui/resultant-acl")
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
if resp == nil {
|
|
|
|
t.Fatal("nil response")
|
|
|
|
}
|
|
|
|
if resp.Data == nil {
|
|
|
|
t.Fatal("nil data")
|
|
|
|
}
|
|
|
|
|
|
|
|
exp := map[string]interface{}{
|
|
|
|
"exact_paths": map[string]interface{}{
|
|
|
|
"auth/token/lookup-self": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"read",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"auth/token/renew-self": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"auth/token/revoke-self": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"sys/capabilities-self": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
2018-07-12 14:18:50 +00:00
|
|
|
"sys/control-group/request": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
2018-04-20 18:19:04 +00:00
|
|
|
"sys/internal/ui/resultant-acl": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"read",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"sys/leases/lookup": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"sys/leases/renew": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"sys/renew": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"sys/tools/hash": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"sys/wrapping/lookup": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"sys/wrapping/unwrap": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"sys/wrapping/wrap": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"glob_paths": map[string]interface{}{
|
|
|
|
"cubbyhole/": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"create",
|
|
|
|
"delete",
|
|
|
|
"list",
|
|
|
|
"read",
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"sys/tools/hash/": map[string]interface{}{
|
|
|
|
"capabilities": []interface{}{
|
|
|
|
"update",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
"root": false,
|
|
|
|
}
|
|
|
|
|
|
|
|
if diff := deep.Equal(resp.Data, exp); diff != nil {
|
|
|
|
t.Fatal(diff)
|
|
|
|
}
|
|
|
|
}
|
2021-11-30 19:49:58 +00:00
|
|
|
|
|
|
|
func TestSystemBackend_HAStatus(t *testing.T) {
|
|
|
|
logger := logging.NewVaultLogger(hclog.Trace)
|
|
|
|
inm, err := inmem.NewTransactionalInmem(nil, logger)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
inmha, err := inmem.NewInmemHA(nil, logger)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
conf := &vault.CoreConfig{
|
|
|
|
Physical: inm,
|
|
|
|
HAPhysical: inmha.(physical.HABackend),
|
|
|
|
}
|
|
|
|
opts := &vault.TestClusterOptions{
|
|
|
|
HandlerFunc: vaulthttp.Handler,
|
|
|
|
}
|
|
|
|
cluster := vault.NewTestCluster(t, conf, opts)
|
|
|
|
cluster.Start()
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
|
|
|
|
vault.RetryUntil(t, 15*time.Second, func() error {
|
|
|
|
// Use standby deliberately to make sure it forwards
|
|
|
|
client := cluster.Cores[1].Client
|
|
|
|
resp, err := client.Sys().HAStatus()
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(resp.Nodes) != len(cluster.Cores) {
|
|
|
|
return fmt.Errorf("expected %d nodes, got %d", len(cluster.Cores), len(resp.Nodes))
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
}
|
2022-02-14 20:26:57 +00:00
|
|
|
|
|
|
|
// TestSystemBackend_VersionHistory_unauthenticated tests the sys/version-history
|
|
|
|
// endpoint without providing a token. Requests to the endpoint must be
|
|
|
|
// authenticated and thus a 403 response is expected.
|
|
|
|
func TestSystemBackend_VersionHistory_unauthenticated(t *testing.T) {
|
|
|
|
cluster := vault.NewTestCluster(t, nil, &vault.TestClusterOptions{
|
|
|
|
HandlerFunc: vaulthttp.Handler,
|
|
|
|
})
|
|
|
|
cluster.Start()
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
client := cluster.Cores[0].Client
|
|
|
|
|
|
|
|
client.SetToken("")
|
|
|
|
resp, err := client.Logical().List("sys/version-history")
|
|
|
|
|
|
|
|
if resp != nil {
|
|
|
|
t.Fatalf("expected nil response, resp: %#v", resp)
|
|
|
|
}
|
|
|
|
|
|
|
|
respErr, ok := err.(*api.ResponseError)
|
|
|
|
if !ok {
|
|
|
|
t.Fatalf("unexpected error type: err: %#v", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if respErr.StatusCode != 403 {
|
|
|
|
t.Fatalf("expected response status to be 403, actual: %d", respErr.StatusCode)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// TestSystemBackend_VersionHistory_authenticated tests the sys/version-history
|
|
|
|
// endpoint with authentication. Without synthetically altering the underlying
|
|
|
|
// core/versions storage entries, a single version entry should exist.
|
|
|
|
func TestSystemBackend_VersionHistory_authenticated(t *testing.T) {
|
|
|
|
cluster := vault.NewTestCluster(t, nil, &vault.TestClusterOptions{
|
|
|
|
HandlerFunc: vaulthttp.Handler,
|
|
|
|
})
|
|
|
|
cluster.Start()
|
|
|
|
defer cluster.Cleanup()
|
|
|
|
client := cluster.Cores[0].Client
|
|
|
|
|
|
|
|
resp, err := client.Logical().List("sys/version-history")
|
|
|
|
if err != nil || resp == nil {
|
|
|
|
t.Fatalf("request failed, err: %v, resp: %#v", err, resp)
|
|
|
|
}
|
|
|
|
|
|
|
|
var ok bool
|
|
|
|
var keys []interface{}
|
|
|
|
var keyInfo map[string]interface{}
|
|
|
|
|
|
|
|
if keys, ok = resp.Data["keys"].([]interface{}); !ok {
|
|
|
|
t.Fatalf("expected keys to be array, actual: %#v", resp.Data["keys"])
|
|
|
|
}
|
|
|
|
|
|
|
|
if keyInfo, ok = resp.Data["key_info"].(map[string]interface{}); !ok {
|
|
|
|
t.Fatalf("expected key_info to be map, actual: %#v", resp.Data["key_info"])
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(keys) != 1 {
|
|
|
|
t.Fatalf("expected single version history entry for %q", version.Version)
|
|
|
|
}
|
|
|
|
|
|
|
|
if keyInfo[version.Version] == nil {
|
|
|
|
t.Fatalf("expected version %s to be present in key_info, actual: %#v", version.Version, keyInfo)
|
|
|
|
}
|
2022-02-14 23:06:02 +00:00
|
|
|
}
|