Ember-cli upgrade from ~3.8 to ~3.20 (#9972)
* Update ember-cli to ~3.20
* Remove bad optional-feature
* Remove ember-fetch dep
* re-install ember-fetch
* update model fragments pr
* update ember model fragments correct package name
* update ember composable helpers to solve array helper error
* update ember-concurrency
* add back engine dependencies, automatically removed during ember-cli-upgrade
* make author-form-options component js file otherwise error
* for now comment out withTestWaiter
* add eslint-node and fix if not with unless in templates
* fix linting for tab index of false is now -1 and add type button to all buttons without types
* fix href errors for linting, likely have to come back and fix
* using eslint fix flag to fix all this.gets
* ember modules codemode removed files that had module twice, will fix in next commit
* finish codemode ember-data-codemod needed to rename const model
* more this.get removal codemode did not work
* cont. removal of this.get
* stop mixin rules until figure out how to reconfig them all
* smaller eslint ignores
* get codemode
* testing app small fixes to bring it back after all the changes
* small changes to eslint
* test removal of getProperties
* fix issue with baseKey because value could be unknown needed to add a question mark in nested get
* smaller linting fixes
* get nested fixes
* small linting error fixes
* small linting changes
* working through more small linting changes
* another round of linting modifications
* liniting fixes
* ember module codemod
* quinit dom codemod
* angle bracket codemod
* discovered that components must have js files
* ran all codemods this is all that's left
* small changes to fix get needs two object, should not have been using get.
* fix issue with one input in form field
* fun times with set and onChange from oninput
* fix issue with model not being passed through on secret-edit-display
* fix issue with yarn run test not working, revert without npm run all
* linting and small fix when loading without a selectAuthBackend
* fix failing test with ui-wizard issue
* fix test failure due to model not being asked for correctly with new changes, probably run into this more.
* fix issue with component helper and at props specific to wizard
* rename log to clilog due to conflict with new eslint rule
* small changes for test failures
* component helper at fixes
* Revert to old component style something with new one broke this and can't figure it out for now
* small fishy smelling test fixes will revisit
* small test changes
* more small test changes, appears upgrade treats spaces differently
* comment out code and test that no longer seems relevant but confirm
* clean run on component test though still some potential timing issues on ui-console test
* fixing one auth test issue and timing issue on enable-test
* small mods
* fix this conditional check from upgrade
* linting fixes after master merge
* package updates using yarn upgrade-interactive
* update libraries that did not effect any of the test failures.
* update ember truth helpers library
* settling tests
* Fix ui-panel control group output
* fix features selection test failures
* Fix auth tests (x-vault-token)
* fix shared test
* fix issue with data null on backend
* Revert "Fix auth tests (x-vault-token)"
This reverts commit 89cb174b2f1998efa56d9604d14131415ae65d6f.
* Fix auth tests (x-vault-token) without updating this.set
* Update redirect-to tests
* fix wrapped token test
* skip some flaky test
* fix issue with href and a tags vs buttons
* fix linting
* updates to get tests running (#10409)
* yarn isntall
* increasing resource_class
* whoops
* trying large
* back to xlarge
* Fix param issue on transform item routes
* test fixes
* settle on policies (old) test
* fix browserstack test warning and skips of test confirmed worked
* Fix redirect-to test
* skips
* fix transformation test and skip some kmip
* Skip tests
* Add meep marker to remaining failing tests
* Skip test with failing component
* rever skip on secret-create test
* Skip piece of test that fails due to navigation-input
* fix settings test where can and skip in others after confirming
* fix circle ci test failures
* ssh role settle
* Fix navigate-input and add settled to test
* Remove extra import
* secret cubbyhole and alicloud
* Add settled to gcpkms test
* settles on redirect to test
* Bump browserstack test resource to large
* Update browserstack resource size to xlarge
* update todos
* add back in withTestWaiter
* try and fix credentials conditional action added comment instead
* Update volatile computed properies to get functions
* this step was never reached and we never defined secretType anywhere so I removed
* add settled to policy old test
* Fix navigate-input on policies and leases
* replace ssh test with no var hoping that helps and add settled to other failing tests, unskip console tests
* kmip, transit, role test remove a skip and add in settled
* fix hover copy button, had to remove some testing functionality
* Remove private router service
* remove skip on control ssh and ui panel, fix search select by restructuring how to read the error
* final bit of working through skipped test
* Replace clearNonGlobalModels by linking directly to namespace with href-to
* Remove unused var
* Fix role-ssh id bug by updating form-field-from-model to form-field-group-loop
* Fix transit create id would not update
* Update option toggle selector for ssh-role
* Fix ssh selector
* cleanup pt1
* small clean up
* cleanup part2
* Fix computed on pricing-metrics-form
* small cleanup based on chelseas comments.
Co-authored-by: Chelsea Shaw <chelshaw.dev@gmail.com>
Co-authored-by: Sarah Thompson <sthompson@hashicorp.com>
2020-12-03 23:00:22 +00:00
|
|
|
## Module Report
|
|
|
|
### Unknown Global
|
|
|
|
|
2021-12-17 03:44:29 +00:00
|
|
|
**Global**: `Ember.testing`
|
|
|
|
|
|
|
|
**Location**: `app/components/auth-jwt.js` at line 9
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
|
|
|
/* eslint-disable ember/no-ember-testing-in-module-scope */
|
|
|
|
const WAIT_TIME = Ember.testing ? 0 : 500;
|
|
|
|
const ERROR_WINDOW_CLOSED =
|
|
|
|
'The provider window was closed before authentication was complete. Please click Sign In to try again.';
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.testing`
|
|
|
|
|
|
|
|
**Location**: `app/components/auth-form.js` at line 252
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
|
|
|
delayAuthMessageReminder: task(function*() {
|
|
|
|
if (Ember.testing) {
|
|
|
|
this.showLoading = true;
|
|
|
|
yield timeout(0);
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.testing`
|
|
|
|
|
|
|
|
**Location**: `app/routes/vault/cluster/logout.js` at line 30
|
|
|
|
|
|
|
|
```js
|
|
|
|
this.flashMessages.clearMessages();
|
|
|
|
this.permissions.reset();
|
|
|
|
if (Ember.testing) {
|
|
|
|
// Don't redirect on the test
|
|
|
|
this.replaceWith('vault.cluster.auth', { queryParams: { with: authType } });
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.testing`
|
|
|
|
|
|
|
|
**Location**: `app/components/mount-backend-form.js` at line 100
|
|
|
|
|
|
|
|
```js
|
|
|
|
capabilities = yield this.store.findRecord('capabilities', `${path}/config`);
|
|
|
|
} catch (err) {
|
|
|
|
if (Ember.testing) {
|
|
|
|
//captures mount-backend-form component test
|
|
|
|
yield mountModel.save();
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.testing`
|
|
|
|
|
|
|
|
**Location**: `app/components/oidc-consent-block.js` at line 47
|
|
|
|
|
|
|
|
```js
|
|
|
|
let { redirect, ...params } = this.args;
|
|
|
|
let redirectUrl = this.buildUrl(redirect, params);
|
|
|
|
if (Ember.testing) {
|
|
|
|
this.args.testRedirect(redirectUrl.toString());
|
|
|
|
} else {
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.testing`
|
|
|
|
|
|
|
|
**Location**: `lib/core/addon/components/ttl-form.js` at line 82
|
|
|
|
|
|
|
|
```js
|
|
|
|
this.set('time', parsedTime);
|
|
|
|
this.handleChange();
|
|
|
|
if (Ember.testing) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
Ember-cli upgrade from ~3.8 to ~3.20 (#9972)
* Update ember-cli to ~3.20
* Remove bad optional-feature
* Remove ember-fetch dep
* re-install ember-fetch
* update model fragments pr
* update ember model fragments correct package name
* update ember composable helpers to solve array helper error
* update ember-concurrency
* add back engine dependencies, automatically removed during ember-cli-upgrade
* make author-form-options component js file otherwise error
* for now comment out withTestWaiter
* add eslint-node and fix if not with unless in templates
* fix linting for tab index of false is now -1 and add type button to all buttons without types
* fix href errors for linting, likely have to come back and fix
* using eslint fix flag to fix all this.gets
* ember modules codemode removed files that had module twice, will fix in next commit
* finish codemode ember-data-codemod needed to rename const model
* more this.get removal codemode did not work
* cont. removal of this.get
* stop mixin rules until figure out how to reconfig them all
* smaller eslint ignores
* get codemode
* testing app small fixes to bring it back after all the changes
* small changes to eslint
* test removal of getProperties
* fix issue with baseKey because value could be unknown needed to add a question mark in nested get
* smaller linting fixes
* get nested fixes
* small linting error fixes
* small linting changes
* working through more small linting changes
* another round of linting modifications
* liniting fixes
* ember module codemod
* quinit dom codemod
* angle bracket codemod
* discovered that components must have js files
* ran all codemods this is all that's left
* small changes to fix get needs two object, should not have been using get.
* fix issue with one input in form field
* fun times with set and onChange from oninput
* fix issue with model not being passed through on secret-edit-display
* fix issue with yarn run test not working, revert without npm run all
* linting and small fix when loading without a selectAuthBackend
* fix failing test with ui-wizard issue
* fix test failure due to model not being asked for correctly with new changes, probably run into this more.
* fix issue with component helper and at props specific to wizard
* rename log to clilog due to conflict with new eslint rule
* small changes for test failures
* component helper at fixes
* Revert to old component style something with new one broke this and can't figure it out for now
* small fishy smelling test fixes will revisit
* small test changes
* more small test changes, appears upgrade treats spaces differently
* comment out code and test that no longer seems relevant but confirm
* clean run on component test though still some potential timing issues on ui-console test
* fixing one auth test issue and timing issue on enable-test
* small mods
* fix this conditional check from upgrade
* linting fixes after master merge
* package updates using yarn upgrade-interactive
* update libraries that did not effect any of the test failures.
* update ember truth helpers library
* settling tests
* Fix ui-panel control group output
* fix features selection test failures
* Fix auth tests (x-vault-token)
* fix shared test
* fix issue with data null on backend
* Revert "Fix auth tests (x-vault-token)"
This reverts commit 89cb174b2f1998efa56d9604d14131415ae65d6f.
* Fix auth tests (x-vault-token) without updating this.set
* Update redirect-to tests
* fix wrapped token test
* skip some flaky test
* fix issue with href and a tags vs buttons
* fix linting
* updates to get tests running (#10409)
* yarn isntall
* increasing resource_class
* whoops
* trying large
* back to xlarge
* Fix param issue on transform item routes
* test fixes
* settle on policies (old) test
* fix browserstack test warning and skips of test confirmed worked
* Fix redirect-to test
* skips
* fix transformation test and skip some kmip
* Skip tests
* Add meep marker to remaining failing tests
* Skip test with failing component
* rever skip on secret-create test
* Skip piece of test that fails due to navigation-input
* fix settings test where can and skip in others after confirming
* fix circle ci test failures
* ssh role settle
* Fix navigate-input and add settled to test
* Remove extra import
* secret cubbyhole and alicloud
* Add settled to gcpkms test
* settles on redirect to test
* Bump browserstack test resource to large
* Update browserstack resource size to xlarge
* update todos
* add back in withTestWaiter
* try and fix credentials conditional action added comment instead
* Update volatile computed properies to get functions
* this step was never reached and we never defined secretType anywhere so I removed
* add settled to policy old test
* Fix navigate-input on policies and leases
* replace ssh test with no var hoping that helps and add settled to other failing tests, unskip console tests
* kmip, transit, role test remove a skip and add in settled
* fix hover copy button, had to remove some testing functionality
* Remove private router service
* remove skip on control ssh and ui panel, fix search select by restructuring how to read the error
* final bit of working through skipped test
* Replace clearNonGlobalModels by linking directly to namespace with href-to
* Remove unused var
* Fix role-ssh id bug by updating form-field-from-model to form-field-group-loop
* Fix transit create id would not update
* Update option toggle selector for ssh-role
* Fix ssh selector
* cleanup pt1
* small clean up
* cleanup part2
* Fix computed on pricing-metrics-form
* small cleanup based on chelseas comments.
Co-authored-by: Chelsea Shaw <chelshaw.dev@gmail.com>
Co-authored-by: Sarah Thompson <sthompson@hashicorp.com>
2020-12-03 23:00:22 +00:00
|
|
|
**Global**: `Ember.onerror`
|
|
|
|
|
|
|
|
**Location**: `tests/helpers/wait-for-error.js` at line 5
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
|
|
|
export default function waitForError(opts) {
|
|
|
|
const orig = Ember.onerror;
|
|
|
|
|
|
|
|
let error = null;
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.onerror`
|
|
|
|
|
|
|
|
**Location**: `tests/helpers/wait-for-error.js` at line 5
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
|
|
|
export default function waitForError(opts) {
|
|
|
|
const orig = Ember.onerror;
|
|
|
|
|
|
|
|
let error = null;
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.onerror`
|
|
|
|
|
|
|
|
**Location**: `tests/helpers/wait-for-error.js` at line 8
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
|
|
|
let error = null;
|
|
|
|
Ember.onerror = err => {
|
|
|
|
error = err;
|
|
|
|
};
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.onerror`
|
|
|
|
|
|
|
|
**Location**: `tests/helpers/wait-for-error.js` at line 13
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
|
|
|
return waitUntil(() => error, opts).finally(() => {
|
|
|
|
Ember.onerror = orig;
|
|
|
|
});
|
|
|
|
}
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.Logger`
|
|
|
|
|
|
|
|
**Location**: `tests/acceptance/not-found-test.js` at line 15
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
|
|
|
hooks.beforeEach(function() {
|
|
|
|
loggerError = Ember.Logger.error;
|
|
|
|
adapterException = Ember.Test.adapter.exception;
|
|
|
|
Ember.Test.adapter.exception = () => {};
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.Test`
|
|
|
|
|
|
|
|
**Location**: `tests/acceptance/not-found-test.js` at line 16
|
|
|
|
|
|
|
|
```js
|
|
|
|
hooks.beforeEach(function() {
|
|
|
|
loggerError = Ember.Logger.error;
|
|
|
|
adapterException = Ember.Test.adapter.exception;
|
|
|
|
Ember.Test.adapter.exception = () => {};
|
|
|
|
Ember.Logger.error = () => {};
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.Test`
|
|
|
|
|
|
|
|
**Location**: `tests/acceptance/not-found-test.js` at line 17
|
|
|
|
|
|
|
|
```js
|
|
|
|
loggerError = Ember.Logger.error;
|
|
|
|
adapterException = Ember.Test.adapter.exception;
|
|
|
|
Ember.Test.adapter.exception = () => {};
|
|
|
|
Ember.Logger.error = () => {};
|
|
|
|
return authPage.login();
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.Logger`
|
|
|
|
|
|
|
|
**Location**: `tests/acceptance/not-found-test.js` at line 18
|
|
|
|
|
|
|
|
```js
|
|
|
|
adapterException = Ember.Test.adapter.exception;
|
|
|
|
Ember.Test.adapter.exception = () => {};
|
|
|
|
Ember.Logger.error = () => {};
|
|
|
|
return authPage.login();
|
|
|
|
});
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.Test`
|
|
|
|
|
|
|
|
**Location**: `tests/acceptance/not-found-test.js` at line 23
|
|
|
|
|
|
|
|
```js
|
|
|
|
|
|
|
|
hooks.afterEach(function() {
|
|
|
|
Ember.Test.adapter.exception = adapterException;
|
|
|
|
Ember.Logger.error = loggerError;
|
|
|
|
return logout.visit();
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.Logger`
|
|
|
|
|
|
|
|
**Location**: `tests/acceptance/not-found-test.js` at line 24
|
|
|
|
|
|
|
|
```js
|
|
|
|
hooks.afterEach(function() {
|
|
|
|
Ember.Test.adapter.exception = adapterException;
|
|
|
|
Ember.Logger.error = loggerError;
|
|
|
|
return logout.visit();
|
|
|
|
});
|
|
|
|
```
|
2021-04-26 16:23:57 +00:00
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.testing`
|
|
|
|
|
|
|
|
**Location**: `app/routes/vault.js` at line 7
|
|
|
|
|
|
|
|
```js
|
|
|
|
import Ember from 'ember';
|
|
|
|
/* eslint-disable ember/no-ember-testing-in-module-scope */
|
|
|
|
const SPLASH_DELAY = Ember.testing ? 0 : 300;
|
|
|
|
|
|
|
|
export default Route.extend({
|
|
|
|
```
|
|
|
|
|
|
|
|
### Unknown Global
|
|
|
|
|
|
|
|
**Global**: `Ember.testing`
|
|
|
|
|
2021-12-17 03:44:29 +00:00
|
|
|
**Location**: `app/services/auth.js` at line 268
|
2021-04-26 16:23:57 +00:00
|
|
|
|
|
|
|
```js
|
|
|
|
checkShouldRenew: task(function*() {
|
|
|
|
while (true) {
|
|
|
|
if (Ember.testing) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
```
|