2019-12-11 19:18:37 +00:00
# Contributing to ORY Dockertest
2018-07-11 21:49:13 +00:00
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE - RUN doctoc TO UPDATE -->
**Table of Contents**
- [Introduction ](#introduction )
- [Contributing Code ](#contributing-code )
- [Disclosing vulnerabilities ](#disclosing-vulnerabilities )
- [Code Style ](#code-style )
- [Pull request procedure ](#pull-request-procedure )
2019-12-11 19:18:37 +00:00
- [Communication ](#communication )
2018-07-11 21:49:13 +00:00
- [Conduct ](#conduct )
<!-- END doctoc generated TOC please keep comment here to allow auto update -->
## Introduction
2019-12-11 19:18:37 +00:00
Please note: We take ORY Dockertest's security and our users' trust very seriously. If you believe you have found a
security issue in ORY Dockertest, please responsibly disclose by contacting us at hi@ory.sh.
2018-07-11 21:49:13 +00:00
2019-12-11 19:18:37 +00:00
First: if you're unsure or afraid of anything, just ask or submit the issue or pull request anyways. You won't be
yelled at for giving it your best effort. The worst that can happen is that you'll be politely asked to change
something. We appreciate any sort of contributions, and don't want a wall of rules to get in the way of that.
2018-07-11 21:49:13 +00:00
2019-12-11 19:18:37 +00:00
That said, if you want to ensure that a pull request is likely to be merged, talk to us! You can find out our thoughts
and ensure that your contribution won't clash or be obviated by ORY Dockertest's normal direction. A great way to do this is via
the [ORY Community ](https://community.ory.sh/ ) or join the [ORY Chat ](https://www.ory.sh/chat ).
2018-07-11 21:49:13 +00:00
## Contributing Code
2019-12-11 19:18:37 +00:00
Unless you are fixing a known bug, we **strongly** recommend discussing it with the core team via a GitHub issue or
[in our chat ](https://www.ory.sh/chat ) before getting started to ensure your work is consistent with
ORY Dockertest's roadmap and architecture.
2018-07-11 21:49:13 +00:00
2019-12-11 19:18:37 +00:00
All contributions are made via pull request. Note that **all patches from all contributors get reviewed** . After a pull
request is made other contributors will offer feedback, and if the patch passes review a maintainer will accept it with
a comment. When pull requests fail testing, authors are expected to update their pull requests to address the failures
until the tests pass and the pull request merges successfully.
2018-07-11 21:49:13 +00:00
At least one review from a maintainer is required for all patches (even patches from maintainers).
2019-12-11 19:18:37 +00:00
Reviewers should leave a "LGTM" comment once they are satisfied with the patch. If the patch was submitted by a
maintainer with write access, the pull request should be merged by the submitter after review.
2018-07-11 21:49:13 +00:00
## Disclosing vulnerabilities
Please disclose vulnerabilities exclusively to [hi@ory.am ](mailto:hi@ory.am ). Do not use GitHub issues.
## Code Style
Please follow these guidelines when formatting source code:
* Go code should match the output of `gofmt -s`
## Pull request procedure
2019-12-11 19:18:37 +00:00
To make a pull request, you will need a GitHub account; if you are unclear on this process, see GitHub's
documentation on [forking ](https://help.github.com/articles/fork-a-repo ) and [pull requests ](https://help.github.com/articles/using-pull-requests ).
Pull requests should be targeted at the `master` branch. Before creating a pull request, go through this checklist:
2018-07-11 21:49:13 +00:00
1. Create a feature branch off of `master` so that changes do not get mixed up.
1. [Rebase ](http://git-scm.com/book/en/Git-Branching-Rebasing ) your local changes against the `master` branch.
1. Run the full project test suite with the `go test ./...` (or equivalent) command and confirm that it passes.
1. Run `gofmt -s` (if the project is written in Go).
1. Ensure that each commit has a subsystem prefix (ex: `controller: ` ).
Pull requests will be treated as "review requests," and maintainers will give feedback on the style and substance of the patch.
2019-12-11 19:18:37 +00:00
Normally, all pull requests must include tests that test your change. Occasionally, a change will
be very difficult to test for. In those cases, please include a note in your commit message explaining why.
## Communication
We use [discord ](https://www.ory.sh/chat ). You are welcome to drop in and ask questions, discuss bugs, etc.
2018-07-11 21:49:13 +00:00
## Conduct
2019-12-11 19:18:37 +00:00
Whether you are a regular contributor or a newcomer, we care about making this community a safe place for you and
we've got your back.
2018-07-11 21:49:13 +00:00
2019-12-11 19:18:37 +00:00
* We are committed to providing a friendly, safe and welcoming environment for all, regardless of gender,
sexual orientation, disability, ethnicity, religion, or similar personal characteristic.
2018-07-11 21:49:13 +00:00
* Please avoid using nicknames that might detract from a friendly, safe and welcoming environment for all.
* Be kind and courteous. There is no need to be mean or rude.
2019-12-11 19:18:37 +00:00
* We will exclude you from interaction if you insult, demean or harass anyone. In particular, we do not tolerate
behavior that excludes people in socially marginalized groups.
* Private harassment is also unacceptable. No matter who you are, if you feel you have been or are being harassed or
made uncomfortable by a community member, please contact one of the channel ops or a member of the ORY
Dockertest core team immediately.
2018-07-11 21:49:13 +00:00
* Likewise any spamming, trolling, flaming, baiting or other attention-stealing behaviour is not welcome.
2019-12-11 19:18:37 +00:00
We welcome discussion about creating a welcoming, safe, and productive environment for the community. If you have any questions, feedback, or concerns [please let us know ](https://www.ory.sh/chat ).