128 lines
2.8 KiB
Go
128 lines
2.8 KiB
Go
package nomad
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/helper/testlog"
|
|
"github.com/hashicorp/nomad/nomad/mock"
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func Test_isSidecarForService(t *testing.T) {
|
|
cases := []struct {
|
|
t *structs.Task // task
|
|
s string // service
|
|
r bool // result
|
|
}{
|
|
{
|
|
&structs.Task{},
|
|
"api",
|
|
false,
|
|
},
|
|
{
|
|
&structs.Task{
|
|
Kind: "connect-proxy:api",
|
|
},
|
|
"api",
|
|
true,
|
|
},
|
|
{
|
|
&structs.Task{
|
|
Kind: "connect-proxy:api",
|
|
},
|
|
"db",
|
|
false,
|
|
},
|
|
{
|
|
&structs.Task{
|
|
Kind: "api",
|
|
},
|
|
"api",
|
|
false,
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
require.Equal(t, c.r, isSidecarForService(c.t, c.s))
|
|
}
|
|
}
|
|
|
|
func Test_groupConnectHook(t *testing.T) {
|
|
// Test that connect-proxy task is inserted for backend service
|
|
job := mock.Job()
|
|
job.TaskGroups[0] = &structs.TaskGroup{
|
|
Networks: structs.Networks{
|
|
{
|
|
Mode: "bridge",
|
|
},
|
|
},
|
|
Services: []*structs.Service{
|
|
{
|
|
Name: "backend",
|
|
PortLabel: "8080",
|
|
Connect: &structs.ConsulConnect{
|
|
SidecarService: &structs.ConsulSidecarService{},
|
|
},
|
|
},
|
|
{
|
|
Name: "admin",
|
|
PortLabel: "9090",
|
|
Connect: &structs.ConsulConnect{
|
|
SidecarService: &structs.ConsulSidecarService{},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
// Expected tasks
|
|
tgOut := job.TaskGroups[0].Copy()
|
|
tgOut.Tasks = []*structs.Task{
|
|
newConnectTask(tgOut.Services[0].Name),
|
|
newConnectTask(tgOut.Services[1].Name),
|
|
}
|
|
|
|
// Expect sidecar tasks to be properly canonicalized
|
|
tgOut.Tasks[0].Canonicalize(job, tgOut)
|
|
tgOut.Tasks[1].Canonicalize(job, tgOut)
|
|
tgOut.Networks[0].DynamicPorts = []structs.Port{
|
|
{
|
|
Label: fmt.Sprintf("%s-%s", structs.ConnectProxyPrefix, "backend"),
|
|
To: -1,
|
|
},
|
|
{
|
|
Label: fmt.Sprintf("%s-%s", structs.ConnectProxyPrefix, "admin"),
|
|
To: -1,
|
|
},
|
|
}
|
|
|
|
require.NoError(t, groupConnectHook(job, job.TaskGroups[0]))
|
|
require.Exactly(t, tgOut, job.TaskGroups[0])
|
|
|
|
// Test that hook is idempotent
|
|
require.NoError(t, groupConnectHook(job, job.TaskGroups[0]))
|
|
require.Exactly(t, tgOut, job.TaskGroups[0])
|
|
}
|
|
|
|
// TestJobEndpoint_ConnectInterpolation asserts that when a Connect sidecar
|
|
// proxy task is being created for a group service with an interpolated name,
|
|
// the service name is interpolated *before the task is created.
|
|
//
|
|
// See https://github.com/hashicorp/nomad/issues/6853
|
|
func TestJobEndpoint_ConnectInterpolation(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
server := &Server{logger: testlog.HCLogger(t)}
|
|
jobEndpoint := NewJobEndpoints(server)
|
|
|
|
j := mock.ConnectJob()
|
|
j.TaskGroups[0].Services[0].Name = "${JOB}-api"
|
|
j, warnings, err := jobEndpoint.admissionMutators(j)
|
|
require.NoError(t, err)
|
|
require.Nil(t, warnings)
|
|
|
|
require.Len(t, j.TaskGroups[0].Tasks, 2)
|
|
require.Equal(t, "connect-proxy-my-job-api", j.TaskGroups[0].Tasks[1].Name)
|
|
}
|