97d1bc735c
* test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix TestLogmon_Start_restart on Windows
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix failing TestConsul_Integration
t.TempDir fails to perform the cleanup properly because the folder is
still in use
testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
29 lines
562 B
Go
29 lines
562 B
Go
//go:build !windows
|
|
// +build !windows
|
|
|
|
package resolvconf
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
dresolvconf "github.com/docker/libnetwork/resolvconf"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func Test_copySystemDNS(t *testing.T) {
|
|
require := require.New(t)
|
|
data, err := ioutil.ReadFile(dresolvconf.Path())
|
|
require.NoError(err)
|
|
|
|
dest := filepath.Join(t.TempDir(), "resolv.conf")
|
|
|
|
require.NoError(copySystemDNS(dest))
|
|
require.FileExists(dest)
|
|
|
|
tmpResolv, err := ioutil.ReadFile(dest)
|
|
require.NoError(err)
|
|
require.Equal(data, tmpResolv)
|
|
}
|