open-nomad/client/devicemanager
Jerome Gravel-Niquet d1f1dbd203
Don't ignore nil devices in plugin fingerprint
Even if a plugin sends back an empty `[]*device.DeviceGroup`, it's transformed to `nil` during the RPC. Our custom device plugin is returning empty `FingerprintResponse.Devices` very often. Our temporary fix is to send a dummy `*DeviceGroup` if the slice is empty. This has the effect of never triggering the "first fingerprint" and therefore timing out after 50s.

In turn, this made our node exceed its hearbeat grace period when restarting it, revoking all vault tokens for its allocations, causing a restart of all our allocations because the token couldn't be renewed.

Removing the logic for `f.Devices == nil` does not appear to affect the functionality of the function.
2020-11-10 16:04:22 -05:00
..
state csi: docstring and log message fixups (#7327) 2020-03-23 13:58:30 -04:00
instance.go Don't ignore nil devices in plugin fingerprint 2020-11-10 16:04:22 -05:00
manager.go csi: docstring and log message fixups (#7327) 2020-03-23 13:58:30 -04:00
manager_test.go test: fix NewMemDB API change 2019-03-04 13:37:20 -08:00
testing.go client/pluginmanager: add plugin manager interface to device/driver managers 2018-12-18 22:56:23 -05:00
utils.go tests 2018-11-07 10:43:15 -08:00