97d1bc735c
* test: use `T.TempDir` to create temporary test directory This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `ioutil.TempDir` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * test: fix TestLogmon_Start_restart on Windows Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * test: fix failing TestConsul_Integration t.TempDir fails to perform the cleanup properly because the folder is still in use testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
139 lines
3.7 KiB
Go
139 lines
3.7 KiB
Go
package command
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/mitchellh/cli"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestInitCommand_Implements(t *testing.T) {
|
|
ci.Parallel(t)
|
|
var _ cli.Command = &JobInitCommand{}
|
|
}
|
|
|
|
func TestInitCommand_Run(t *testing.T) {
|
|
ci.Parallel(t)
|
|
ui := cli.NewMockUi()
|
|
cmd := &JobInitCommand{Meta: Meta{Ui: ui}}
|
|
|
|
// Fails on misuse
|
|
if code := cmd.Run([]string{"some", "bad", "args"}); code != 1 {
|
|
t.Fatalf("expect exit code 1, got: %d", code)
|
|
}
|
|
if out := ui.ErrorWriter.String(); !strings.Contains(out, commandErrorText(cmd)) {
|
|
t.Fatalf("expect help output, got: %s", out)
|
|
}
|
|
ui.ErrorWriter.Reset()
|
|
|
|
// Ensure we change the cwd back
|
|
origDir, err := os.Getwd()
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
defer os.Chdir(origDir)
|
|
|
|
// Create a temp dir and change into it
|
|
dir := t.TempDir()
|
|
if err := os.Chdir(dir); err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
// Works if the file doesn't exist
|
|
if code := cmd.Run([]string{}); code != 0 {
|
|
t.Fatalf("expect exit code 0, got: %d", code)
|
|
}
|
|
content, err := ioutil.ReadFile(DefaultInitName)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
defaultJob, _ := Asset("command/assets/example.nomad")
|
|
if string(content) != string(defaultJob) {
|
|
t.Fatalf("unexpected file content\n\n%s", string(content))
|
|
}
|
|
|
|
// Works with -short flag
|
|
os.Remove(DefaultInitName)
|
|
if code := cmd.Run([]string{"-short"}); code != 0 {
|
|
require.Zero(t, code, "unexpected exit code: %d", code)
|
|
}
|
|
content, err = ioutil.ReadFile(DefaultInitName)
|
|
require.NoError(t, err)
|
|
shortJob, _ := Asset("command/assets/example-short.nomad")
|
|
require.Equal(t, string(content), string(shortJob))
|
|
|
|
// Fails if the file exists
|
|
if code := cmd.Run([]string{}); code != 1 {
|
|
t.Fatalf("expect exit code 1, got: %d", code)
|
|
}
|
|
if out := ui.ErrorWriter.String(); !strings.Contains(out, "exists") {
|
|
t.Fatalf("expect file exists error, got: %s", out)
|
|
}
|
|
}
|
|
|
|
func TestInitCommand_defaultJob(t *testing.T) {
|
|
ci.Parallel(t)
|
|
// Ensure the job file is always written with spaces instead of tabs. Since
|
|
// the default job file is embedded in the go file, it's easy for tabs to
|
|
// slip in.
|
|
defaultJob, _ := Asset("command/assets/example.nomad")
|
|
if strings.Contains(string(defaultJob), "\t") {
|
|
t.Error("default job contains tab character - please convert to spaces")
|
|
}
|
|
}
|
|
|
|
func TestInitCommand_customFilename(t *testing.T) {
|
|
ci.Parallel(t)
|
|
ui := cli.NewMockUi()
|
|
cmd := &JobInitCommand{Meta: Meta{Ui: ui}}
|
|
filename := "custom.nomad"
|
|
|
|
// Ensure we change the cwd back
|
|
origDir, err := os.Getwd()
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
defer os.Chdir(origDir)
|
|
|
|
// Create a temp dir and change into it
|
|
dir := t.TempDir()
|
|
if err := os.Chdir(dir); err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
// Works if the file doesn't exist
|
|
if code := cmd.Run([]string{filename}); code != 0 {
|
|
t.Fatalf("expect exit code 0, got: %d", code)
|
|
}
|
|
content, err := ioutil.ReadFile(filename)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
defaultJob, _ := Asset("command/assets/example.nomad")
|
|
if string(content) != string(defaultJob) {
|
|
t.Fatalf("unexpected file content\n\n%s", string(content))
|
|
}
|
|
|
|
// Works with -short flag
|
|
os.Remove(filename)
|
|
if code := cmd.Run([]string{"-short", filename}); code != 0 {
|
|
require.Zero(t, code, "unexpected exit code: %d", code)
|
|
}
|
|
content, err = ioutil.ReadFile(filename)
|
|
require.NoError(t, err)
|
|
shortJob, _ := Asset("command/assets/example-short.nomad")
|
|
require.Equal(t, string(content), string(shortJob))
|
|
|
|
// Fails if the file exists
|
|
if code := cmd.Run([]string{filename}); code != 1 {
|
|
t.Fatalf("expect exit code 1, got: %d", code)
|
|
}
|
|
if out := ui.ErrorWriter.String(); !strings.Contains(out, "exists") {
|
|
t.Fatalf("expect file exists error, got: %s", out)
|
|
}
|
|
}
|