576bcf554f
I originally planned to add component documentation, but as this dragged on and I found that JSDoc-to-Markdown sometimes needed hand-tuning, I decided to skip it and focus on replicating what was already present in Freestyle. Adding documentation is a finite task that can be revisited in the future.
My goal was to migrate everything from Freestyle with as few changes as possible. Some adaptations that I found necessary:
• the DelayedArray and DelayedTruth utilities that delay component rendering until slightly after initial render because without them:
◦ charts were rendering with zero width
◦ the JSON viewer was rendering with empty content
• Storybook in Ember renders components in a routerless/controllerless context by default, so some component stories needed changes:
◦ table pagination/sorting stories access to query params, which necessitates some reaching into Ember internals to start routing and dynamically generate a Storybook route/controller to render components into
◦ some stories have a faux controller as part of their Storybook context that hosts setInterval-linked dynamic computed properties
• some jiggery-pokery with anchor tags
◦ inert href='#' had to become href='javascript:;
◦ links that are actually meant to navigate need target='_parent' so they don’t navigate inside the Storybook iframe
Maybe some of these could be addressed by fixes in ember-cli-storybook but I’m wary of digging around in there any more than I already have, as I’ve lost a lot of time to Storybook confusion and frustrations already 😞
The STORYBOOK=true environment variable tweaks some environment settings to get things working as expected in the Storybook context.
I chose to:
• use angle bracket invocation within stories rather than have to migrate them soon after having moved to Storybook
• keep Freestyle around for now for its palette and typeface components
48 lines
1.2 KiB
JavaScript
48 lines
1.2 KiB
JavaScript
import EmberRouter from '@ember/routing/router';
|
|
import config from './config/environment';
|
|
|
|
const Router = EmberRouter.extend({
|
|
location: config.locationType,
|
|
rootURL: config.rootURL,
|
|
});
|
|
|
|
Router.map(function() {
|
|
this.route('jobs', function() {
|
|
this.route('run');
|
|
this.route('job', { path: '/:job_name' }, function() {
|
|
this.route('task-group', { path: '/:name' });
|
|
this.route('definition');
|
|
this.route('versions');
|
|
this.route('deployments');
|
|
this.route('evaluations');
|
|
this.route('allocations');
|
|
});
|
|
});
|
|
|
|
this.route('clients', function() {
|
|
this.route('client', { path: '/:node_id' });
|
|
});
|
|
|
|
this.route('servers', function() {
|
|
this.route('server', { path: '/:agent_id' });
|
|
});
|
|
|
|
this.route('allocations', function() {
|
|
this.route('allocation', { path: '/:allocation_id' }, function() {
|
|
this.route('task', { path: '/:name' }, function() {
|
|
this.route('logs');
|
|
this.route('fs-root', { path: '/fs' });
|
|
this.route('fs', { path: '/fs/*path' });
|
|
});
|
|
});
|
|
});
|
|
|
|
this.route('settings', function() {
|
|
this.route('tokens');
|
|
});
|
|
|
|
this.route('not-found', { path: '/*' });
|
|
});
|
|
|
|
export default Router;
|