e096a0a5ab
* chore: upgrade forward compatible packages * chore: v3.20.2...v3.24.0 * chore: silence string prototype extension deprecation * refact: don't test clicking disabled button job-list Recent test-helper upgrades will guard against clicking disabled buttons as this is not something that real users can do. We need to change our tests accordingly. * fix: await async test helper `expectError` We have to await this async test function otherwise the test's rendering context will be torn down before we run assertions against it. * fix: don't try to click disabled two-step-button Recent test-helper updates prohibit clicking disabled buttons. We need to adapt the tests accordingly. * fix: recommendation-accordion Use up-to-date semantics for handling list-accordion closing in recommendation-accordion. * fixes toggling recommendation-accordion toggle. * fix: simple-unless linting error application.hbs There's no reason to use unless here - we can use if instead. * fix: no-quoteless-attributes recommendation accordion * fix: no-quoteless-attributes recommendation-chart * fix: allow `unless` - global-header.hbs This is a valid use of unless in our opinion. * fix: allow unless in job-diff This is not a great use for unless but we don't want to change this behavior atm. * fix: no-attrs-in-components list-pager There is no need to use this.attrs in classic components. When we will convert to glimmer we will use `@`-instead. * fix: simple-unless job/definition We can convert to a simple if here. * fix: allow inline-styles stats-box component To make linter happy. * fix: disable no-action and no-invalid-interactive Will be adressed in follow-up PRs. * chore: update ember-classic-decorator to latest * chore: upgrade ember-can to latest * chore: upgrade ember-composable-helpers to latest * chore: upgrade ember-concurrency * fix: recomputation deprecation `Trigger` schedule `do` on actions queue to work around recomputation deprecation when triggering Trigger on `did-insert`. * chore: upgrade ember-cli-string-helpers * chore: upgrade ember-copy * chore: upgrade ember-data-model-fragments * chore: upgrade ember-deprecation-workflow * chore: upgrade ember-inline-svg * chore: upgrade ember-modifier * chore: upgrade ember-truth-helpers * chore: upgrade ember-moment & ember-cli-moment-shim * chore: upgrade ember-power-select * chore: upgrade ember-responsive * chore: upgrade ember-sinon * chore: upgrade ember-cli-mirage For now we will stay on 2.2 - upgrades > 2.3 break the build. * chore: upgrade 3.24.0 to 3.28.5 * fix: add missing classic decorators on adapters * fix: missing classic decorators to serializers * fix: don't reopen Ember.Object anymore * fix: remove unused useNativeEvents ember-cli-page-objects doesn't provide this method anymore * fix: add missing attributeBindings for test-selectors ember-test-selectors doesn't provides automatic bindings for data-test-* attributes anymore. * fix: classic decorator for application serializer test * fix: remove `removeContext` from tests. It is unneeded and ember-cli-page-objects doesn't provides this method anymore. * fix: remove deprecations `run.*`-invocations * fix: `collapseWhitespace` in optimize test * fix: make sure to load async relationship before access * fix: dependent keys for relationship computeds We need to add `*.isFulfilled` as dependent keys for computeds that access async relationships. * fix: `computed.read`-invocations use `read` instead * chore: prettify templates * fix: use map instead of mapBy ember-cli-page-object Doesn't work with updated ember-cli-page-object anymore. * fix: remove remaining deprecated `run.*`-calls * chore: add more deprecations deprecation-workflow * fix: `implicit-injection`-deprecation All routes that add watchers will need to inject the store-service as the store service is internally used in watchers. * fix: more implicit injection deprecations * chore: silence implicit-injection deprecation We can tackle the deprecation when we find the time. * fix: new linting errors after upgrade * fix: remove merge conflicts prettierignore * chore: upgrade to run node 12.22 when building binaries
272 lines
7.3 KiB
JavaScript
272 lines
7.3 KiB
JavaScript
import { module, test } from 'qunit';
|
|
import { setupRenderingTest } from 'ember-qunit';
|
|
import { click, find, findAll, render } from '@ember/test-helpers';
|
|
import hbs from 'htmlbars-inline-precompile';
|
|
import moment from 'moment';
|
|
import { create, collection } from 'ember-cli-page-object';
|
|
import { startMirage } from 'nomad-ui/initializers/ember-cli-mirage';
|
|
import pageSizeSelect from 'nomad-ui/tests/acceptance/behaviors/page-size-select';
|
|
import pageSizeSelectPageObject from 'nomad-ui/tests/pages/components/page-size-select';
|
|
import {
|
|
jobURL,
|
|
stopJob,
|
|
startJob,
|
|
expectError,
|
|
expectDeleteRequest,
|
|
expectStartRequest,
|
|
} from './helpers';
|
|
import { componentA11yAudit } from 'nomad-ui/tests/helpers/a11y-audit';
|
|
|
|
// A minimum viable page object to use with the pageSizeSelect behavior
|
|
const PeriodicJobPage = create({
|
|
pageSize: 25,
|
|
jobs: collection('[data-test-job-row]'),
|
|
pageSizeSelect: pageSizeSelectPageObject(),
|
|
});
|
|
|
|
module('Integration | Component | job-page/periodic', function (hooks) {
|
|
setupRenderingTest(hooks);
|
|
|
|
hooks.beforeEach(function () {
|
|
window.localStorage.clear();
|
|
this.store = this.owner.lookup('service:store');
|
|
this.server = startMirage();
|
|
this.server.create('namespace');
|
|
});
|
|
|
|
hooks.afterEach(function () {
|
|
this.server.shutdown();
|
|
window.localStorage.clear();
|
|
});
|
|
|
|
const commonTemplate = hbs`
|
|
<JobPage::Periodic
|
|
@job={{job}}
|
|
@sortProperty={{sortProperty}}
|
|
@sortDescending={{sortDescending}}
|
|
@currentPage={{currentPage}}
|
|
/>
|
|
`;
|
|
|
|
const commonProperties = (job) => ({
|
|
job,
|
|
sortProperty: 'name',
|
|
sortDescending: true,
|
|
currentPage: 1,
|
|
});
|
|
|
|
test('Clicking Force Launch launches a new periodic child job', async function (assert) {
|
|
const childrenCount = 3;
|
|
|
|
this.server.create('job', 'periodic', {
|
|
id: 'parent',
|
|
childrenCount,
|
|
createAllocations: false,
|
|
});
|
|
|
|
await this.store.findAll('job');
|
|
|
|
const job = this.store.peekAll('job').findBy('plainId', 'parent');
|
|
|
|
this.setProperties(commonProperties(job));
|
|
await render(commonTemplate);
|
|
|
|
const currentJobCount = server.db.jobs.length;
|
|
|
|
assert.equal(
|
|
findAll('[data-test-job-row] [data-test-job-name]').length,
|
|
childrenCount,
|
|
'The new periodic job launch is in the children list'
|
|
);
|
|
|
|
await click('[data-test-force-launch]');
|
|
|
|
const expectedURL = jobURL(job, '/periodic/force');
|
|
|
|
assert.ok(
|
|
this.server.pretender.handledRequests
|
|
.filterBy('method', 'POST')
|
|
.find((req) => req.url === expectedURL),
|
|
'POST URL was correct'
|
|
);
|
|
|
|
assert.equal(
|
|
server.db.jobs.length,
|
|
currentJobCount + 1,
|
|
'POST request was made'
|
|
);
|
|
});
|
|
|
|
test('Clicking force launch without proper permissions shows an error message', async function (assert) {
|
|
this.server.pretender.post('/v1/job/:id/periodic/force', () => [
|
|
403,
|
|
{},
|
|
'',
|
|
]);
|
|
|
|
this.server.create('job', 'periodic', {
|
|
id: 'parent',
|
|
childrenCount: 1,
|
|
createAllocations: false,
|
|
status: 'running',
|
|
});
|
|
|
|
await this.store.findAll('job');
|
|
|
|
const job = this.store.peekAll('job').findBy('plainId', 'parent');
|
|
|
|
this.setProperties(commonProperties(job));
|
|
await render(commonTemplate);
|
|
|
|
assert.notOk(find('[data-test-job-error-title]'), 'No error message yet');
|
|
|
|
await click('[data-test-force-launch]');
|
|
|
|
assert.equal(
|
|
find('[data-test-job-error-title]').textContent,
|
|
'Could Not Force Launch',
|
|
'Appropriate error is shown'
|
|
);
|
|
assert.ok(
|
|
find('[data-test-job-error-body]').textContent.includes('ACL'),
|
|
'The error message mentions ACLs'
|
|
);
|
|
|
|
await click('[data-test-job-error-close]');
|
|
|
|
assert.notOk(
|
|
find('[data-test-job-error-title]'),
|
|
'Error message is dismissable'
|
|
);
|
|
});
|
|
|
|
test('Stopping a job sends a delete request for the job', async function (assert) {
|
|
assert.expect(1);
|
|
|
|
const mirageJob = this.server.create('job', 'periodic', {
|
|
childrenCount: 0,
|
|
createAllocations: false,
|
|
status: 'running',
|
|
});
|
|
|
|
let job;
|
|
await this.store.findAll('job');
|
|
|
|
job = this.store.peekAll('job').findBy('plainId', mirageJob.id);
|
|
|
|
this.setProperties(commonProperties(job));
|
|
await render(commonTemplate);
|
|
await stopJob();
|
|
|
|
expectDeleteRequest(assert, this.server, job);
|
|
});
|
|
|
|
test('Stopping a job without proper permissions shows an error message', async function (assert) {
|
|
assert.expect(4);
|
|
|
|
this.server.pretender.delete('/v1/job/:id', () => [403, {}, '']);
|
|
|
|
const mirageJob = this.server.create('job', 'periodic', {
|
|
childrenCount: 0,
|
|
createAllocations: false,
|
|
status: 'running',
|
|
});
|
|
|
|
await this.store.findAll('job');
|
|
|
|
const job = this.store.peekAll('job').findBy('plainId', mirageJob.id);
|
|
|
|
this.setProperties(commonProperties(job));
|
|
await render(commonTemplate);
|
|
|
|
await stopJob();
|
|
expectError(assert, 'Could Not Stop Job');
|
|
|
|
await componentA11yAudit(this.element, assert);
|
|
});
|
|
|
|
test('Starting a job sends a post request for the job using the current definition', async function (assert) {
|
|
assert.expect(2);
|
|
|
|
const mirageJob = this.server.create('job', 'periodic', {
|
|
childrenCount: 0,
|
|
createAllocations: false,
|
|
status: 'dead',
|
|
});
|
|
await this.store.findAll('job');
|
|
|
|
const job = this.store.peekAll('job').findBy('plainId', mirageJob.id);
|
|
|
|
this.setProperties(commonProperties(job));
|
|
await render(commonTemplate);
|
|
|
|
await startJob();
|
|
expectStartRequest(assert, this.server, job);
|
|
});
|
|
|
|
test('Starting a job without proper permissions shows an error message', async function (assert) {
|
|
assert.expect(3);
|
|
|
|
this.server.pretender.post('/v1/job/:id', () => [403, {}, '']);
|
|
|
|
const mirageJob = this.server.create('job', 'periodic', {
|
|
childrenCount: 0,
|
|
createAllocations: false,
|
|
status: 'dead',
|
|
});
|
|
await this.store.findAll('job');
|
|
|
|
const job = this.store.peekAll('job').findBy('plainId', mirageJob.id);
|
|
|
|
this.setProperties(commonProperties(job));
|
|
await render(commonTemplate);
|
|
|
|
await startJob();
|
|
|
|
await expectError(assert, 'Could Not Start Job');
|
|
});
|
|
|
|
test('Each job row includes the submitted time', async function (assert) {
|
|
this.server.create('job', 'periodic', {
|
|
id: 'parent',
|
|
childrenCount: 1,
|
|
createAllocations: false,
|
|
});
|
|
|
|
await this.store.findAll('job');
|
|
|
|
const job = this.store.peekAll('job').findBy('plainId', 'parent');
|
|
|
|
this.setProperties(commonProperties(job));
|
|
await render(commonTemplate);
|
|
|
|
assert.equal(
|
|
find('[data-test-job-submit-time]').textContent.trim(),
|
|
moment(job.get('children.firstObject.submitTime')).format(
|
|
'MMM DD HH:mm:ss ZZ'
|
|
),
|
|
'The new periodic job launch is in the children list'
|
|
);
|
|
});
|
|
|
|
pageSizeSelect({
|
|
resourceName: 'job',
|
|
pageObject: PeriodicJobPage,
|
|
pageObjectList: PeriodicJobPage.jobs,
|
|
async setup() {
|
|
this.server.create('job', 'periodic', {
|
|
id: 'parent',
|
|
childrenCount: PeriodicJobPage.pageSize,
|
|
createAllocations: false,
|
|
});
|
|
|
|
await this.store.findAll('job');
|
|
|
|
const job = this.store.peekAll('job').findBy('plainId', 'parent');
|
|
|
|
this.setProperties(commonProperties(job));
|
|
await render(commonTemplate);
|
|
},
|
|
});
|
|
});
|