open-nomad/drivers/shared
Eng Zer Jun 97d1bc735c
test: use `T.TempDir` to create temporary test directory (#12853)
* test: use `T.TempDir` to create temporary test directory

This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.

Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
	defer func() {
		if err := os.RemoveAll(dir); err != nil {
			t.Fatal(err)
		}
	}
is also tedious, but `t.TempDir` handles this for us nicely.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

* test: fix TestLogmon_Start_restart on Windows

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

* test: fix failing TestConsul_Integration

t.TempDir fails to perform the cleanup properly because the folder is
still in use

testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-05-12 11:42:40 -04:00
..
capabilities ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
eventer ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
executor test: use `T.TempDir` to create temporary test directory (#12853) 2022-05-12 11:42:40 -04:00
hostnames test: use `T.TempDir` to create temporary test directory (#12853) 2022-05-12 11:42:40 -04:00
resolvconf test: use `T.TempDir` to create temporary test directory (#12853) 2022-05-12 11:42:40 -04:00