open-nomad/scheduler
Lang Martin ac7c39d3d3
Delayed evaluations for stop_after_client_disconnect can cause unwanted extra followup evaluations around job garbage collection (#8099)
* client/heartbeatstop: reversed time condition for startup grace

* scheduler/generic_sched: use `delayInstead` to avoid a loop

Without protecting the loop that creates followUpEvals, a delayed eval
is allowed to create an immediate subsequent delayed eval. For both
`stop_after_client_disconnect` and the `reschedule` block, a delayed
eval should always produce some immediate result (running or blocked)
and then only after the outcome of that eval produce a second delayed
eval.

* scheduler/reconcile: lostLater are different than delayedReschedules

Just slightly. `lostLater` allocs should be used to create batched
evaluations, but `handleDelayedReschedules` assumes that the
allocations are in the untainted set. When it creates the in-place
updates to those allocations at the end, it causes the allocation to
be treated as running over in the planner, which causes the initial
`stop_after_client_disconnect` evaluation to be retried by the worker.
2020-06-03 09:48:38 -04:00
..
annotate.go Show canaries on plan 2017-07-07 12:03:11 -07:00
annotate_test.go Deprecate IOPS 2018-12-06 15:09:26 -08:00
context.go scheduler: fix panic when preempting and evicting 2019-12-02 20:22:22 -08:00
context_test.go scheduler: update tests with modern error helper 2019-12-02 20:25:52 -08:00
device.go Change types of weights on spread/affinity 2019-01-30 12:20:38 -08:00
device_test.go Change types of weights on spread/affinity 2019-01-30 12:20:38 -08:00
feasible.go scheduler: prevent a reported NPE for CSI (#7633) 2020-04-06 09:42:27 -04:00
feasible_test.go csi: use node MaxVolumes during scheduling (#7565) 2020-03-31 17:16:47 -04:00
generic_sched.go Delayed evaluations for stop_after_client_disconnect can cause unwanted extra followup evaluations around job garbage collection (#8099) 2020-06-03 09:48:38 -04:00
generic_sched_test.go Delayed evaluations for stop_after_client_disconnect can cause unwanted extra followup evaluations around job garbage collection (#8099) 2020-06-03 09:48:38 -04:00
preemption.go Only preempt for network when there is a network 2019-06-07 18:55:55 -04:00
preemption_test.go tests and some clean up 2020-05-01 13:13:30 -04:00
propertyset.go server 2018-09-15 16:23:13 -07:00
rank.go keep promotion score constants next to use 2020-05-27 15:13:19 -04:00
rank_test.go missed fixing one invocation 2020-05-01 13:38:46 -04:00
reconcile.go Delayed evaluations for stop_after_client_disconnect can cause unwanted extra followup evaluations around job garbage collection (#8099) 2020-06-03 09:48:38 -04:00
reconcile_test.go add default update stanza and max_parallel=0 disables deployments (#6191) 2019-09-02 10:30:09 -07:00
reconcile_util.go server: stop after client disconnect (#7939) 2020-05-13 16:39:04 -04:00
reconcile_util_test.go Fix linting 2018-03-28 12:26:28 -05:00
scheduler.go csi: use node MaxVolumes during scheduling (#7565) 2020-03-31 17:16:47 -04:00
scheduler_oss.go include pro tag in serveral oss.go files 2020-02-10 15:56:14 -05:00
select.go Implement affinity support in generic scheduler 2018-09-04 16:10:11 -05:00
select_test.go Implement affinity support in generic scheduler 2018-09-04 16:10:11 -05:00
spread.go More error->debug for logging in the bin packing iterator 2019-12-12 15:50:16 -06:00
spread_test.go Fix comment and assert score in test case 2019-05-15 12:35:57 -05:00
stack.go Open source Preemption code 2020-05-27 15:02:01 -04:00
stack_not_ent.go sync 2017-10-13 14:36:02 -07:00
stack_test.go csi: fix index maintenance for CSIVolume and CSIPlugin tables (#7049) 2020-03-23 13:58:29 -04:00
system_sched.go wip: added job.scale rpc endpoint, needs explicit test (tested via http now) 2020-03-24 13:57:09 +00:00
system_sched_test.go make diffSystemAllocsForNode aware of eligibility 2020-02-03 09:02:08 -05:00
testing.go server: stop after client disconnect (#7939) 2020-05-13 16:39:04 -04:00
util.go server: stop after client disconnect (#7939) 2020-05-13 16:39:04 -04:00
util_test.go Detect network mode change 2020-03-21 16:51:10 -04:00