c732b215f0
The `namespace` field was not included in the equality check between old and new Vault configurations, which meant that a Vault config change that only changed the namespace would not be detected as a change and the clients would not be reloaded. Also, the comparison for boolean fields such as `enabled` and `allow_unauthenticated` was on the pointer and not the value of that pointer, which results in spurious reloads in real config reload that is easily missed in typical test scenarios. Includes a minor refactor of the order of fields for `Copy` and `Merge` to match the struct fields in hopes it makes it harder to make this mistake in the future, as well as additional test coverage. |
||
|---|---|---|
| .. | ||
| artifact.go | ||
| artifact_test.go | ||
| audit.go | ||
| audit_test.go | ||
| autopilot.go | ||
| autopilot_test.go | ||
| consul.go | ||
| consul_test.go | ||
| limits.go | ||
| limits_test.go | ||
| plugins.go | ||
| plugins_test.go | ||
| README.md | ||
| sentinel.go | ||
| tls.go | ||
| tls_test.go | ||
| ui.go | ||
| ui_test.go | ||
| vault.go | ||
| vault_test.go | ||
Overview
nomad/structs/config is a package for configuration structs that are
shared among packages that needs the same struct definitions, but can't
import each other without creating a cyle. This config package must be
terminal in the import graph (or very close to terminal in the dependency
graph).