97d1bc735c
* test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix TestLogmon_Start_restart on Windows
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix failing TestConsul_Integration
t.TempDir fails to perform the cleanup properly because the folder is
still in use
testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
93 lines
2.3 KiB
Go
93 lines
2.3 KiB
Go
package command
|
|
|
|
import (
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/api"
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/hashicorp/nomad/command/agent"
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
"github.com/mitchellh/cli"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestOperatorSnapshotRestore_Works(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
tmpDir := t.TempDir()
|
|
|
|
snapshotPath := generateSnapshotFile(t, func(srv *agent.TestAgent, client *api.Client, url string) {
|
|
sampleJob := `
|
|
job "snapshot-test-job" {
|
|
type = "service"
|
|
datacenters = [ "dc1" ]
|
|
group "group1" {
|
|
count = 1
|
|
task "task1" {
|
|
driver = "exec"
|
|
resources {
|
|
cpu = 1000
|
|
memory = 512
|
|
}
|
|
}
|
|
}
|
|
|
|
}`
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &JobRunCommand{Meta: Meta{Ui: ui}}
|
|
cmd.JobGetter.testStdin = strings.NewReader(sampleJob)
|
|
|
|
code := cmd.Run([]string{"--address=" + url, "-detach", "-"})
|
|
require.Zero(t, code)
|
|
})
|
|
|
|
srv, _, url := testServer(t, false, func(c *agent.Config) {
|
|
c.DevMode = false
|
|
c.DataDir = filepath.Join(tmpDir, "server1")
|
|
|
|
c.AdvertiseAddrs.HTTP = "127.0.0.1"
|
|
c.AdvertiseAddrs.RPC = "127.0.0.1"
|
|
c.AdvertiseAddrs.Serf = "127.0.0.1"
|
|
})
|
|
|
|
defer srv.Shutdown()
|
|
|
|
// job is not found before restore
|
|
j, err := srv.Agent.Server().State().JobByID(nil, structs.DefaultNamespace, "snapshot-test-job")
|
|
require.NoError(t, err)
|
|
require.Nil(t, j)
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &OperatorSnapshotRestoreCommand{Meta: Meta{Ui: ui}}
|
|
|
|
code := cmd.Run([]string{"--address=" + url, snapshotPath})
|
|
require.Empty(t, ui.ErrorWriter.String())
|
|
require.Zero(t, code)
|
|
require.Contains(t, ui.OutputWriter.String(), "Snapshot Restored")
|
|
|
|
foundJob, err := srv.Agent.Server().State().JobByID(nil, structs.DefaultNamespace, "snapshot-test-job")
|
|
require.NoError(t, err)
|
|
require.Equal(t, "snapshot-test-job", foundJob.ID)
|
|
}
|
|
|
|
func TestOperatorSnapshotRestore_Fails(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &OperatorSnapshotRestoreCommand{Meta: Meta{Ui: ui}}
|
|
|
|
// Fails on misuse
|
|
code := cmd.Run([]string{"some", "bad", "args"})
|
|
require.Equal(t, 1, code)
|
|
require.Contains(t, ui.ErrorWriter.String(), commandErrorText(cmd))
|
|
ui.ErrorWriter.Reset()
|
|
|
|
// Fails when specified file does not exist
|
|
code = cmd.Run([]string{"/unicorns/leprechauns"})
|
|
require.Equal(t, 1, code)
|
|
require.Contains(t, ui.ErrorWriter.String(), "no such file")
|
|
}
|