f61f801e77
Upcoming work to instrument the rate of RPC requests by consumer (and eventually rate limit) requires that we thread the `RPCContext` through all RPC handlers so that we can access the underlying connection. This changeset adds the context to everywhere we intend to initially support it and intentionally excludes streaming RPCs and client RPCs. To improve the ergonomics of adding the context everywhere its needed and to clarify the requirements of dynamic vs static handlers, I've also done a good bit of refactoring here: * canonicalized the RPC handler fields so they're as close to identical as possible without introducing unused fields (i.e. I didn't add loggers if the handler doesn't use them already). * canonicalized the imports in the handler files. * added a `NewExampleEndpoint` function for each handler that ensures we're constructing the handlers with the required arguments. * reordered the registration in server.go to match the order of the files (to make it easier to see if we've missed one), and added a bunch of commentary there as to what the difference between static and dynamic handlers is.
19 lines
479 B
Go
19 lines
479 B
Go
//go:build !ent
|
|
// +build !ent
|
|
|
|
package nomad
|
|
|
|
import "net/rpc"
|
|
|
|
// EnterpriseEndpoints holds the set of enterprise only endpoints to register
|
|
type EnterpriseEndpoints struct{}
|
|
|
|
// NewEnterpriseEndpoints returns a stub of the enterprise endpoints since there
|
|
// are none in oss
|
|
func NewEnterpriseEndpoints(s *Server, ctx *RPCContext) *EnterpriseEndpoints {
|
|
return &EnterpriseEndpoints{}
|
|
}
|
|
|
|
// Register is a no-op in oss.
|
|
func (e *EnterpriseEndpoints) Register(s *rpc.Server) {}
|