97d1bc735c
* test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix TestLogmon_Start_restart on Windows
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix failing TestConsul_Integration
t.TempDir fails to perform the cleanup properly because the folder is
still in use
testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
110 lines
3.1 KiB
Go
110 lines
3.1 KiB
Go
//go:build linux
|
|
|
|
package docker
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/hashicorp/nomad/client/testutil"
|
|
"github.com/hashicorp/nomad/helper"
|
|
"github.com/hashicorp/nomad/helper/freeport"
|
|
tu "github.com/hashicorp/nomad/testutil"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestDockerDriver_authFromHelper(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
dir := t.TempDir()
|
|
helperPayload := "{\"Username\":\"hashi\",\"Secret\":\"nomad\"}"
|
|
helperContent := []byte(fmt.Sprintf("#!/bin/sh\ncat > %s/helper-$1.out;echo '%s'", dir, helperPayload))
|
|
|
|
helperFile := filepath.Join(dir, "docker-credential-testnomad")
|
|
err := ioutil.WriteFile(helperFile, helperContent, 0777)
|
|
require.NoError(t, err)
|
|
|
|
path := os.Getenv("PATH")
|
|
os.Setenv("PATH", fmt.Sprintf("%s:%s", path, dir))
|
|
defer os.Setenv("PATH", path)
|
|
|
|
helper := authFromHelper("testnomad")
|
|
creds, err := helper("registry.local:5000/repo/image")
|
|
require.NoError(t, err)
|
|
require.NotNil(t, creds)
|
|
require.Equal(t, "hashi", creds.Username)
|
|
require.Equal(t, "nomad", creds.Password)
|
|
|
|
if _, err := os.Stat(filepath.Join(dir, "helper-get.out")); os.IsNotExist(err) {
|
|
t.Fatalf("Expected helper-get.out to exist")
|
|
}
|
|
content, err := ioutil.ReadFile(filepath.Join(dir, "helper-get.out"))
|
|
require.NoError(t, err)
|
|
require.Equal(t, "registry.local:5000", string(content))
|
|
}
|
|
|
|
func TestDockerDriver_PluginConfig_PidsLimit(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
dh := dockerDriverHarness(t, nil)
|
|
driver := dh.Impl().(*Driver)
|
|
driver.config.PidsLimit = 5
|
|
|
|
task, cfg, ports := dockerTask(t)
|
|
defer freeport.Return(ports)
|
|
require.NoError(t, task.EncodeConcreteDriverConfig(cfg))
|
|
|
|
cfg.PidsLimit = 7
|
|
_, err := driver.createContainerConfig(task, cfg, "org/repo:0.1")
|
|
require.Error(t, err)
|
|
require.Contains(t, err.Error(), `pids_limit cannot be greater than nomad plugin config pids_limit`)
|
|
|
|
// Task PidsLimit should override plugin PidsLimit.
|
|
cfg.PidsLimit = 3
|
|
opts, err := driver.createContainerConfig(task, cfg, "org/repo:0.1")
|
|
require.NoError(t, err)
|
|
require.Equal(t, helper.Int64ToPtr(3), opts.HostConfig.PidsLimit)
|
|
}
|
|
|
|
func TestDockerDriver_PidsLimit(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
testutil.DockerCompatible(t)
|
|
require := require.New(t)
|
|
|
|
task, cfg, ports := dockerTask(t)
|
|
defer freeport.Return(ports)
|
|
cfg.PidsLimit = 1
|
|
cfg.Command = "/bin/sh"
|
|
cfg.Args = []string{"-c", "sleep 5 & sleep 5 & sleep 5"}
|
|
require.NoError(task.EncodeConcreteDriverConfig(cfg))
|
|
|
|
_, driver, _, cleanup := dockerSetup(t, task, nil)
|
|
defer cleanup()
|
|
|
|
driver.WaitUntilStarted(task.ID, time.Duration(tu.TestMultiplier()*5)*time.Second)
|
|
|
|
// XXX Logging doesn't work on OSX so just test on Linux
|
|
// Check that data was written to the directory.
|
|
outputFile := filepath.Join(task.TaskDir().LogDir, "redis-demo.stderr.0")
|
|
exp := "can't fork"
|
|
tu.WaitForResult(func() (bool, error) {
|
|
act, err := ioutil.ReadFile(outputFile)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
if !strings.Contains(string(act), exp) {
|
|
return false, fmt.Errorf("Expected %q in output %q", exp, string(act))
|
|
}
|
|
return true, nil
|
|
}, func(err error) {
|
|
require.NoError(err)
|
|
})
|
|
}
|