luxolus
/
open-nomad
2
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Wiki Activity
open-nomad/nomad
History
Mahmood Ali ad39bcef60 rpc: use tls wrapped connection for streaming rpc 
This ensures that server-to-server streaming RPC calls use the tls
wrapped connections.

Prior to this, `streamingRpcImpl` function uses tls for setting header
and invoking the rpc method, but returns unwrapped tls connection.
Thus, streaming writes fail with tls errors.

This tls streaming bug existed since 0.8.0[1], but PR #5654[2]
exacerbated it in 0.9.2.  Prior to PR #5654, nomad client used to
shuffle servers at every heartbeat -- `servers.Manager.setServers`[3]
always shuffled servers and was called by heartbeat code[4].  Shuffling
servers meant that a nomad client would heartbeat and establish a
connection against all nomad servers eventually.  When handling
streaming RPC calls, nomad servers used these local connection to
communicate directly to the client.  The server-to-server forwarding
logic was left mostly unexercised.

PR #5654 means that a nomad client may connect to a single server only
and caused the server-to-server forward streaming RPC code to get
exercised more and unearthed the problem.

[1] https://github.com/hashicorp/nomad/blob/v0.8.0/nomad/rpc.go#L501-L515
[2] https://github.com/hashicorp/nomad/pull/5654
[3] https://github.com/hashicorp/nomad/blob/v0.9.1/client/servers/manager.go#L198-L216
[4] https://github.com/hashicorp/nomad/blob/v0.9.1/client/client.go#L1603
 		2019-07-12 14:41:44 +08:00
..
deploymentwatcher Merge pull request #5747 from hashicorp/b-test-fixes-20190521-1 2019-06-05 19:09:18 -04:00
drainer drainer watch_nodes_test batch of 1 2019-07-10 13:56:19 -04:00
mock goimports 2019-01-22 15:44:31 -08:00
state state_store error if called without node_ids 2019-07-10 13:56:20 -04:00
structs structs drop deprecation warning, revert unnecessary comment change 2019-07-10 13:56:20 -04:00
types Change the signature of the PeriodicCallback to return an error 2016-06-10 15:54:39 -04:00
acl.go clear the token 2017-10-23 15:11:13 -07:00
acl_endpoint.go server 2018-09-15 16:23:13 -07:00
acl_endpoint_test.go non-Existent -> nonexistent 2018-03-12 11:59:33 -07:00
acl_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
alloc_endpoint.go alloc lifecycle: 404 when attempting to stop non-existent allocation 2019-06-20 21:27:22 +00:00
alloc_endpoint_test.go allocs: Add nomad alloc stop 2019-04-23 12:50:23 +02:00
autopilot.go goimports 2019-01-22 15:44:31 -08:00
autopilot_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
blocked_evals.go nomad: fix deadlock in UnblockClassAndQuota 2019-05-20 15:41:52 -07:00
blocked_evals_test.go Handle new eval being the duplicate properly 2018-11-12 16:02:23 -08:00
client_alloc_endpoint.go server: server forwarding logic for nomad exec endpoint 2019-05-09 16:49:08 -04:00
client_alloc_endpoint_test.go Run TestClientAllocations_Restart_ACL test 2019-05-17 20:30:23 -04:00
client_fs_endpoint.go server: server forwarding logic for nomad exec endpoint 2019-05-09 16:49:08 -04:00
client_fs_endpoint_test.go convert all config durations to strings in tests 2018-11-13 10:21:40 -05:00
client_rpc.go server 2018-09-15 16:23:13 -07:00
client_rpc_test.go tests: fix usages of TestClient cleanup and mock driver 2018-10-29 14:21:05 -07:00
client_stats_endpoint.go server 2018-09-15 16:23:13 -07:00
client_stats_endpoint_test.go fix tests that fail as a result of async client startup 2018-12-20 00:53:44 -05:00
config.go goimports until make check is happy 2019-01-23 06:27:14 -08:00
core_sched.go core_sched add compat comment for later removal 2019-07-10 13:56:20 -04:00
core_sched_test.go Don't GC running but desired stop allocations 2018-12-05 13:01:12 -08:00
deployment_endpoint.go server 2018-09-15 16:23:13 -07:00
deployment_endpoint_test.go Fix tests 2018-05-07 14:50:01 -05:00
deployment_watcher_shims.go Fix typos 2018-05-07 14:50:01 -05:00
drainer_int_test.go tests: fix usages of TestClient cleanup and mock driver 2018-10-29 14:21:05 -07:00
drainer_shims.go set node.StatusUpdatedAt in raft 2019-05-21 16:13:32 -04:00
endpoints_oss.go Helper to populate RPC server endpoints 2018-02-15 13:59:00 -08:00
eval_broker.go nomad: refactor waitForIndex into SnapshotAfter 2019-05-17 13:30:23 -07:00
eval_broker_test.go evalbroker: test for no enqueue on disabled 2019-05-15 11:02:21 +02:00
eval_endpoint.go Update nomad/eval_endpoint.go 2019-03-05 15:19:07 -08:00
eval_endpoint_test.go Update nomad/eval_endpoint_test.go 2019-03-05 15:19:15 -08:00
fsm.go NodeDeregisterBatch -> NodeBatchDeregister match JobBatch pattern 2019-07-10 13:56:20 -04:00
fsm_not_ent.go sync 2017-10-13 14:36:02 -07:00
fsm_registry_oss.go Sync namespace changes 2017-09-07 17:04:21 -07:00
fsm_test.go NodeDeregisterBatch -> NodeBatchDeregister match JobBatch pattern 2019-07-10 13:56:20 -04:00
heartbeat.go goimports 2019-01-22 15:44:31 -08:00
heartbeat_test.go goimports 2019-01-22 15:44:31 -08:00
job_endpoint.go Add flag similar to --all for allocs to be able to filter deployments by latest 2019-05-13 18:33:41 -05:00
job_endpoint_oss.go sync 2017-09-19 10:08:23 -05:00
job_endpoint_test.go Fix test setup to have correct jobcreateindex for deployments 2019-05-13 18:53:47 -05:00
leader.go Remove compat code associated with many previous versions of nomad 2019-06-25 19:05:25 -05:00
leader_oss.go sync acls 2017-09-13 11:38:29 -07:00
leader_test.go Set NextEval when making `failed-follow-up` evals 2019-02-20 16:07:11 -08:00
merge.go
…
node_endpoint.go node_endpoint preserve both messages as rpcs and in raft 2019-07-10 13:56:20 -04:00
node_endpoint_test.go NodeDeregisterBatch -> NodeBatchDeregister match JobBatch pattern 2019-07-10 13:56:20 -04:00
operator_endpoint.go Add code for plan normalization 2019-04-23 09:18:01 -07:00
operator_endpoint_test.go ensure tests run a 0.9 server 2019-01-29 16:19:45 -06:00
periodic.go fix more cases of logging arity errors 2019-01-09 09:22:47 -05:00
periodic_endpoint.go goimports 2019-01-22 15:44:31 -08:00
periodic_endpoint_test.go test: fix race and nil panic in nomad/ tests 2018-12-19 15:48:02 -08:00
periodic_test.go server 2018-09-15 16:23:13 -07:00
plan_apply.go Stop updating allocs.Job on stopping or preemption 2019-06-10 18:30:20 -04:00
plan_apply_not_ent.go sync 2017-10-13 14:36:02 -07:00
plan_apply_pool.go Log reason a plan gets rejected per node. 2017-07-13 17:14:02 -07:00
plan_apply_pool_test.go Enable more linters 2017-09-26 15:26:33 -07:00
plan_apply_test.go Change min version required for plan optimization 2019-04-24 12:36:07 -07:00
plan_endpoint.go goimports 2019-01-22 15:44:31 -08:00
plan_endpoint_test.go goimports 2019-01-22 15:44:31 -08:00
plan_normalization_test.go Add comments to functions, and use require instead of assert 2019-04-23 09:57:21 -07:00
plan_queue.go nomad: refactor waitForIndex into SnapshotAfter 2019-05-17 13:30:23 -07:00
plan_queue_test.go parallel nomad tests 2017-07-25 17:39:36 -07:00
raft_rpc.go Refactor 2018-02-15 13:59:00 -08:00
regions_endpoint.go server 2018-09-15 16:23:13 -07:00
regions_endpoint_test.go goimports 2019-01-22 15:44:31 -08:00
rpc.go rpc: use tls wrapped connection for streaming rpc 2019-07-12 14:41:44 +08:00
rpc_test.go rpc: use tls wrapped connection for streaming rpc 2019-07-12 14:41:44 +08:00
search_endpoint.go server 2018-09-15 16:23:13 -07:00
search_endpoint_oss.go sync 2017-10-13 14:36:02 -07:00
search_endpoint_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
serf.go do not bootstrap with non voters 2018-09-19 17:17:39 -07:00
serf_test.go backfill region from job hcl in jobUpdate and jobPlan endpoints 2019-06-13 08:03:16 -07:00
server.go Change interval of raft stats collection to 10s 2019-06-19 11:58:46 -05:00
server_setup_oss.go server 2018-09-15 16:23:13 -07:00
server_test.go backfill region from job hcl in jobUpdate and jobPlan endpoints 2019-06-13 08:03:16 -07:00
stats_fetcher.go server 2018-09-15 16:23:13 -07:00
stats_fetcher_test.go Add testing interfaces 2018-02-15 13:59:00 -08:00
status_endpoint.go server 2018-09-15 16:23:13 -07:00
status_endpoint_test.go goimports 2019-01-22 15:44:31 -08:00
system_endpoint.go server 2018-09-15 16:23:13 -07:00
system_endpoint_test.go goimports 2019-01-22 15:44:31 -08:00
testing.go goimports until make check is happy 2019-01-23 06:27:14 -08:00
timetable.go
…
timetable_test.go Include google compare library 2017-09-01 16:42:09 -07:00
util.go util simplify partitionAll 2019-07-10 13:56:19 -04:00
util_test.go util partitionAll for paging 2019-07-10 13:56:19 -04:00
vault.go nomad: refactor waitForIndex into SnapshotAfter 2019-05-17 13:30:23 -07:00
vault_test.go server vault client: use two vault clients, one with namespace, one without for /sys calls 2019-04-10 10:34:10 -05:00
vault_testing.go nomad: refactor waitForIndex into SnapshotAfter 2019-05-17 13:30:23 -07:00
worker.go nomad: emit more detailed error 2019-05-17 14:37:42 -07:00
worker_test.go nomad: emit more detailed error 2019-05-17 14:37:42 -07:00