Go to file
Derek Strickland 80b6f27efd
api: remove `mapstructure` tags from`Port` struct (#12916)
This PR solves a defect in the deserialization of api.Port structs when returning structs from theEventStream.

Previously, the api.Port struct's fields were decorated with both mapstructure and hcl tags to support the network.port stanza's use of the keyword static when posting a static port value. This works fine when posting a job and when retrieving any struct that has an embedded api.Port instance as long as the value is deserialized using JSON decoding. The EventStream, however, uses mapstructure to decode event payloads in the api package. mapstructure expects an underlying field named static which does not exist. The result was that the Port.Value field would always be set to 0.

Upon further inspection, a few things became apparent.

The struct already has hcl tags that support the indirection during job submission.
Serialization/deserialization with both the json and hcl packages produce the desired result.
The use of of the mapstructure tags provided no value as the Port struct contains only fields with primitive types.
This PR:

Removes the mapstructure tags from the api.Port structs
Updates the job parsing logic to use hcl instead of mapstructure when decoding Port instances.
Closes #11044

Co-authored-by: DerekStrickland <dstrickland@hashicorp.com>
Co-authored-by: Piotr Kazmierczak <470696+pkazmierczak@users.noreply.github.com>
2022-11-08 11:26:28 +01:00
.changelog api: remove `mapstructure` tags from`Port` struct (#12916) 2022-11-08 11:26:28 +01:00
.circleci build: update to go1.19.3 (#15099) 2022-11-01 15:54:49 -05:00
.github build: update to go1.19.3 (#15099) 2022-11-01 15:54:49 -05:00
.release Prepare for next release 2022-10-27 13:08:05 -04:00
.semgrep variables: fix filter on List RPC 2022-10-27 13:08:05 -04:00
.tours Make number of scheduler workers reloadable (#11593) 2022-01-06 11:56:13 -05:00
acl rename SecureVariables to Variables throughout 2022-08-26 16:06:24 -04:00
api api: remove `mapstructure` tags from`Port` struct (#12916) 2022-11-08 11:26:28 +01:00
ci ci: use groups of tests in gha (#15018) 2022-10-27 09:02:58 -05:00
client api: remove `mapstructure` tags from`Port` struct (#12916) 2022-11-08 11:26:28 +01:00
command api: remove `mapstructure` tags from`Port` struct (#12916) 2022-11-08 11:26:28 +01:00
contributing build: update to go1.19.3 (#15099) 2022-11-01 15:54:49 -05:00
demo demo/docs: update demo of Kadalu CSI Plugin (#13610) 2022-07-06 10:24:34 -04:00
dev docs: swap master for main in Nomad repo 2021-03-08 14:26:31 -05:00
drivers client: protect user lookups with global lock (#14742) 2022-09-29 09:30:13 -05:00
e2e api: remove `mapstructure` tags from`Port` struct (#12916) 2022-11-08 11:26:28 +01:00
helper helpers: lockfree lookup of nobody user on unix systems (#14866) 2022-10-11 08:38:05 -05:00
integrations spelling: registrations 2018-03-11 18:40:53 +00:00
internal/testing/apitests cleanup: replace TypeToPtr helper methods with pointer.Of (#14151) 2022-08-17 18:26:34 +02:00
jobspec api: remove `mapstructure` tags from`Port` struct (#12916) 2022-11-08 11:26:28 +01:00
jobspec2 template: error on missing key (#15141) 2022-11-04 13:23:01 -04:00
lib cleanup: rename Equals to Equal for consistency (#14759) 2022-10-10 09:28:46 -05:00
nomad server: add git revision to serf tags (#9159) 2022-11-07 10:34:33 -05:00
plugins cleanup more helper updates (#14638) 2022-09-21 14:53:25 -05:00
scheduler Update alloc after reconnect and enforece client heartbeat order (#15068) 2022-11-04 16:25:11 -04:00
scripts build: update to go1.19.3 (#15099) 2022-11-01 15:54:49 -05:00
terraform terraform: update installed versions of HashiCorp tools. (#13635) 2022-07-07 16:12:19 +02:00
testutil Fixing flaky TestOverlap test (#14780) 2022-10-03 14:35:02 -07:00
tools ci: use groups of tests in gha (#15018) 2022-10-27 09:02:58 -05:00
ui [ui] Remove animation from task logs sidebar (#15146) 2022-11-07 10:11:18 -05:00
version Prepare for next release 2022-10-27 13:08:05 -04:00
website Fix s3 example URLs in the artifacts docs (#15123) 2022-11-07 14:14:57 -05:00
.git-blame-ignore-revs ignore b0a20b4dc965a38b0c843f47c16685ccad7439da (#13648) 2022-07-07 15:16:18 -07:00
.gitattributes
.gitignore ci: use groups of tests in gha (#15018) 2022-10-27 09:02:58 -05:00
.go-version build: update to go1.19.3 (#15099) 2022-11-01 15:54:49 -05:00
.golangci.yml build: update linters (#15063) 2022-10-27 15:02:30 -05:00
.semgrepignore build: disable semgrep on structs.go for now 2022-02-01 10:09:49 -06:00
CHANGELOG.md Merge release 1.4.2 files 2022-10-27 13:31:29 -04:00
CODEOWNERS add service acct to codeowners for backport merging 2022-05-06 10:06:20 -07:00
GNUmakefile build: update linters (#15063) 2022-10-27 15:02:30 -05:00
LICENSE [COMPLIANCE] Update MPL 2.0 LICENSE (#14884) 2022-10-13 08:43:12 -04:00
README.md readme: remove Gitter lobby link. (#14195) 2022-08-22 10:33:20 +02:00
Vagrantfile tools: update virtualbox networking configuration (#11561) 2021-11-24 10:45:58 -05:00
build_linux_arm.go gofmt all the files 2021-10-01 10:14:28 -04:00
go.mod build(deps): bump github.com/zclconf/go-cty-yaml from 1.0.2 to 1.0.3 (#15165) 2022-11-07 06:57:23 -06:00
go.sum build(deps): bump github.com/zclconf/go-cty-yaml from 1.0.2 to 1.0.3 (#15165) 2022-11-07 06:57:23 -06:00
main.go docker_logger: reorder imports to save memory (#14875) 2022-10-11 13:23:03 -04:00
main_test.go

README.md

Nomad License: MPL 2.0 Discuss

HashiCorp Nomad logo

Nomad is a simple and flexible workload orchestrator to deploy and manage containers (docker, podman), non-containerized applications (executable, Java), and virtual machines (qemu) across on-prem and clouds at scale.

Nomad is supported on Linux, Windows, and macOS. A commercial version of Nomad, Nomad Enterprise, is also available.

Nomad provides several key features:

  • Deploy Containers and Legacy Applications: Nomads flexibility as an orchestrator enables an organization to run containers, legacy, and batch applications together on the same infrastructure. Nomad brings core orchestration benefits to legacy applications without needing to containerize via pluggable task drivers.

  • Simple & Reliable: Nomad runs as a single binary and is entirely self contained - combining resource management and scheduling into a single system. Nomad does not require any external services for storage or coordination. Nomad automatically handles application, node, and driver failures. Nomad is distributed and resilient, using leader election and state replication to provide high availability in the event of failures.

  • Device Plugins & GPU Support: Nomad offers built-in support for GPU workloads such as machine learning (ML) and artificial intelligence (AI). Nomad uses device plugins to automatically detect and utilize resources from hardware devices such as GPU, FPGAs, and TPUs.

  • Federation for Multi-Region, Multi-Cloud: Nomad was designed to support infrastructure at a global scale. Nomad supports federation out-of-the-box and can deploy applications across multiple regions and clouds.

  • Proven Scalability: Nomad is optimistically concurrent, which increases throughput and reduces latency for workloads. Nomad has been proven to scale to clusters of 10K+ nodes in real-world production environments.

  • HashiCorp Ecosystem: Nomad integrates seamlessly with Terraform, Consul, Vault for provisioning, service discovery, and secrets management.

Quick Start

Testing

See Learn: Getting Started for instructions on setting up a local Nomad cluster for non-production use.

Optionally, find Terraform manifests for bringing up a development Nomad cluster on a public cloud in the terraform directory.

Production

See Learn: Nomad Reference Architecture for recommended practices and a reference architecture for production deployments.

Documentation

Full, comprehensive documentation is available on the Nomad website: https://www.nomadproject.io/docs

Guides are available on HashiCorp Learn.

Contributing

See the contributing directory for more developer documentation.