open-nomad/client
Seth Hoenig 07543f8bdf
nsd: always set deregister flag after deregistration of group (#16289)
* services: always set deregister flag after deregistration of group

This PR fixes a bug where the group service hook's deregister flag was
not set in some cases, causing the hook to attempt deregistrations twice
during job updates (alloc replacement).

In the tests ... we used to assert on the wrong behvior (remove twice) which
has now been corrected to assert we remove only once.

This bug was "silent" in the Consul provider world because the error logs for
double deregistration only show up in Consul logs; with the Nomad provider the
error logs are in the Nomad agent logs.

* services: cleanup group service hook tests
2023-03-17 09:44:21 -05:00
..
allocdir deps: Update ioutil deprecated library references to os and io respectively in the client package (#16318) 2023-03-08 13:25:10 -06:00
allochealth allocrunner: fix health check monitoring for Consul services (#16402) 2023-03-10 14:43:31 -05:00
allocrunner nsd: always set deregister flag after deregistration of group (#16289) 2023-03-17 09:44:21 -05:00
allocwatcher deps: Update ioutil deprecated library references to os and io respectively in the client package (#16318) 2023-03-08 13:25:10 -06:00
config deps: Update ioutil deprecated library references to os and io respectively in the client package (#16318) 2023-03-08 13:25:10 -06:00
consul
devicemanager
dynamicplugins
fingerprint env/aws: update ec2 cpu info data (#16417) 2023-03-09 14:33:21 -08:00
interfaces
lib cgv1: do not disable cpuset manager if reserved interface already exists (#16467) 2023-03-13 17:00:17 -05:00
logmon deps: Update ioutil deprecated library references to os and io respectively in the client package (#16318) 2023-03-08 13:25:10 -06:00
pluginmanager
servers
serviceregistration nsd: always set deregister flag after deregistration of group (#16289) 2023-03-17 09:44:21 -05:00
state
stats
structs
taskenv allocrunner: fix health check monitoring for Consul services (#16402) 2023-03-10 14:43:31 -05:00
testutil
vaultclient
acl.go
acl_test.go
agent_endpoint.go
agent_endpoint_test.go
alloc_endpoint.go
alloc_endpoint_test.go
alloc_watcher_e2e_test.go deps: Update ioutil deprecated library references to os and io respectively in the client package (#16318) 2023-03-08 13:25:10 -06:00
client.go client: don't use `Status` RPC for Consul discovery (#16490) 2023-03-16 15:38:33 -04:00
client_stats_endpoint.go
client_stats_endpoint_test.go
client_test.go
csi_endpoint.go
csi_endpoint_test.go
driver_manager_test.go
enterprise_client_oss.go
fingerprint_manager.go
fingerprint_manager_test.go
fs_endpoint.go
fs_endpoint_test.go deps: Update ioutil deprecated library references to os and io respectively in the client package (#16318) 2023-03-08 13:25:10 -06:00
gc.go
gc_test.go
heartbeatstop.go
heartbeatstop_test.go
meta_endpoint.go
meta_endpoint_test.go
node_updater.go
rpc.go
rpc_test.go
testing.go
util.go