open-nomad/scheduler
Tim Gross 8ff5ea1bee
CSI: no early return when feasibility check fails on eligible nodes (#13274)
As a performance optimization in the scheduler, feasibility checks
that apply to an entire class are only checked once for all nodes of
that class. Other feasibility checks are "available" checks because
they rely on more ephemeral characteristics and don't contribute to
the hash for the node class. This currently includes only CSI.

We have a separate fast path for "available" checks when the node has
already been marked eligible on the basis of class. This fast path has
a bug where it returns early rather than continuing the loop. This
causes the entire task group to be rejected.

Fix the bug by not returning early in the fast path and instead jump
to the top of the loop like all the other code paths in this method.
Includes a new test exercising topology at whole-scheduler level and a
fix for an existing test that should've caught this previously.
2022-06-07 13:31:10 -04:00
..
benchmarks scheduler: tooling for scheduler benchmarking (#11725) 2021-12-22 10:05:44 -05:00
annotate.go scheduler: label loops with nested switch statements for effective break (#8528) 2020-07-24 08:50:41 -04:00
annotate_test.go ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
context.go scheduler: detect and log unexpected scheduling collisions (#11793) 2022-01-14 20:09:14 -05:00
context_test.go ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
device.go
device_test.go ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
feasible.go CSI: no early return when feasibility check fails on eligible nodes (#13274) 2022-06-07 13:31:10 -04:00
feasible_test.go ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
generic_sched.go system_scheduler: support disconnected clients (#12555) 2022-04-15 09:31:32 -04:00
generic_sched_test.go CSI: no early return when feasibility check fails on eligible nodes (#13274) 2022-06-07 13:31:10 -04:00
preemption.go
preemption_test.go ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
propertyset.go
rank.go scheduler: detect and log unexpected scheduling collisions (#11793) 2022-01-14 20:09:14 -05:00
rank_test.go scheduler: detect and log unexpected scheduling collisions (#11793) 2022-01-14 20:09:14 -05:00
reconcile.go reconciler: Handle canaries when client disconnects (#12539) 2022-04-21 10:05:58 -04:00
reconcile_test.go reconciler: Handle canaries when client disconnects (#12539) 2022-04-21 10:05:58 -04:00
reconcile_util.go core: reschedule evicted batch job when resources become available 2022-06-02 14:04:13 -05:00
reconcile_util_test.go core: reschedule evicted batch job when resources become available 2022-06-02 14:04:13 -05:00
scheduler.go disconnected clients: ensure servers meet minimum required version (#12202) 2022-04-05 17:12:23 -04:00
scheduler_oss.go gofmt all the files 2021-10-01 10:14:28 -04:00
scheduler_sysbatch_test.go ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
scheduler_system.go system_scheduler: support disconnected clients (#12555) 2022-04-15 09:31:32 -04:00
scheduler_system_test.go system_scheduler: support disconnected clients (#12555) 2022-04-15 09:31:32 -04:00
select.go chore: fix incorrect docstring formatting. 2021-08-30 11:08:12 +02:00
select_test.go ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
spread.go scheduler: prevent panic in spread iterator during alloc stop 2022-02-09 19:53:06 -05:00
spread_test.go ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
stack.go scheduler: seed random shuffle nodes with eval ID (#12008) 2022-02-08 12:16:33 -05:00
stack_oss.go chore: ensure consistent file naming for non-enterprise files. 2022-01-13 11:32:16 +01:00
stack_test.go ci: swap ci parallelization for unconstrained gomaxprocs 2022-03-15 12:58:52 -05:00
testing.go disconnected clients: ensure servers meet minimum required version (#12202) 2022-04-05 17:12:23 -04:00
util.go scheduler: volume updates should always be destructive (#13008) 2022-05-13 11:34:04 -04:00
util_test.go scheduler: volume updates should always be destructive (#13008) 2022-05-13 11:34:04 -04:00