5be806a3df
This PR fixes our vet script and fixes all the missed vet changes. It also fixes pointers being printed in `nomad stop <job>` and `nomad node-status <node>`.
72 lines
1.8 KiB
Makefile
72 lines
1.8 KiB
Makefile
PACKAGES = $(shell go list ./... | grep -v '/vendor/')
|
|
EXTERNAL_TOOLS=\
|
|
github.com/kardianos/govendor \
|
|
github.com/mitchellh/gox \
|
|
golang.org/x/tools/cmd/cover \
|
|
github.com/axw/gocov/gocov \
|
|
gopkg.in/matm/v1/gocov-html \
|
|
github.com/ugorji/go/codec/codecgen
|
|
|
|
all: test
|
|
|
|
dev: format generate
|
|
@scripts/build-dev.sh
|
|
|
|
bin: generate
|
|
@sh -c "'$(PWD)/scripts/build.sh'"
|
|
|
|
release:
|
|
@$(MAKE) bin
|
|
|
|
cov:
|
|
gocov test ./... | gocov-html > /tmp/coverage.html
|
|
open /tmp/coverage.html
|
|
|
|
test: generate
|
|
@echo "--> Running go fmt" ;
|
|
@if [ -n "`go fmt ${PACKAGES}`" ]; then \
|
|
echo "[ERR] go fmt updated formatting. Please commit formatted code first."; \
|
|
exit 1; \
|
|
fi
|
|
@sh -c "'$(PWD)/scripts/test.sh'"
|
|
@$(MAKE) vet
|
|
|
|
cover:
|
|
go list ./... | xargs -n1 go test --cover
|
|
|
|
format:
|
|
@echo "--> Running go fmt"
|
|
@go fmt $(PACKAGES)
|
|
|
|
generate:
|
|
@echo "--> Running go generate"
|
|
@go generate $(PACKAGES)
|
|
@sed -i.old -e 's|github.com/hashicorp/nomad/vendor/github.com/ugorji/go/codec|github.com/ugorji/go/codec|' nomad/structs/structs.generated.go
|
|
|
|
vet:
|
|
@echo "--> Running go vet $(VETARGS) ${PACKAGES}"
|
|
@go vet $(VETARGS) ${PACKAGES} ; if [ $$? -eq 1 ]; then \
|
|
echo ""; \
|
|
echo "[LINT] Vet found suspicious constructs. Please check the reported constructs"; \
|
|
echo "and fix them if necessary before submitting the code for review."; \
|
|
fi
|
|
|
|
@git grep -n `echo "log"".Print"` | grep -v 'vendor/' ; if [ $$? -eq 0 ]; then \
|
|
echo "[LINT] Found "log"".Printf" calls. These should use Nomad's logger instead."; \
|
|
fi
|
|
|
|
# bootstrap the build by downloading additional tools
|
|
bootstrap:
|
|
@for tool in $(EXTERNAL_TOOLS) ; do \
|
|
echo "Installing $$tool" ; \
|
|
go get $$tool; \
|
|
done
|
|
|
|
install: bin/nomad
|
|
install -o root -g wheel -m 0755 ./bin/nomad /usr/local/bin/nomad
|
|
|
|
travis:
|
|
@sh -c "'$(PWD)/scripts/travis.sh'"
|
|
|
|
.PHONY: all bin cov integ test vet test-nodep
|