97d1bc735c
* test: use `T.TempDir` to create temporary test directory This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `ioutil.TempDir` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * test: fix TestLogmon_Start_restart on Windows Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> * test: fix failing TestConsul_Integration t.TempDir fails to perform the cleanup properly because the folder is still in use testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
180 lines
4.1 KiB
Go
180 lines
4.1 KiB
Go
package agent
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"path/filepath"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/hashicorp/logutils"
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
const (
|
|
testFileName = "Nomad.log"
|
|
testDuration = 2 * time.Second
|
|
testBytes = 10
|
|
)
|
|
|
|
func TestLogFile_timeRotation(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
tempDir := t.TempDir()
|
|
|
|
filt := LevelFilter()
|
|
logFile := logFile{
|
|
logFilter: filt,
|
|
fileName: testFileName,
|
|
logPath: tempDir,
|
|
duration: testDuration,
|
|
}
|
|
logFile.Write([]byte("Hello World"))
|
|
time.Sleep(2 * time.Second)
|
|
logFile.Write([]byte("Second File"))
|
|
want := 2
|
|
if got, _ := ioutil.ReadDir(tempDir); len(got) != want {
|
|
t.Errorf("Expected %d files, got %v file(s)", want, len(got))
|
|
}
|
|
}
|
|
|
|
func TestLogFile_openNew(t *testing.T) {
|
|
ci.Parallel(t)
|
|
require := require.New(t)
|
|
|
|
tempDir := t.TempDir()
|
|
|
|
filt := LevelFilter()
|
|
filt.MinLevel = logutils.LogLevel("INFO")
|
|
logFile := logFile{
|
|
logFilter: filt,
|
|
fileName: testFileName,
|
|
logPath: tempDir,
|
|
MaxBytes: testBytes,
|
|
duration: 24 * time.Hour,
|
|
}
|
|
require.NoError(logFile.openNew())
|
|
|
|
_, err := ioutil.ReadFile(logFile.FileInfo.Name())
|
|
require.NoError(err)
|
|
|
|
require.Equal(logFile.FileInfo.Name(), filepath.Join(tempDir, testFileName))
|
|
|
|
// Check if create time and bytes written are kept when opening the active
|
|
// log file again.
|
|
bytesWritten, err := logFile.Write([]byte("test"))
|
|
require.NoError(err)
|
|
|
|
time.Sleep(2 * time.Second)
|
|
require.NoError(logFile.openNew())
|
|
|
|
timeDelta := time.Now().Sub(logFile.LastCreated)
|
|
require.GreaterOrEqual(timeDelta, 2*time.Second)
|
|
require.Equal(logFile.BytesWritten, int64(bytesWritten))
|
|
}
|
|
|
|
func TestLogFile_byteRotation(t *testing.T) {
|
|
ci.Parallel(t)
|
|
require := require.New(t)
|
|
|
|
tempDir := t.TempDir()
|
|
|
|
filt := LevelFilter()
|
|
filt.MinLevel = logutils.LogLevel("INFO")
|
|
logFile := logFile{
|
|
logFilter: filt,
|
|
fileName: testFileName,
|
|
logPath: tempDir,
|
|
MaxBytes: testBytes,
|
|
duration: 24 * time.Hour,
|
|
}
|
|
logFile.Write([]byte("Hello World"))
|
|
logFile.Write([]byte("Second File"))
|
|
want := 2
|
|
tempFiles, _ := ioutil.ReadDir(tempDir)
|
|
require.Equal(want, len(tempFiles))
|
|
}
|
|
|
|
func TestLogFile_logLevelFiltering(t *testing.T) {
|
|
ci.Parallel(t)
|
|
require := require.New(t)
|
|
|
|
tempDir := t.TempDir()
|
|
filt := LevelFilter()
|
|
logFile := logFile{
|
|
logFilter: filt,
|
|
fileName: testFileName,
|
|
logPath: tempDir,
|
|
MaxBytes: testBytes,
|
|
duration: testDuration,
|
|
}
|
|
logFile.Write([]byte("[INFO] This is an info message"))
|
|
logFile.Write([]byte("[DEBUG] This is a debug message"))
|
|
logFile.Write([]byte("[ERR] This is an error message"))
|
|
want := 2
|
|
tempFiles, _ := ioutil.ReadDir(tempDir)
|
|
require.Equal(want, len(tempFiles))
|
|
}
|
|
|
|
func TestLogFile_deleteArchives(t *testing.T) {
|
|
ci.Parallel(t)
|
|
require := require.New(t)
|
|
|
|
tempDir := t.TempDir()
|
|
|
|
filt := LevelFilter()
|
|
filt.MinLevel = logutils.LogLevel("INFO")
|
|
logFile := logFile{
|
|
logFilter: filt,
|
|
fileName: testFileName,
|
|
logPath: tempDir,
|
|
MaxBytes: testBytes,
|
|
duration: 24 * time.Hour,
|
|
MaxFiles: 1,
|
|
}
|
|
logFile.Write([]byte("[INFO] Hello World"))
|
|
logFile.Write([]byte("[INFO] Second File"))
|
|
logFile.Write([]byte("[INFO] Third File"))
|
|
want := 2
|
|
tempFiles, _ := ioutil.ReadDir(tempDir)
|
|
|
|
require.Equal(want, len(tempFiles))
|
|
|
|
for _, tempFile := range tempFiles {
|
|
var bytes []byte
|
|
var err error
|
|
path := filepath.Join(tempDir, tempFile.Name())
|
|
if bytes, err = ioutil.ReadFile(path); err != nil {
|
|
t.Errorf(err.Error())
|
|
return
|
|
}
|
|
contents := string(bytes)
|
|
|
|
require.NotEqual("[INFO] Hello World", contents, "oldest log should have been deleted")
|
|
}
|
|
}
|
|
|
|
func TestLogFile_deleteArchivesDisabled(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
require := require.New(t)
|
|
tempDir := t.TempDir()
|
|
|
|
filt := LevelFilter()
|
|
filt.MinLevel = logutils.LogLevel("INFO")
|
|
logFile := logFile{
|
|
logFilter: filt,
|
|
fileName: testFileName,
|
|
logPath: tempDir,
|
|
MaxBytes: testBytes,
|
|
duration: 24 * time.Hour,
|
|
MaxFiles: 0,
|
|
}
|
|
logFile.Write([]byte("[INFO] Hello World"))
|
|
logFile.Write([]byte("[INFO] Second File"))
|
|
logFile.Write([]byte("[INFO] Third File"))
|
|
want := 3
|
|
tempFiles, _ := ioutil.ReadDir(tempDir)
|
|
require.Equal(want, len(tempFiles))
|
|
}
|