908bfab4c2
0.9.0beta2 contains a regression where artifact download errors would not cause a task restart and instead immediately fail the task. This restores the pre-0.9 behavior of retrying all artifact errors and adds missing tests.
53 lines
1.3 KiB
Go
53 lines
1.3 KiB
Go
package taskrunner
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// Statically assert error implements the expected interfaces
|
|
var _ structs.Recoverable = (*hookError)(nil)
|
|
|
|
// TestHookError_Recoverable asserts that a NewHookError is recoverable if
|
|
// passed a recoverable error.
|
|
func TestHookError_Recoverable(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Create root error
|
|
root := errors.New("test error")
|
|
|
|
// Make it recoverable
|
|
recov := structs.NewRecoverableError(root, true)
|
|
|
|
// Create a fake task event
|
|
ev := structs.NewTaskEvent("test event")
|
|
|
|
herr := NewHookError(recov, ev)
|
|
|
|
require.Equal(t, ev, herr.(*hookError).taskEvent)
|
|
require.True(t, structs.IsRecoverable(herr))
|
|
require.Equal(t, root.Error(), herr.Error())
|
|
require.Equal(t, recov.Error(), herr.Error())
|
|
}
|
|
|
|
// TestHookError_Unrecoverable asserts that a NewHookError is not recoverable
|
|
// unless it is passed a recoverable error.
|
|
func TestHookError_Unrecoverable(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Create error
|
|
err := errors.New("test error")
|
|
|
|
// Create a fake task event
|
|
ev := structs.NewTaskEvent("test event")
|
|
|
|
herr := NewHookError(err, ev)
|
|
|
|
require.Equal(t, ev, herr.(*hookError).taskEvent)
|
|
require.False(t, structs.IsRecoverable(herr))
|
|
require.Equal(t, err.Error(), herr.Error())
|
|
}
|