e5a29b82db
A change in the behavior of `os.Rename` in Go 1.8 brought to light a
difference in the logic between `{Alloc,Task}Runner` and this test:
AllocRunner builds the alloc dir, moves dirs if necessary, and then lets
TaskRunner call TaskDir.Build().
This test called `TaskDir.Build` *before* `AllocDir.Move`, so in Go 1.8
it failed to `os.Rename over` the empty {data,local} dirs.
I updated the test to behave like the real code, but I defensively added
`os.Remove` calls as a subtle change in call order shouldn't break this
code. `os.Remove` won't remove a non-empty directory, so it's still
safe.
|
||
|---|---|---|
| .. | ||
| alloc_dir.go | ||
| alloc_dir_test.go | ||
| fs_darwin.go | ||
| fs_freebsd.go | ||
| fs_linux.go | ||
| fs_unix.go | ||
| fs_windows.go | ||
| task_dir.go | ||
| task_dir_linux.go | ||
| task_dir_nonlinux.go | ||
| task_dir_test.go | ||