2e5c6de820
This PR introduces support for using Nomad on systems with cgroups v2 [1] enabled as the cgroups controller mounted on /sys/fs/cgroups. Newer Linux distros like Ubuntu 21.10 are shipping with cgroups v2 only, causing problems for Nomad users. Nomad mostly "just works" with cgroups v2 due to the indirection via libcontainer, but not so for managing cpuset cgroups. Before, Nomad has been making use of a feature in v1 where a PID could be a member of more than one cgroup. In v2 this is no longer possible, and so the logic around computing cpuset values must be modified. When Nomad detects v2, it manages cpuset values in-process, rather than making use of cgroup heirarchy inheritence via shared/reserved parents. Nomad will only activate the v2 logic when it detects cgroups2 is mounted at /sys/fs/cgroups. This means on systems running in hybrid mode with cgroups2 mounted at /sys/fs/cgroups/unified (as is typical) Nomad will continue to use the v1 logic, and should operate as before. Systems that do not support cgroups v2 are also not affected. When v2 is activated, Nomad will create a parent called nomad.slice (unless otherwise configured in Client conifg), and create cgroups for tasks using naming convention <allocID>-<task>.scope. These follow the naming convention set by systemd and also used by Docker when cgroups v2 is detected. Client nodes now export a new fingerprint attribute, unique.cgroups.version which will be set to 'v1' or 'v2' to indicate the cgroups regime in use by Nomad. The new cpuset management strategy fixes #11705, where docker tasks that spawned processes on startup would "leak". In cgroups v2, the PIDs are started in the cgroup they will always live in, and thus the cause of the leak is eliminated. [1] https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.html Closes #11289 Fixes #11705 #11773 #11933
43 lines
1,017 B
Go
43 lines
1,017 B
Go
//go:build !linux
|
|
|
|
package cgutil
|
|
|
|
import (
|
|
"github.com/hashicorp/go-hclog"
|
|
)
|
|
|
|
const (
|
|
// DefaultCgroupParent does not apply to non-Linux operating systems.
|
|
DefaultCgroupParent = ""
|
|
)
|
|
|
|
// UseV2 is always false on non-Linux systems.
|
|
//
|
|
// This is a read-only value.
|
|
var UseV2 = false
|
|
|
|
// CreateCPUSetManager creates a no-op CpusetManager for non-Linux operating systems.
|
|
func CreateCPUSetManager(string, hclog.Logger) CpusetManager {
|
|
return new(NoopCpusetManager)
|
|
}
|
|
|
|
// FindCgroupMountpointDir returns nothing for non-Linux operating systems.
|
|
func FindCgroupMountpointDir() (string, error) {
|
|
return "", nil
|
|
}
|
|
|
|
// GetCgroupParent returns nothing for non-Linux operating systems.
|
|
func GetCgroupParent(string) string {
|
|
return DefaultCgroupParent
|
|
}
|
|
|
|
// GetCPUsFromCgroup returns nothing for non-Linux operating systems.
|
|
func GetCPUsFromCgroup(string) ([]uint16, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
// CgroupScope returns nothing for non-Linux operating systems.
|
|
func CgroupScope(allocID, task string) string {
|
|
return ""
|
|
}
|