d71a90c8a4
* Throw away result of multierror.Append When given a *multierror.Error, it is mutated, therefore the return value is not needed. * Simplify MergeMultierrorWarnings, use StringBuilder * Hash.Write() never returns an error * Remove error that was always nil * Remove error from Resources.Add signature When this was originally written it could return an error, but that was refactored away, and callers of it as of today never handle the error. * Throw away results of io.Copy during Bridge * Handle errors when computing node class in test
503 lines
14 KiB
Go
503 lines
14 KiB
Go
package loader
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"sort"
|
|
|
|
multierror "github.com/hashicorp/go-multierror"
|
|
plugin "github.com/hashicorp/go-plugin"
|
|
version "github.com/hashicorp/go-version"
|
|
"github.com/hashicorp/nomad/helper/pluginutils/hclspecutils"
|
|
"github.com/hashicorp/nomad/helper/pluginutils/hclutils"
|
|
"github.com/hashicorp/nomad/nomad/structs/config"
|
|
"github.com/hashicorp/nomad/plugins/base"
|
|
"github.com/zclconf/go-cty/cty/msgpack"
|
|
)
|
|
|
|
// validateConfig returns whether or not the configuration is valid
|
|
func validateConfig(config *PluginLoaderConfig) error {
|
|
var mErr multierror.Error
|
|
if config == nil {
|
|
return fmt.Errorf("nil config passed")
|
|
} else if config.Logger == nil {
|
|
_ = multierror.Append(&mErr, fmt.Errorf("nil logger passed"))
|
|
}
|
|
|
|
// Validate that all plugins have a binary name
|
|
for _, c := range config.Configs {
|
|
if c.Name == "" {
|
|
_ = multierror.Append(&mErr, fmt.Errorf("plugin config passed without binary name"))
|
|
}
|
|
}
|
|
|
|
// Validate internal plugins
|
|
for k, config := range config.InternalPlugins {
|
|
// Validate config
|
|
if config == nil {
|
|
_ = multierror.Append(&mErr, fmt.Errorf("nil config passed for internal plugin %s", k))
|
|
continue
|
|
} else if config.Factory == nil {
|
|
_ = multierror.Append(&mErr, fmt.Errorf("nil factory passed for internal plugin %s", k))
|
|
continue
|
|
}
|
|
}
|
|
|
|
return mErr.ErrorOrNil()
|
|
}
|
|
|
|
// init initializes the plugin loader by compiling both internal and external
|
|
// plugins and selecting the highest versioned version of any given plugin.
|
|
func (l *PluginLoader) init(config *PluginLoaderConfig) error {
|
|
// Create a mapping of name to config
|
|
configMap := configMap(config.Configs)
|
|
|
|
// Initialize the internal plugins
|
|
internal, err := l.initInternal(config.InternalPlugins, configMap)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to fingerprint internal plugins: %v", err)
|
|
}
|
|
|
|
// Scan for eligibile binaries
|
|
plugins, err := l.scan()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to scan plugin directory %q: %v", l.pluginDir, err)
|
|
}
|
|
|
|
// Fingerprint the passed plugins
|
|
external, err := l.fingerprintPlugins(plugins, configMap)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to fingerprint plugins: %v", err)
|
|
}
|
|
|
|
// Merge external and internal plugins
|
|
l.plugins = l.mergePlugins(internal, external)
|
|
|
|
// Validate that the configs are valid for the plugins
|
|
if err := l.validatePluginConfigs(); err != nil {
|
|
return fmt.Errorf("parsing plugin configurations failed: %v", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// initInternal initializes internal plugins.
|
|
func (l *PluginLoader) initInternal(plugins map[PluginID]*InternalPluginConfig, configs map[string]*config.PluginConfig) (map[PluginID]*pluginInfo, error) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
var mErr multierror.Error
|
|
fingerprinted := make(map[PluginID]*pluginInfo, len(plugins))
|
|
for k, config := range plugins {
|
|
// Create an instance
|
|
raw := config.Factory(ctx, l.logger)
|
|
base, ok := raw.(base.BasePlugin)
|
|
if !ok {
|
|
_ = multierror.Append(&mErr, fmt.Errorf("internal plugin %s doesn't meet base plugin interface", k))
|
|
continue
|
|
}
|
|
|
|
info := &pluginInfo{
|
|
factory: config.Factory,
|
|
config: config.Config,
|
|
}
|
|
|
|
// Try to retrieve a user specified config
|
|
if userConfig, ok := configs[k.Name]; ok && userConfig.Config != nil {
|
|
info.config = userConfig.Config
|
|
}
|
|
|
|
// Fingerprint base info
|
|
i, err := base.PluginInfo()
|
|
if err != nil {
|
|
_ = multierror.Append(&mErr, fmt.Errorf("PluginInfo info failed for internal plugin %s: %v", k, err))
|
|
continue
|
|
}
|
|
info.baseInfo = i
|
|
|
|
// Parse and set the plugin version
|
|
v, err := version.NewVersion(i.PluginVersion)
|
|
if err != nil {
|
|
_ = multierror.Append(&mErr, fmt.Errorf("failed to parse version %q for internal plugin %s: %v", i.PluginVersion, k, err))
|
|
continue
|
|
}
|
|
info.version = v
|
|
|
|
// Detect the plugin API version to use
|
|
av, err := l.selectApiVersion(i)
|
|
if err != nil {
|
|
_ = multierror.Append(&mErr, fmt.Errorf("failed to validate API versions %v for internal plugin %s: %v", i.PluginApiVersions, k, err))
|
|
continue
|
|
}
|
|
if av == "" {
|
|
l.logger.Warn("skipping plugin because supported API versions for plugin and Nomad do not overlap", "plugin", k)
|
|
continue
|
|
}
|
|
info.apiVersion = av
|
|
|
|
// Get the config schema
|
|
schema, err := base.ConfigSchema()
|
|
if err != nil {
|
|
_ = multierror.Append(&mErr, fmt.Errorf("failed to retrieve config schema for internal plugin %s: %v", k, err))
|
|
continue
|
|
}
|
|
info.configSchema = schema
|
|
|
|
// Store the fingerprinted config
|
|
fingerprinted[k] = info
|
|
}
|
|
|
|
if err := mErr.ErrorOrNil(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return fingerprinted, nil
|
|
}
|
|
|
|
// selectApiVersion takes in PluginInfo and returns the highest compatable
|
|
// version or an error if the plugins response is malformed. If there is no
|
|
// overlap, an empty string is returned.
|
|
func (l *PluginLoader) selectApiVersion(i *base.PluginInfoResponse) (string, error) {
|
|
if i == nil {
|
|
return "", fmt.Errorf("nil plugin info given")
|
|
}
|
|
if len(i.PluginApiVersions) == 0 {
|
|
return "", fmt.Errorf("plugin provided no compatible API versions")
|
|
}
|
|
|
|
pluginVersions, err := convertVersions(i.PluginApiVersions)
|
|
if err != nil {
|
|
return "", fmt.Errorf("plugin provided invalid versions: %v", err)
|
|
}
|
|
|
|
// Lookup the supported versions. These will be sorted highest to lowest
|
|
supportedVersions, ok := l.supportedVersions[i.Type]
|
|
if !ok {
|
|
return "", fmt.Errorf("unsupported plugin type %q", i.Type)
|
|
}
|
|
|
|
for _, sv := range supportedVersions {
|
|
for _, pv := range pluginVersions {
|
|
if sv.Equal(pv) {
|
|
return pv.Original(), nil
|
|
}
|
|
}
|
|
}
|
|
|
|
return "", nil
|
|
}
|
|
|
|
// convertVersions takes a list of string versions and returns a sorted list of
|
|
// versions from highest to lowest.
|
|
func convertVersions(in []string) ([]*version.Version, error) {
|
|
converted := make([]*version.Version, len(in))
|
|
for i, v := range in {
|
|
vv, err := version.NewVersion(v)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to convert version %q : %v", v, err)
|
|
}
|
|
|
|
converted[i] = vv
|
|
}
|
|
|
|
sort.Slice(converted, func(i, j int) bool {
|
|
return converted[i].GreaterThan(converted[j])
|
|
})
|
|
|
|
return converted, nil
|
|
}
|
|
|
|
// scan scans the plugin directory and retrieves potentially eligible binaries
|
|
func (l *PluginLoader) scan() ([]os.FileInfo, error) {
|
|
if l.pluginDir == "" {
|
|
return nil, nil
|
|
}
|
|
|
|
// Capture the list of binaries in the plugins folder
|
|
f, err := os.Open(l.pluginDir)
|
|
if err != nil {
|
|
// There are no plugins to scan
|
|
if os.IsNotExist(err) {
|
|
l.logger.Warn("skipping external plugins since plugin_dir doesn't exist")
|
|
return nil, nil
|
|
}
|
|
|
|
return nil, fmt.Errorf("failed to open plugin directory %q: %v", l.pluginDir, err)
|
|
}
|
|
files, err := f.Readdirnames(-1)
|
|
f.Close()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to read plugin directory %q: %v", l.pluginDir, err)
|
|
}
|
|
|
|
var plugins []os.FileInfo
|
|
for _, f := range files {
|
|
f = filepath.Join(l.pluginDir, f)
|
|
s, err := os.Stat(f)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to stat file %q: %v", f, err)
|
|
}
|
|
if s.IsDir() {
|
|
l.logger.Warn("skipping subdir in plugin folder", "subdir", f)
|
|
continue
|
|
}
|
|
|
|
if !executable(f, s) {
|
|
l.logger.Warn("skipping un-executable file in plugin folder", "file", f)
|
|
continue
|
|
}
|
|
plugins = append(plugins, s)
|
|
}
|
|
|
|
return plugins, nil
|
|
}
|
|
|
|
// fingerprintPlugins fingerprints all external plugin binaries
|
|
func (l *PluginLoader) fingerprintPlugins(plugins []os.FileInfo, configs map[string]*config.PluginConfig) (map[PluginID]*pluginInfo, error) {
|
|
var mErr multierror.Error
|
|
fingerprinted := make(map[PluginID]*pluginInfo, len(plugins))
|
|
for _, p := range plugins {
|
|
name := cleanPluginExecutable(p.Name())
|
|
c := configs[name]
|
|
info, err := l.fingerprintPlugin(p, c)
|
|
if err != nil {
|
|
l.logger.Error("failed to fingerprint plugin", "plugin", name, "error", err)
|
|
_ = multierror.Append(&mErr, err)
|
|
continue
|
|
}
|
|
if info == nil {
|
|
// Plugin was skipped for validation reasons
|
|
continue
|
|
}
|
|
|
|
id := PluginID{
|
|
Name: info.baseInfo.Name,
|
|
PluginType: info.baseInfo.Type,
|
|
}
|
|
|
|
// Detect if we already have seen a version of this plugin
|
|
if prev, ok := fingerprinted[id]; ok {
|
|
oldVersion := prev.version
|
|
selectedVersion := info.version
|
|
skip := false
|
|
|
|
// Determine if we should keep the previous version or override
|
|
if prev.version.GreaterThan(info.version) {
|
|
oldVersion = info.version
|
|
selectedVersion = prev.version
|
|
skip = true
|
|
}
|
|
l.logger.Info("multiple versions of plugin detected",
|
|
"plugin", info.baseInfo.Name, "older_version", oldVersion, "selected_version", selectedVersion)
|
|
|
|
if skip {
|
|
continue
|
|
}
|
|
}
|
|
|
|
// Add the plugin
|
|
fingerprinted[id] = info
|
|
}
|
|
|
|
if err := mErr.ErrorOrNil(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return fingerprinted, nil
|
|
}
|
|
|
|
// fingerprintPlugin fingerprints the passed external plugin
|
|
func (l *PluginLoader) fingerprintPlugin(pluginExe os.FileInfo, config *config.PluginConfig) (*pluginInfo, error) {
|
|
info := &pluginInfo{
|
|
exePath: filepath.Join(l.pluginDir, pluginExe.Name()),
|
|
}
|
|
|
|
// Build the command
|
|
cmd := exec.Command(info.exePath)
|
|
if config != nil {
|
|
cmd.Args = append(cmd.Args, config.Args...)
|
|
info.args = config.Args
|
|
info.config = config.Config
|
|
}
|
|
|
|
// Launch the plugin
|
|
client := plugin.NewClient(&plugin.ClientConfig{
|
|
HandshakeConfig: base.Handshake,
|
|
Plugins: map[string]plugin.Plugin{
|
|
base.PluginTypeBase: &base.PluginBase{},
|
|
},
|
|
Cmd: cmd,
|
|
AllowedProtocols: []plugin.Protocol{plugin.ProtocolGRPC},
|
|
Logger: l.logger,
|
|
})
|
|
defer client.Kill()
|
|
|
|
// Connect via RPC
|
|
rpcClient, err := client.Client()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Request the plugin
|
|
raw, err := rpcClient.Dispense(base.PluginTypeBase)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Cast the plugin to the base type
|
|
bplugin := raw.(base.BasePlugin)
|
|
|
|
// Retrieve base plugin information
|
|
i, err := bplugin.PluginInfo()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to get plugin info for plugin %q: %v", info.exePath, err)
|
|
}
|
|
info.baseInfo = i
|
|
|
|
// Parse and set the plugin version
|
|
v, err := version.NewVersion(i.PluginVersion)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to parse plugin %q (%v) version %q: %v",
|
|
i.Name, info.exePath, i.PluginVersion, err)
|
|
}
|
|
info.version = v
|
|
|
|
// Detect the plugin API version to use
|
|
av, err := l.selectApiVersion(i)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to validate API versions %v for plugin %s (%v): %v", i.PluginApiVersions, i.Name, info.exePath, err)
|
|
}
|
|
if av == "" {
|
|
l.logger.Warn("skipping plugin because supported API versions for plugin and Nomad do not overlap", "plugin", i.Name, "path", info.exePath)
|
|
return nil, nil
|
|
}
|
|
info.apiVersion = av
|
|
|
|
// Retrieve the schema
|
|
schema, err := bplugin.ConfigSchema()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to get plugin config schema for plugin %q: %v", info.exePath, err)
|
|
}
|
|
info.configSchema = schema
|
|
|
|
return info, nil
|
|
}
|
|
|
|
// mergePlugins merges internal and external plugins, preferring the highest
|
|
// version.
|
|
func (l *PluginLoader) mergePlugins(internal, external map[PluginID]*pluginInfo) map[PluginID]*pluginInfo {
|
|
finalized := make(map[PluginID]*pluginInfo, len(internal))
|
|
|
|
// Load the internal plugins
|
|
for k, v := range internal {
|
|
finalized[k] = v
|
|
}
|
|
|
|
for k, extPlugin := range external {
|
|
internal, ok := finalized[k]
|
|
if ok {
|
|
// We have overlapping plugins, determine if we should keep the
|
|
// internal version or override
|
|
if extPlugin.version.LessThan(internal.version) {
|
|
l.logger.Info("preferring internal version of plugin",
|
|
"plugin", extPlugin.baseInfo.Name, "internal_version", internal.version,
|
|
"external_version", extPlugin.version)
|
|
continue
|
|
}
|
|
}
|
|
|
|
// Add external plugin
|
|
finalized[k] = extPlugin
|
|
}
|
|
|
|
return finalized
|
|
}
|
|
|
|
// validatePluginConfigs is used to validate each plugins' configuration. If the
|
|
// plugin has a config, it is parsed with the plugins config schema and
|
|
// SetConfig is called to ensure the config is valid.
|
|
func (l *PluginLoader) validatePluginConfigs() error {
|
|
var mErr multierror.Error
|
|
for id, info := range l.plugins {
|
|
if err := l.validatePluginConfig(id, info); err != nil {
|
|
wrapped := multierror.Prefix(err, fmt.Sprintf("plugin %s:", id))
|
|
_ = multierror.Append(&mErr, wrapped)
|
|
}
|
|
}
|
|
|
|
return mErr.ErrorOrNil()
|
|
}
|
|
|
|
// validatePluginConfig is used to validate the plugin's configuration. If the
|
|
// plugin has a config, it is parsed with the plugins config schema and
|
|
// SetConfig is called to ensure the config is valid.
|
|
func (l *PluginLoader) validatePluginConfig(id PluginID, info *pluginInfo) error {
|
|
var mErr multierror.Error
|
|
|
|
// Check if a config is allowed
|
|
if info.configSchema == nil {
|
|
if info.config != nil {
|
|
return fmt.Errorf("configuration not allowed but config passed")
|
|
}
|
|
|
|
// Nothing to do
|
|
return nil
|
|
}
|
|
|
|
// Convert the schema to hcl
|
|
spec, diag := hclspecutils.Convert(info.configSchema)
|
|
if diag.HasErrors() {
|
|
_ = multierror.Append(&mErr, diag.Errs()...)
|
|
return multierror.Prefix(&mErr, "failed converting config schema:")
|
|
}
|
|
|
|
// If there is no config, initialize it to an empty map so we can still
|
|
// handle defaults
|
|
if info.config == nil {
|
|
info.config = map[string]interface{}{}
|
|
}
|
|
|
|
// Parse the config using the spec
|
|
val, diag, diagErrs := hclutils.ParseHclInterface(info.config, spec, nil)
|
|
if diag.HasErrors() {
|
|
_ = multierror.Append(&mErr, diagErrs...)
|
|
return multierror.Prefix(&mErr, "failed to parse config: ")
|
|
|
|
}
|
|
|
|
// Marshal the value
|
|
cdata, err := msgpack.Marshal(val, val.Type())
|
|
if err != nil {
|
|
return fmt.Errorf("failed to msgpack encode config: %v", err)
|
|
}
|
|
|
|
// Store the marshalled config
|
|
info.msgpackConfig = cdata
|
|
|
|
// Dispense the plugin and set its config and ensure it is error free
|
|
instance, err := l.Dispense(id.Name, id.PluginType, nil, l.logger)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to dispense plugin: %v", err)
|
|
}
|
|
defer instance.Kill()
|
|
|
|
b, ok := instance.Plugin().(base.BasePlugin)
|
|
if !ok {
|
|
return fmt.Errorf("dispensed plugin %s doesn't meet base plugin interface", id)
|
|
}
|
|
|
|
c := &base.Config{
|
|
PluginConfig: cdata,
|
|
AgentConfig: nil,
|
|
ApiVersion: info.apiVersion,
|
|
}
|
|
|
|
if err := b.SetConfig(c); err != nil {
|
|
return fmt.Errorf("setting config on plugin failed: %v", err)
|
|
}
|
|
return nil
|
|
}
|