285e80ac0f
Many thanks to @iverberk for the original PR (#1609), but we ended up not wanting to ship this implementation with 0.5. We'll come back to it after 0.5 and hopefully find a way to leverage filesystem accounting and quotas, so we can skip the expensive polling.
369 lines
9.2 KiB
Go
369 lines
9.2 KiB
Go
package executor
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"log"
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"strings"
|
|
"syscall"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/hashicorp/nomad/client/allocdir"
|
|
"github.com/hashicorp/nomad/client/driver/env"
|
|
"github.com/hashicorp/nomad/client/testutil"
|
|
"github.com/hashicorp/nomad/nomad/mock"
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
tu "github.com/hashicorp/nomad/testutil"
|
|
"github.com/mitchellh/go-ps"
|
|
)
|
|
|
|
var (
|
|
constraint = &structs.Resources{
|
|
CPU: 250,
|
|
MemoryMB: 256,
|
|
Networks: []*structs.NetworkResource{
|
|
&structs.NetworkResource{
|
|
MBits: 50,
|
|
DynamicPorts: []structs.Port{{Label: "http"}},
|
|
},
|
|
},
|
|
}
|
|
)
|
|
|
|
func mockAllocDir(t *testing.T) (*structs.Task, *allocdir.AllocDir) {
|
|
alloc := mock.Alloc()
|
|
task := alloc.Job.TaskGroups[0].Tasks[0]
|
|
|
|
allocDir := allocdir.NewAllocDir(filepath.Join(os.TempDir(), alloc.ID))
|
|
if err := allocDir.Build([]*structs.Task{task}); err != nil {
|
|
log.Panicf("allocDir.Build() failed: %v", err)
|
|
}
|
|
|
|
return task, allocDir
|
|
}
|
|
|
|
func testExecutorContext(t *testing.T) *ExecutorContext {
|
|
taskEnv := env.NewTaskEnvironment(mock.Node())
|
|
task, allocDir := mockAllocDir(t)
|
|
ctx := &ExecutorContext{
|
|
TaskEnv: taskEnv,
|
|
Task: task,
|
|
AllocDir: allocDir,
|
|
}
|
|
return ctx
|
|
}
|
|
|
|
func TestExecutor_Start_Invalid(t *testing.T) {
|
|
invalid := "/bin/foobar"
|
|
execCmd := ExecCommand{Cmd: invalid, Args: []string{"1"}}
|
|
ctx := testExecutorContext(t)
|
|
defer ctx.AllocDir.Destroy()
|
|
executor := NewExecutor(log.New(os.Stdout, "", log.LstdFlags))
|
|
|
|
if err := executor.SetContext(ctx); err != nil {
|
|
t.Fatalf("Unexpected error")
|
|
}
|
|
|
|
if _, err := executor.LaunchCmd(&execCmd); err == nil {
|
|
t.Fatalf("Expected error")
|
|
}
|
|
}
|
|
|
|
func TestExecutor_Start_Wait_Failure_Code(t *testing.T) {
|
|
execCmd := ExecCommand{Cmd: "/bin/sleep", Args: []string{"fail"}}
|
|
ctx := testExecutorContext(t)
|
|
defer ctx.AllocDir.Destroy()
|
|
executor := NewExecutor(log.New(os.Stdout, "", log.LstdFlags))
|
|
|
|
if err := executor.SetContext(ctx); err != nil {
|
|
t.Fatalf("Unexpected error")
|
|
}
|
|
|
|
ps, err := executor.LaunchCmd(&execCmd)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error")
|
|
}
|
|
|
|
if ps.Pid == 0 {
|
|
t.Fatalf("expected process to start and have non zero pid")
|
|
}
|
|
ps, _ = executor.Wait()
|
|
if ps.ExitCode < 1 {
|
|
t.Fatalf("expected exit code to be non zero, actual: %v", ps.ExitCode)
|
|
}
|
|
if err := executor.Exit(); err != nil {
|
|
t.Fatalf("error: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestExecutor_Start_Wait(t *testing.T) {
|
|
execCmd := ExecCommand{Cmd: "/bin/echo", Args: []string{"hello world"}}
|
|
ctx := testExecutorContext(t)
|
|
defer ctx.AllocDir.Destroy()
|
|
executor := NewExecutor(log.New(os.Stdout, "", log.LstdFlags))
|
|
|
|
if err := executor.SetContext(ctx); err != nil {
|
|
t.Fatalf("Unexpected error")
|
|
}
|
|
|
|
ps, err := executor.LaunchCmd(&execCmd)
|
|
if err != nil {
|
|
t.Fatalf("error in launching command: %v", err)
|
|
}
|
|
if ps.Pid == 0 {
|
|
t.Fatalf("expected process to start and have non zero pid")
|
|
}
|
|
ps, err = executor.Wait()
|
|
if err != nil {
|
|
t.Fatalf("error in waiting for command: %v", err)
|
|
}
|
|
if err := executor.Exit(); err != nil {
|
|
t.Fatalf("error: %v", err)
|
|
}
|
|
|
|
expected := "hello world"
|
|
file := filepath.Join(ctx.AllocDir.LogDir(), "web.stdout.0")
|
|
output, err := ioutil.ReadFile(file)
|
|
if err != nil {
|
|
t.Fatalf("Couldn't read file %v", file)
|
|
}
|
|
|
|
act := strings.TrimSpace(string(output))
|
|
if act != expected {
|
|
t.Fatalf("Command output incorrectly: want %v; got %v", expected, act)
|
|
}
|
|
}
|
|
|
|
func TestExecutor_WaitExitSignal(t *testing.T) {
|
|
execCmd := ExecCommand{Cmd: "/bin/sleep", Args: []string{"10000"}}
|
|
ctx := testExecutorContext(t)
|
|
defer ctx.AllocDir.Destroy()
|
|
executor := NewExecutor(log.New(os.Stdout, "", log.LstdFlags))
|
|
|
|
if err := executor.SetContext(ctx); err != nil {
|
|
t.Fatalf("Unexpected error")
|
|
}
|
|
|
|
ps, err := executor.LaunchCmd(&execCmd)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
go func() {
|
|
time.Sleep(3 * time.Second)
|
|
ru, err := executor.Stats()
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
if len(ru.Pids) != 2 {
|
|
t.Fatalf("expected number of pids: 2, actual: %v", len(ru.Pids))
|
|
}
|
|
proc, err := os.FindProcess(ps.Pid)
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
if err := proc.Signal(syscall.SIGKILL); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
}()
|
|
|
|
ps, err = executor.Wait()
|
|
if err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
if ps.Signal != int(syscall.SIGKILL) {
|
|
t.Fatalf("expected signal: %v, actual: %v", int(syscall.SIGKILL), ps.Signal)
|
|
}
|
|
}
|
|
|
|
func TestExecutor_ClientCleanup(t *testing.T) {
|
|
testutil.ExecCompatible(t)
|
|
|
|
execCmd := ExecCommand{Cmd: "/bin/bash", Args: []string{"-c", "/usr/bin/yes"}}
|
|
ctx := testExecutorContext(t)
|
|
ctx.Task.LogConfig.MaxFiles = 1
|
|
ctx.Task.LogConfig.MaxFileSizeMB = 300
|
|
defer ctx.AllocDir.Destroy()
|
|
|
|
execCmd.FSIsolation = true
|
|
execCmd.ResourceLimits = true
|
|
execCmd.User = "nobody"
|
|
|
|
executor := NewExecutor(log.New(os.Stdout, "", log.LstdFlags))
|
|
|
|
if err := executor.SetContext(ctx); err != nil {
|
|
t.Fatalf("Unexpected error")
|
|
}
|
|
|
|
ps, err := executor.LaunchCmd(&execCmd)
|
|
if err != nil {
|
|
t.Fatalf("error in launching command: %v", err)
|
|
}
|
|
if ps.Pid == 0 {
|
|
t.Fatalf("expected process to start and have non zero pid")
|
|
}
|
|
time.Sleep(200 * time.Millisecond)
|
|
if err := executor.Exit(); err != nil {
|
|
t.Fatalf("err: %v", err)
|
|
}
|
|
|
|
file := filepath.Join(ctx.AllocDir.LogDir(), "web.stdout.0")
|
|
finfo, err := os.Stat(file)
|
|
if err != nil {
|
|
t.Fatalf("error stating stdout file: %v", err)
|
|
}
|
|
time.Sleep(1 * time.Second)
|
|
finfo1, err := os.Stat(file)
|
|
if err != nil {
|
|
t.Fatalf("error stating stdout file: %v", err)
|
|
}
|
|
if finfo.Size() != finfo1.Size() {
|
|
t.Fatalf("Expected size: %v, actual: %v", finfo.Size(), finfo1.Size())
|
|
}
|
|
}
|
|
|
|
func TestExecutor_Start_Kill(t *testing.T) {
|
|
execCmd := ExecCommand{Cmd: "/bin/sleep", Args: []string{"10 && hello world"}}
|
|
ctx := testExecutorContext(t)
|
|
defer ctx.AllocDir.Destroy()
|
|
executor := NewExecutor(log.New(os.Stdout, "", log.LstdFlags))
|
|
|
|
if err := executor.SetContext(ctx); err != nil {
|
|
t.Fatalf("Unexpected error")
|
|
}
|
|
|
|
ps, err := executor.LaunchCmd(&execCmd)
|
|
if err != nil {
|
|
t.Fatalf("error in launching command: %v", err)
|
|
}
|
|
if ps.Pid == 0 {
|
|
t.Fatalf("expected process to start and have non zero pid")
|
|
}
|
|
ps, err = executor.Wait()
|
|
if err != nil {
|
|
t.Fatalf("error in waiting for command: %v", err)
|
|
}
|
|
if err := executor.Exit(); err != nil {
|
|
t.Fatalf("error: %v", err)
|
|
}
|
|
|
|
file := filepath.Join(ctx.AllocDir.LogDir(), "web.stdout.0")
|
|
time.Sleep(time.Duration(tu.TestMultiplier()*2) * time.Second)
|
|
|
|
output, err := ioutil.ReadFile(file)
|
|
if err != nil {
|
|
t.Fatalf("Couldn't read file %v", file)
|
|
}
|
|
|
|
expected := ""
|
|
act := strings.TrimSpace(string(output))
|
|
if act != expected {
|
|
t.Fatalf("Command output incorrectly: want %v; got %v", expected, act)
|
|
}
|
|
}
|
|
|
|
func TestExecutor_MakeExecutable(t *testing.T) {
|
|
// Create a temp file
|
|
f, err := ioutil.TempFile("", "")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer f.Close()
|
|
defer os.Remove(f.Name())
|
|
|
|
// Set its permissions to be non-executable
|
|
f.Chmod(os.FileMode(0610))
|
|
|
|
// Make a fake exececutor
|
|
ctx := testExecutorContext(t)
|
|
defer ctx.AllocDir.Destroy()
|
|
executor := NewExecutor(log.New(os.Stdout, "", log.LstdFlags))
|
|
|
|
err = executor.(*UniversalExecutor).makeExecutable(f.Name())
|
|
if err != nil {
|
|
t.Fatalf("makeExecutable() failed: %v", err)
|
|
}
|
|
|
|
// Check the permissions
|
|
stat, err := f.Stat()
|
|
if err != nil {
|
|
t.Fatalf("Stat() failed: %v", err)
|
|
}
|
|
|
|
act := stat.Mode().Perm()
|
|
exp := os.FileMode(0755)
|
|
if act != exp {
|
|
t.Fatalf("expected permissions %v; got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestExecutorInterpolateServices(t *testing.T) {
|
|
task := mock.Job().TaskGroups[0].Tasks[0]
|
|
// Make a fake exececutor
|
|
ctx := testExecutorContext(t)
|
|
defer ctx.AllocDir.Destroy()
|
|
executor := NewExecutor(log.New(os.Stdout, "", log.LstdFlags))
|
|
|
|
executor.(*UniversalExecutor).ctx = ctx
|
|
executor.(*UniversalExecutor).interpolateServices(task)
|
|
expectedTags := []string{"pci:true", "datacenter:dc1"}
|
|
if !reflect.DeepEqual(task.Services[0].Tags, expectedTags) {
|
|
t.Fatalf("expected: %v, actual: %v", expectedTags, task.Services[0].Tags)
|
|
}
|
|
|
|
expectedCheckCmd := "/usr/local/check-table-mysql"
|
|
expectedCheckArgs := []string{"5.6"}
|
|
if !reflect.DeepEqual(task.Services[0].Checks[0].Command, expectedCheckCmd) {
|
|
t.Fatalf("expected: %v, actual: %v", expectedCheckCmd, task.Services[0].Checks[0].Command)
|
|
}
|
|
|
|
if !reflect.DeepEqual(task.Services[0].Checks[0].Args, expectedCheckArgs) {
|
|
t.Fatalf("expected: %v, actual: %v", expectedCheckArgs, task.Services[0].Checks[0].Args)
|
|
}
|
|
}
|
|
|
|
func TestScanPids(t *testing.T) {
|
|
p1 := NewFakeProcess(2, 5)
|
|
p2 := NewFakeProcess(10, 2)
|
|
p3 := NewFakeProcess(15, 6)
|
|
p4 := NewFakeProcess(3, 10)
|
|
p5 := NewFakeProcess(20, 18)
|
|
|
|
// Make a fake exececutor
|
|
ctx := testExecutorContext(t)
|
|
defer ctx.AllocDir.Destroy()
|
|
executor := NewExecutor(log.New(os.Stdout, "", log.LstdFlags)).(*UniversalExecutor)
|
|
|
|
nomadPids, err := executor.scanPids(5, []ps.Process{p1, p2, p3, p4, p5})
|
|
if err != nil {
|
|
t.Fatalf("error: %v", err)
|
|
}
|
|
if len(nomadPids) != 4 {
|
|
t.Fatalf("expected: 4, actual: %v", len(nomadPids))
|
|
}
|
|
}
|
|
|
|
type FakeProcess struct {
|
|
pid int
|
|
ppid int
|
|
}
|
|
|
|
func (f FakeProcess) Pid() int {
|
|
return f.pid
|
|
}
|
|
|
|
func (f FakeProcess) PPid() int {
|
|
return f.ppid
|
|
}
|
|
|
|
func (f FakeProcess) Executable() string {
|
|
return "fake"
|
|
}
|
|
|
|
func NewFakeProcess(pid int, ppid int) ps.Process {
|
|
return FakeProcess{pid: pid, ppid: ppid}
|
|
}
|