open-nomad/client/state
Eng Zer Jun 97d1bc735c
test: use T.TempDir to create temporary test directory (#12853)
* test: use `T.TempDir` to create temporary test directory

This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.

Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
	defer func() {
		if err := os.RemoveAll(dir); err != nil {
			t.Fatal(err)
		}
	}
is also tedious, but `t.TempDir` handles this for us nicely.

Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

* test: fix TestLogmon_Start_restart on Windows

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

* test: fix failing TestConsul_Integration

t.TempDir fails to perform the cleanup properly because the folder is
still in use

testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-05-12 11:42:40 -04:00
..
testdata CSI: allow for concurrent plugin allocations (#12078) 2022-02-23 15:23:07 -05:00
08types.go Add gosimple linter (#9590) 2020-12-09 11:05:18 -08:00
12types.go CSI: allow for concurrent plugin allocations (#12078) 2022-02-23 15:23:07 -05:00
db_test.go test: use T.TempDir to create temporary test directory (#12853) 2022-05-12 11:42:40 -04:00
errdb.go Implement 'batch mode' for persisting allocations on the client. (#9093) 2020-10-20 16:15:37 -04:00
interface.go chore: fix incorrect docstring formatting. 2021-08-30 11:08:12 +02:00
memdb.go Implement 'batch mode' for persisting allocations on the client. (#9093) 2020-10-20 16:15:37 -04:00
noopdb.go Implement 'batch mode' for persisting allocations on the client. (#9093) 2020-10-20 16:15:37 -04:00
state_database.go agent: switch to go.etc.io/bbolt for state store 2022-02-23 14:28:31 -06:00
upgrade.go client: resolve rebase conflict 2022-02-23 14:32:32 -06:00
upgrade_int_test.go test: use T.TempDir to create temporary test directory (#12853) 2022-05-12 11:42:40 -04:00
upgrade_test.go test: use T.TempDir to create temporary test directory (#12853) 2022-05-12 11:42:40 -04:00