4bc6e5a215
This PR adds default_pid_mode and default_ipc_mode options to the exec and java task drivers. By default these will default to "private" mode, enabling PID and IPC isolation for tasks. Setting them to "host" mode disables isolation. Doing so is not recommended, but may be necessary to support legacy job configurations. Closes #9969
436 lines
10 KiB
Go
436 lines
10 KiB
Go
package java
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
dtestutil "github.com/hashicorp/nomad/plugins/drivers/testutils"
|
|
|
|
"context"
|
|
"time"
|
|
|
|
ctestutil "github.com/hashicorp/nomad/client/testutil"
|
|
"github.com/hashicorp/nomad/helper/pluginutils/hclutils"
|
|
"github.com/hashicorp/nomad/helper/testlog"
|
|
"github.com/hashicorp/nomad/helper/uuid"
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
"github.com/hashicorp/nomad/plugins/drivers"
|
|
"github.com/hashicorp/nomad/testutil"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func javaCompatible(t *testing.T) {
|
|
ctestutil.JavaCompatible(t)
|
|
|
|
_, _, _, err := javaVersionInfo()
|
|
if err != nil {
|
|
t.Skipf("java not found; skipping: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestJavaDriver_Fingerprint(t *testing.T) {
|
|
javaCompatible(t)
|
|
if !testutil.IsCI() {
|
|
t.Parallel()
|
|
}
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
d := NewDriver(ctx, testlog.HCLogger(t))
|
|
harness := dtestutil.NewDriverHarness(t, d)
|
|
|
|
fpCh, err := harness.Fingerprint(context.Background())
|
|
require.NoError(t, err)
|
|
|
|
select {
|
|
case fp := <-fpCh:
|
|
require.Equal(t, drivers.HealthStateHealthy, fp.Health)
|
|
detected, _ := fp.Attributes["driver.java"].GetBool()
|
|
require.True(t, detected)
|
|
case <-time.After(time.Duration(testutil.TestMultiplier()*5) * time.Second):
|
|
require.Fail(t, "timeout receiving fingerprint")
|
|
}
|
|
}
|
|
|
|
func TestJavaDriver_Jar_Start_Wait(t *testing.T) {
|
|
javaCompatible(t)
|
|
if !testutil.IsCI() {
|
|
t.Parallel()
|
|
}
|
|
|
|
require := require.New(t)
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
d := NewDriver(ctx, testlog.HCLogger(t))
|
|
harness := dtestutil.NewDriverHarness(t, d)
|
|
|
|
tc := &TaskConfig{
|
|
JarPath: "demoapp.jar",
|
|
Args: []string{"1"},
|
|
JvmOpts: []string{"-Xmx64m", "-Xms32m"},
|
|
}
|
|
task := basicTask(t, "demo-app", tc)
|
|
|
|
cleanup := harness.MkAllocDir(task, true)
|
|
defer cleanup()
|
|
|
|
copyFile("./test-resources/demoapp.jar", filepath.Join(task.TaskDir().Dir, "demoapp.jar"), t)
|
|
|
|
handle, _, err := harness.StartTask(task)
|
|
require.NoError(err)
|
|
|
|
ch, err := harness.WaitTask(context.Background(), handle.Config.ID)
|
|
require.NoError(err)
|
|
result := <-ch
|
|
require.Nil(result.Err)
|
|
|
|
require.Zero(result.ExitCode)
|
|
|
|
// Get the stdout of the process and assert that it's not empty
|
|
stdout, err := ioutil.ReadFile(filepath.Join(task.TaskDir().LogDir, "demo-app.stdout.0"))
|
|
require.NoError(err)
|
|
require.Contains(string(stdout), "Hello")
|
|
|
|
require.NoError(harness.DestroyTask(task.ID, true))
|
|
}
|
|
|
|
func TestJavaDriver_Jar_Stop_Wait(t *testing.T) {
|
|
javaCompatible(t)
|
|
if !testutil.IsCI() {
|
|
t.Parallel()
|
|
}
|
|
|
|
require := require.New(t)
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
d := NewDriver(ctx, testlog.HCLogger(t))
|
|
harness := dtestutil.NewDriverHarness(t, d)
|
|
|
|
tc := &TaskConfig{
|
|
JarPath: "demoapp.jar",
|
|
Args: []string{"600"},
|
|
JvmOpts: []string{"-Xmx64m", "-Xms32m"},
|
|
}
|
|
task := basicTask(t, "demo-app", tc)
|
|
|
|
cleanup := harness.MkAllocDir(task, true)
|
|
defer cleanup()
|
|
|
|
copyFile("./test-resources/demoapp.jar", filepath.Join(task.TaskDir().Dir, "demoapp.jar"), t)
|
|
|
|
handle, _, err := harness.StartTask(task)
|
|
require.NoError(err)
|
|
|
|
ch, err := harness.WaitTask(context.Background(), handle.Config.ID)
|
|
require.NoError(err)
|
|
|
|
require.NoError(harness.WaitUntilStarted(task.ID, 1*time.Second))
|
|
|
|
go func() {
|
|
time.Sleep(10 * time.Millisecond)
|
|
harness.StopTask(task.ID, 2*time.Second, "SIGINT")
|
|
}()
|
|
|
|
select {
|
|
case result := <-ch:
|
|
require.False(result.Successful())
|
|
case <-time.After(10 * time.Second):
|
|
require.Fail("timeout waiting for task to shutdown")
|
|
}
|
|
|
|
// Ensure that the task is marked as dead, but account
|
|
// for WaitTask() closing channel before internal state is updated
|
|
testutil.WaitForResult(func() (bool, error) {
|
|
status, err := harness.InspectTask(task.ID)
|
|
if err != nil {
|
|
return false, fmt.Errorf("inspecting task failed: %v", err)
|
|
}
|
|
if status.State != drivers.TaskStateExited {
|
|
return false, fmt.Errorf("task hasn't exited yet; status: %v", status.State)
|
|
}
|
|
|
|
return true, nil
|
|
}, func(err error) {
|
|
require.NoError(err)
|
|
})
|
|
|
|
require.NoError(harness.DestroyTask(task.ID, true))
|
|
}
|
|
|
|
func TestJavaDriver_Class_Start_Wait(t *testing.T) {
|
|
javaCompatible(t)
|
|
if !testutil.IsCI() {
|
|
t.Parallel()
|
|
}
|
|
|
|
require := require.New(t)
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
d := NewDriver(ctx, testlog.HCLogger(t))
|
|
harness := dtestutil.NewDriverHarness(t, d)
|
|
|
|
tc := &TaskConfig{
|
|
Class: "Hello",
|
|
Args: []string{"1"},
|
|
}
|
|
task := basicTask(t, "demo-app", tc)
|
|
|
|
cleanup := harness.MkAllocDir(task, true)
|
|
defer cleanup()
|
|
|
|
copyFile("./test-resources/Hello.class", filepath.Join(task.TaskDir().Dir, "Hello.class"), t)
|
|
|
|
handle, _, err := harness.StartTask(task)
|
|
require.NoError(err)
|
|
|
|
ch, err := harness.WaitTask(context.Background(), handle.Config.ID)
|
|
require.NoError(err)
|
|
result := <-ch
|
|
require.Nil(result.Err)
|
|
|
|
require.Zero(result.ExitCode)
|
|
|
|
// Get the stdout of the process and assert that it's not empty
|
|
stdout, err := ioutil.ReadFile(filepath.Join(task.TaskDir().LogDir, "demo-app.stdout.0"))
|
|
require.NoError(err)
|
|
require.Contains(string(stdout), "Hello")
|
|
|
|
require.NoError(harness.DestroyTask(task.ID, true))
|
|
}
|
|
|
|
func TestJavaCmdArgs(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
cfg TaskConfig
|
|
expected []string
|
|
}{
|
|
{
|
|
"jar_path_full",
|
|
TaskConfig{
|
|
JvmOpts: []string{"-Xmx512m", "-Xms128m"},
|
|
JarPath: "/jar-path.jar",
|
|
Args: []string{"hello", "world"},
|
|
},
|
|
[]string{"-Xmx512m", "-Xms128m", "-jar", "/jar-path.jar", "hello", "world"},
|
|
},
|
|
{
|
|
"class_full",
|
|
TaskConfig{
|
|
JvmOpts: []string{"-Xmx512m", "-Xms128m"},
|
|
Class: "ClassName",
|
|
ClassPath: "/classpath",
|
|
Args: []string{"hello", "world"},
|
|
},
|
|
[]string{"-Xmx512m", "-Xms128m", "-cp", "/classpath", "ClassName", "hello", "world"},
|
|
},
|
|
{
|
|
"jar_path_slim",
|
|
TaskConfig{
|
|
JarPath: "/jar-path.jar",
|
|
},
|
|
[]string{"-jar", "/jar-path.jar"},
|
|
},
|
|
{
|
|
"class_slim",
|
|
TaskConfig{
|
|
Class: "ClassName",
|
|
},
|
|
[]string{"ClassName"},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
found := javaCmdArgs(c.cfg)
|
|
require.Equal(t, c.expected, found)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestJavaDriver_ExecTaskStreaming(t *testing.T) {
|
|
javaCompatible(t)
|
|
if !testutil.IsCI() {
|
|
t.Parallel()
|
|
}
|
|
|
|
require := require.New(t)
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
d := NewDriver(ctx, testlog.HCLogger(t))
|
|
harness := dtestutil.NewDriverHarness(t, d)
|
|
defer harness.Kill()
|
|
|
|
tc := &TaskConfig{
|
|
Class: "Hello",
|
|
Args: []string{"900"},
|
|
}
|
|
task := basicTask(t, "demo-app", tc)
|
|
|
|
cleanup := harness.MkAllocDir(task, true)
|
|
defer cleanup()
|
|
|
|
copyFile("./test-resources/Hello.class", filepath.Join(task.TaskDir().Dir, "Hello.class"), t)
|
|
|
|
_, _, err := harness.StartTask(task)
|
|
require.NoError(err)
|
|
defer d.DestroyTask(task.ID, true)
|
|
|
|
dtestutil.ExecTaskStreamingConformanceTests(t, harness, task.ID)
|
|
|
|
}
|
|
func basicTask(t *testing.T, name string, taskConfig *TaskConfig) *drivers.TaskConfig {
|
|
t.Helper()
|
|
|
|
task := &drivers.TaskConfig{
|
|
ID: uuid.Generate(),
|
|
Name: name,
|
|
Resources: &drivers.Resources{
|
|
NomadResources: &structs.AllocatedTaskResources{
|
|
Memory: structs.AllocatedMemoryResources{
|
|
MemoryMB: 128,
|
|
},
|
|
Cpu: structs.AllocatedCpuResources{
|
|
CpuShares: 100,
|
|
},
|
|
},
|
|
LinuxResources: &drivers.LinuxResources{
|
|
MemoryLimitBytes: 134217728,
|
|
CPUShares: 100,
|
|
},
|
|
},
|
|
}
|
|
|
|
require.NoError(t, task.EncodeConcreteDriverConfig(&taskConfig))
|
|
return task
|
|
}
|
|
|
|
// copyFile moves an existing file to the destination
|
|
func copyFile(src, dst string, t *testing.T) {
|
|
in, err := os.Open(src)
|
|
if err != nil {
|
|
t.Fatalf("copying %v -> %v failed: %v", src, dst, err)
|
|
}
|
|
defer in.Close()
|
|
out, err := os.Create(dst)
|
|
if err != nil {
|
|
t.Fatalf("copying %v -> %v failed: %v", src, dst, err)
|
|
}
|
|
defer func() {
|
|
if err := out.Close(); err != nil {
|
|
t.Fatalf("copying %v -> %v failed: %v", src, dst, err)
|
|
}
|
|
}()
|
|
if _, err = io.Copy(out, in); err != nil {
|
|
t.Fatalf("copying %v -> %v failed: %v", src, dst, err)
|
|
}
|
|
}
|
|
|
|
func TestConfig_ParseAllHCL(t *testing.T) {
|
|
cfgStr := `
|
|
config {
|
|
class = "java.main"
|
|
class_path = "/tmp/cp"
|
|
jar_path = "/tmp/jar.jar"
|
|
jvm_options = ["-Xmx600"]
|
|
args = ["arg1", "arg2"]
|
|
}`
|
|
|
|
expected := &TaskConfig{
|
|
Class: "java.main",
|
|
ClassPath: "/tmp/cp",
|
|
JarPath: "/tmp/jar.jar",
|
|
JvmOpts: []string{"-Xmx600"},
|
|
Args: []string{"arg1", "arg2"},
|
|
}
|
|
|
|
var tc *TaskConfig
|
|
hclutils.NewConfigParser(taskConfigSpec).ParseHCL(t, cfgStr, &tc)
|
|
|
|
require.EqualValues(t, expected, tc)
|
|
}
|
|
|
|
// Tests that a given DNSConfig properly configures dns
|
|
func Test_dnsConfig(t *testing.T) {
|
|
t.Parallel()
|
|
ctestutil.RequireRoot(t)
|
|
javaCompatible(t)
|
|
require := require.New(t)
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
d := NewDriver(ctx, testlog.HCLogger(t))
|
|
harness := dtestutil.NewDriverHarness(t, d)
|
|
defer harness.Kill()
|
|
|
|
cases := []struct {
|
|
name string
|
|
cfg *drivers.DNSConfig
|
|
}{
|
|
{
|
|
name: "nil DNSConfig",
|
|
},
|
|
{
|
|
name: "basic",
|
|
cfg: &drivers.DNSConfig{
|
|
Servers: []string{"1.1.1.1", "1.0.0.1"},
|
|
},
|
|
},
|
|
{
|
|
name: "full",
|
|
cfg: &drivers.DNSConfig{
|
|
Servers: []string{"1.1.1.1", "1.0.0.1"},
|
|
Searches: []string{"local.test", "node.consul"},
|
|
Options: []string{"ndots:2", "edns0"},
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
tc := &TaskConfig{
|
|
Class: "Hello",
|
|
Args: []string{"900"},
|
|
}
|
|
task := basicTask(t, "demo-app", tc)
|
|
task.DNS = c.cfg
|
|
|
|
cleanup := harness.MkAllocDir(task, false)
|
|
defer cleanup()
|
|
|
|
_, _, err := harness.StartTask(task)
|
|
require.NoError(err)
|
|
defer d.DestroyTask(task.ID, true)
|
|
|
|
dtestutil.TestTaskDNSConfig(t, harness, task.ID, c.cfg)
|
|
}
|
|
|
|
}
|
|
|
|
func TestDriver_Config_validate(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
pidMode, ipcMode string
|
|
exp error
|
|
}{
|
|
{pidMode: "host", ipcMode: "host", exp: nil},
|
|
{pidMode: "private", ipcMode: "host", exp: nil},
|
|
{pidMode: "host", ipcMode: "private", exp: nil},
|
|
{pidMode: "private", ipcMode: "private", exp: nil},
|
|
{pidMode: "other", ipcMode: "private", exp: errors.New(`default_pid_mode must be "private" or "host", got "other"`)},
|
|
{pidMode: "private", ipcMode: "other", exp: errors.New(`default_ipc_mode must be "private" or "host", got "other"`)},
|
|
} {
|
|
require.Equal(t, tc.exp, (&Config{
|
|
DefaultModePID: tc.pidMode,
|
|
DefaultModeIPC: tc.ipcMode,
|
|
}).validate())
|
|
}
|
|
}
|