08d97a19ca
* ui: Toggle for `read-only` view (#16279) * ui: model update for specification * style: add styling for select * style: add styling for select * refact: add spec to view * refact: update component API * test: refactor for new UI state * refact: clean conditional * refact: update component API for prop * chore: correct naming * chore: remove `fn` helper Co-authored-by: Phil Renaud <phil.renaud@hashicorp.com> * update `default` Mirage scenario (#16496) * chore: update mirage scenario: * ui: conditionally render toggle button (#16497) * chore: update css variable name (#16498) --------- Co-authored-by: Phil Renaud <phil.renaud@hashicorp.com> * ui: Display JSON view of variables associated to job specification (#16570) * chore: move fixture to util * chore: update tests: * ui: display variables table * chore: add mirage fixture (#16572) * ui: regex for job spec parse (#16668) * ui: remove variable table (#16670) * ui: notify user if specification has variables (#16671) * ui: regex for job spec parse * chore: deprecate variable references * chore: update mirage * ui: add notification * test: add test coverage for parse method (#16590) * refact: `JobEditor` reactive query parameters (#16710) * refact: add query parameter * refact: move toggle action to controller * ui: remove toggle behavior in `JobEditor` (#16711) * refact: rename logic for select * chore: instantiate qp in route * refact: uniform alerts (#16715) * style: buffer between alert and header * refact: extract alerts into a component * chore: update tests for qp * chore: defensive logic for app controller * refact: move `edit` state to controller (#16725) * refact: move edit state to controller * refact: handle edit state (#16731) * refact: handle edit state * ui: warning message (#16732) * ui: warning message * ui: enable editing of HCL vars in the UI (#16734) * enable editing of HCL vars * refact: default qp logic * refact: alert condition * refact: Pass `variables` as string (#16849) * ui: Toggle for `read-only` view (#16279) * ui: model update for specification * style: add styling for select * style: add styling for select * refact: add spec to view * refact: update component API * test: refactor for new UI state * refact: clean conditional * refact: update component API for prop * chore: correct naming * chore: remove `fn` helper Co-authored-by: Phil Renaud <phil.renaud@hashicorp.com> * update `default` Mirage scenario (#16496) * chore: update mirage scenario: * ui: conditionally render toggle button (#16497) * chore: update css variable name (#16498) --------- Co-authored-by: Phil Renaud <phil.renaud@hashicorp.com> * refact: `JobEditor` reactive query parameters (#16710) * refact: add query parameter * refact: move toggle action to controller * ui: remove toggle behavior in `JobEditor` (#16711) * refact: rename logic for select * chore: instantiate qp in route * refact: uniform alerts (#16715) * style: buffer between alert and header * refact: extract alerts into a component * chore: update tests for qp * chore: defensive logic for app controller * refact: move `edit` state to controller (#16725) * refact: move edit state to controller * refact: handle edit state (#16731) * refact: handle edit state * ui: warning message (#16732) * ui: warning message * ui: enable editing of HCL vars in the UI (#16734) * enable editing of HCL vars * refact: default qp logic * refact: alert condition * refact: variables as string * style: revert styling change --------- Co-authored-by: Phil Renaud <phil.renaud@hashicorp.com> * bug: correctly edit variables (#16989) * ui: visualize variables (#16987) * ui: fetchRawSpecification * refact: integrate new model method * test: fetchRaw unit * styling: enable height on cm * chore: update copy * feat: visual variables * chore: conditional render info txt * refact: add mirage endpoint * refact: update test for new schema * refact: job submit flow (#17015) * refact: job update logic * chore: remove dead code * bug: update `job.run` and `job.update` adapter methods (#17055) * refact: update adapter * chore: update api usage * styling: UX requests (#17064) * refact: update adapter * chore: update api usage * styling: disable toggle w text * styling: stick button * style: space out alerts * chore: autofocus on first editor * bug: dismiss alert * chore: add jsdoc and assertion check * chore: update mirage for Vercel (#17054) * chore: mirage logic for vercel deploy * chore: update test for mirage change * refact: API refactoring (#17083) * refact: udpate for req schema * refact: update for variable flags and literal * bug: visualize job model not derived state * chore: update copy * chore: fix incorrect copy * chore: deprecate variables derived state * chore: update copy * feat: enable toggle on edit * chore: prettify * refact: move conditional --------- Co-authored-by: Phil Renaud <phil.renaud@hashicorp.com>
366 lines
12 KiB
JavaScript
366 lines
12 KiB
JavaScript
/**
|
|
* Copyright (c) HashiCorp, Inc.
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
*/
|
|
|
|
/* eslint-disable qunit/require-expect */
|
|
import { module, test } from 'qunit';
|
|
import { setupApplicationTest } from 'ember-qunit';
|
|
import {
|
|
click,
|
|
currentURL,
|
|
visit,
|
|
triggerEvent,
|
|
triggerKeyEvent,
|
|
findAll,
|
|
} from '@ember/test-helpers';
|
|
import { setupMirage } from 'ember-cli-mirage/test-support';
|
|
import Layout from 'nomad-ui/tests/pages/layout';
|
|
import percySnapshot from '@percy/ember';
|
|
import a11yAudit from 'nomad-ui/tests/helpers/a11y-audit';
|
|
import faker from 'nomad-ui/mirage/faker';
|
|
|
|
module('Acceptance | keyboard', function (hooks) {
|
|
setupApplicationTest(hooks);
|
|
setupMirage(hooks);
|
|
|
|
module('modal', function () {
|
|
test('Opening and closing shortcuts modal with key commands', async function (assert) {
|
|
faker.seed(1);
|
|
assert.expect(4);
|
|
await visit('/');
|
|
assert.notOk(Layout.keyboard.modalShown);
|
|
await triggerEvent('.page-layout', 'keydown', { key: '?' });
|
|
assert.ok(Layout.keyboard.modalShown);
|
|
await percySnapshot(assert);
|
|
await a11yAudit(assert);
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'Escape' });
|
|
assert.notOk(Layout.keyboard.modalShown);
|
|
});
|
|
|
|
test('closing shortcuts modal by clicking dismiss', async function (assert) {
|
|
await visit('/');
|
|
await triggerEvent('.page-layout', 'keydown', { key: '?' });
|
|
assert.ok(Layout.keyboard.modalShown);
|
|
assert.dom('button.dismiss').isFocused();
|
|
await click('button.dismiss');
|
|
assert.notOk(Layout.keyboard.modalShown);
|
|
});
|
|
|
|
test('closing shortcuts modal by clicking outside', async function (assert) {
|
|
await visit('/');
|
|
await triggerEvent('.page-layout', 'keydown', { key: '?' });
|
|
assert.ok(Layout.keyboard.modalShown);
|
|
await click('.page-layout');
|
|
assert.notOk(Layout.keyboard.modalShown);
|
|
});
|
|
});
|
|
|
|
module('Enable/Disable', function (enableDisableHooks) {
|
|
enableDisableHooks.beforeEach(function () {
|
|
window.localStorage.clear();
|
|
});
|
|
|
|
test('Shortcuts work by default and stops working when disabled', async function (assert) {
|
|
await visit('/');
|
|
|
|
triggerEvent('.page-layout', 'keydown', { key: 'g' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'c' });
|
|
assert.equal(
|
|
currentURL(),
|
|
`/clients`,
|
|
'end up on the clients page after typing g c'
|
|
);
|
|
assert.notOk(Layout.keyboard.modalShown);
|
|
await triggerEvent('.page-layout', 'keydown', { key: '?' });
|
|
assert.ok(Layout.keyboard.modalShown);
|
|
assert.dom('[data-test-enable-shortcuts-toggle]').hasClass('is-active');
|
|
await click('[data-test-enable-shortcuts-toggle]');
|
|
assert
|
|
.dom('[data-test-enable-shortcuts-toggle]')
|
|
.doesNotHaveClass('is-active');
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'Escape' });
|
|
assert.notOk(Layout.keyboard.modalShown);
|
|
triggerEvent('.page-layout', 'keydown', { key: 'g' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'j' });
|
|
assert.equal(
|
|
currentURL(),
|
|
`/clients`,
|
|
'typing g j did not bring you back to the jobs page, since shortcuts are disabled'
|
|
);
|
|
await triggerEvent('.page-layout', 'keydown', { key: '?' });
|
|
await click('[data-test-enable-shortcuts-toggle]');
|
|
assert.dom('[data-test-enable-shortcuts-toggle]').hasClass('is-active');
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'Escape' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'g' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'j' });
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs`,
|
|
'typing g j brings me to the jobs page after re-enabling shortcuts'
|
|
);
|
|
});
|
|
});
|
|
|
|
module('Local storage bind/rebind', function (rebindHooks) {
|
|
rebindHooks.beforeEach(function () {
|
|
window.localStorage.clear();
|
|
});
|
|
|
|
test('You can rebind shortcuts', async function (assert) {
|
|
await visit('/');
|
|
|
|
triggerEvent('.page-layout', 'keydown', { key: 'g' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'c' });
|
|
assert.equal(
|
|
currentURL(),
|
|
`/clients`,
|
|
'end up on the clients page after typing g c'
|
|
);
|
|
|
|
triggerEvent('.page-layout', 'keydown', { key: 'g' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'j' });
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs`,
|
|
'end up on the clients page after typing g j'
|
|
);
|
|
|
|
assert.notOk(Layout.keyboard.modalShown);
|
|
await triggerEvent('.page-layout', 'keydown', { key: '?' });
|
|
assert.ok(Layout.keyboard.modalShown);
|
|
|
|
await click(
|
|
'[data-test-command-label="Go to Clients"] button[data-test-rebinder]'
|
|
);
|
|
|
|
triggerEvent('.page-layout', 'keydown', { key: 'r' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'o' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'f' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'l' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'Enter' });
|
|
assert
|
|
.dom(
|
|
'[data-test-command-label="Go to Clients"] button[data-test-rebinder]'
|
|
)
|
|
.hasText('r o f l');
|
|
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs`,
|
|
'typing g c does not do anything, since I re-bound the shortcut'
|
|
);
|
|
|
|
triggerEvent('.page-layout', 'keydown', { key: 'r' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'o' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'f' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'l' });
|
|
|
|
assert.equal(
|
|
currentURL(),
|
|
`/clients`,
|
|
'typing the newly bound shortcut brings me to clients'
|
|
);
|
|
|
|
await click(
|
|
'[data-test-command-label="Go to Clients"] button[data-test-rebinder]'
|
|
);
|
|
|
|
triggerEvent('.page-layout', 'keydown', { key: 'n' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'o' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'p' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'e' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'Escape' });
|
|
assert
|
|
.dom(
|
|
'[data-test-command-label="Go to Clients"] button[data-test-rebinder]'
|
|
)
|
|
.hasText(
|
|
'r o f l',
|
|
'text unchanged when I hit escape during recording'
|
|
);
|
|
|
|
await click(
|
|
'[data-test-command-label="Go to Clients"] button.reset-to-default'
|
|
);
|
|
assert
|
|
.dom(
|
|
'[data-test-command-label="Go to Clients"] button[data-test-rebinder]'
|
|
)
|
|
.hasText('g c', 'Resetting to default rebinds the shortcut');
|
|
});
|
|
|
|
test('Rebound shortcuts persist from localStorage', async function (assert) {
|
|
window.localStorage.setItem(
|
|
'keyboard.command.Go to Clients',
|
|
JSON.stringify(['b', 'o', 'o', 'p'])
|
|
);
|
|
await visit('/');
|
|
|
|
triggerEvent('.page-layout', 'keydown', { key: 'g' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'c' });
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs`,
|
|
'After a refresh with a localStorage-found binding, a default key binding doesnt do anything'
|
|
);
|
|
|
|
triggerEvent('.page-layout', 'keydown', { key: 'b' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'o' });
|
|
triggerEvent('.page-layout', 'keydown', { key: 'o' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'p' });
|
|
assert.equal(
|
|
currentURL(),
|
|
`/clients`,
|
|
'end up on the clients page after typing the localstorage-bound shortcut'
|
|
);
|
|
|
|
assert.notOk(Layout.keyboard.modalShown);
|
|
await triggerEvent('.page-layout', 'keydown', { key: '?' });
|
|
assert.ok(Layout.keyboard.modalShown);
|
|
assert
|
|
.dom(
|
|
'[data-test-command-label="Go to Clients"] button[data-test-rebinder]'
|
|
)
|
|
.hasText('b o o p');
|
|
});
|
|
});
|
|
|
|
module('Hints', function () {
|
|
test('Hints show up on shift', async function (assert) {
|
|
await visit('/');
|
|
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'Shift' });
|
|
assert.equal(
|
|
document.querySelectorAll('[data-test-keyboard-hint]').length,
|
|
7,
|
|
'Shows 7 hints by default'
|
|
);
|
|
await triggerEvent('.page-layout', 'keyup', { key: 'Shift' });
|
|
|
|
assert.equal(
|
|
document.querySelectorAll('[data-test-keyboard-hint]').length,
|
|
0,
|
|
'Hints disappear when you release Shift'
|
|
);
|
|
});
|
|
});
|
|
|
|
module('Dynamic Nav', function (dynamicHooks) {
|
|
dynamicHooks.beforeEach(async function () {
|
|
server.create('node');
|
|
});
|
|
test('Dynamic Table Nav', async function (assert) {
|
|
assert.expect(4);
|
|
server.createList('job', 3, { createRecommendations: true });
|
|
await visit('/jobs');
|
|
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'Shift' });
|
|
assert.equal(
|
|
document.querySelectorAll('[data-shortcut="Shift+01"]').length,
|
|
1,
|
|
'First job gets a shortcut hint'
|
|
);
|
|
assert.equal(
|
|
document.querySelectorAll('[data-shortcut="Shift+02"]').length,
|
|
1,
|
|
'Second job gets a shortcut hint'
|
|
);
|
|
assert.equal(
|
|
document.querySelectorAll('[data-shortcut="Shift+03"]').length,
|
|
1,
|
|
'Third job gets a shortcut hint'
|
|
);
|
|
|
|
triggerEvent('.page-layout', 'keydown', { key: 'Shift' });
|
|
triggerEvent('.page-layout', 'keydown', { key: '0' });
|
|
await triggerEvent('.page-layout', 'keydown', { key: '1' });
|
|
|
|
const clickedJob = server.db.jobs.sortBy('modifyIndex').reverse()[0].id;
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs/${clickedJob}@default`,
|
|
'Shift+01 takes you to the first job'
|
|
);
|
|
});
|
|
test('Multi-Table Nav', async function (assert) {
|
|
server.createList('job', 3, { createRecommendations: true });
|
|
await visit(
|
|
`/jobs/${server.db.jobs.sortBy('modifyIndex').reverse()[0].id}@default`
|
|
);
|
|
const numberOfGroups = findAll('.task-group-row').length;
|
|
const numberOfAllocs = findAll('.allocation-row').length;
|
|
|
|
await triggerEvent('.page-layout', 'keydown', { key: 'Shift' });
|
|
[...Array(numberOfGroups + numberOfAllocs)].forEach((_, iter) => {
|
|
assert.equal(
|
|
document.querySelectorAll(`[data-shortcut="Shift+0${iter + 1}"]`)
|
|
.length,
|
|
1,
|
|
`Dynamic item #${iter + 1} gets a shortcut hint`
|
|
);
|
|
});
|
|
await triggerEvent('.page-layout', 'keyup', { key: 'Shift' });
|
|
});
|
|
|
|
test('Dynamic nav arrows and looping', async function (assert) {
|
|
server.createList('job', 3, { createAllocations: true, type: 'system' });
|
|
const jobID = server.db.jobs.sortBy('modifyIndex').reverse()[0].id;
|
|
await visit(`/jobs/${jobID}@default`);
|
|
|
|
await triggerKeyEvent('.page-layout', 'keydown', 'ArrowRight', {
|
|
shiftKey: true,
|
|
});
|
|
assert.ok(
|
|
currentURL().startsWith(`/jobs/${jobID}@default/definition`),
|
|
'Shift+ArrowRight takes you to the next tab (Definition)'
|
|
);
|
|
|
|
await triggerKeyEvent('.page-layout', 'keydown', 'ArrowRight', {
|
|
shiftKey: true,
|
|
});
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs/${jobID}@default/versions`,
|
|
'Shift+ArrowRight takes you to the next tab (Version)'
|
|
);
|
|
|
|
await triggerKeyEvent('.page-layout', 'keydown', 'ArrowRight', {
|
|
shiftKey: true,
|
|
});
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs/${jobID}@default/allocations`,
|
|
'Shift+ArrowRight takes you to the next tab (Allocations)'
|
|
);
|
|
|
|
await triggerKeyEvent('.page-layout', 'keydown', 'ArrowRight', {
|
|
shiftKey: true,
|
|
});
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs/${jobID}@default/evaluations`,
|
|
'Shift+ArrowRight takes you to the next tab (Evaluations)'
|
|
);
|
|
|
|
await triggerKeyEvent('.page-layout', 'keydown', 'ArrowRight', {
|
|
shiftKey: true,
|
|
});
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs/${jobID}@default/services`,
|
|
'Shift+ArrowRight takes you to the next tab (Services)'
|
|
);
|
|
|
|
await triggerKeyEvent('.page-layout', 'keydown', 'ArrowRight', {
|
|
shiftKey: true,
|
|
});
|
|
assert.equal(
|
|
currentURL(),
|
|
`/jobs/${jobID}@default`,
|
|
'Shift+ArrowRight takes you to the first tab in the loop'
|
|
);
|
|
});
|
|
});
|
|
});
|