open-nomad/client/client_stats_endpoint_test.go
Seth Hoenig f0c3dca49c tests: swap lib/freeport for tweaked helper/freeport
Copy the updated version of freeport (sdk/freeport), and tweak it for use
in Nomad tests. This means staying below port 10000 to avoid conflicts with
the lib/freeport that is still transitively used by the old version of
consul that we vendor. Also provide implementations to find ephemeral ports
of macOS and Windows environments.

Ports acquired through freeport are supposed to be returned to freeport,
which this change now also introduces. Many tests are modified to include
calls to a cleanup function for Server objects.

This should help quite a bit with some flakey tests, but not all of them.
Our port problems will not go away completely until we upgrade our vendor
version of consul. With Go modules, we'll probably do a 'replace' to swap
out other copies of freeport with the one now in 'nomad/helper/freeport'.
2019-12-09 08:37:32 -06:00

88 lines
2.3 KiB
Go

package client
import (
"testing"
"github.com/hashicorp/nomad/acl"
"github.com/hashicorp/nomad/client/config"
"github.com/hashicorp/nomad/client/structs"
"github.com/hashicorp/nomad/nomad/mock"
nstructs "github.com/hashicorp/nomad/nomad/structs"
"github.com/stretchr/testify/require"
)
func TestClientStats_Stats(t *testing.T) {
t.Parallel()
require := require.New(t)
client, cleanup := TestClient(t, nil)
defer cleanup()
req := &nstructs.NodeSpecificRequest{}
var resp structs.ClientStatsResponse
require.Nil(client.ClientRPC("ClientStats.Stats", &req, &resp))
require.NotNil(resp.HostStats)
require.NotNil(resp.HostStats.AllocDirStats)
require.NotZero(resp.HostStats.Uptime)
}
func TestClientStats_Stats_ACL(t *testing.T) {
t.Parallel()
require := require.New(t)
server, addr, root, cleanupS := testACLServer(t, nil)
defer cleanupS()
client, cleanupC := TestClient(t, func(c *config.Config) {
c.Servers = []string{addr}
c.ACLEnabled = true
})
defer cleanupC()
// Try request without a token and expect failure
{
req := &nstructs.NodeSpecificRequest{}
var resp structs.ClientStatsResponse
err := client.ClientRPC("ClientStats.Stats", &req, &resp)
require.NotNil(err)
require.EqualError(err, nstructs.ErrPermissionDenied.Error())
}
// Try request with an invalid token and expect failure
{
token := mock.CreatePolicyAndToken(t, server.State(), 1005, "invalid", mock.NodePolicy(acl.PolicyDeny))
req := &nstructs.NodeSpecificRequest{}
req.AuthToken = token.SecretID
var resp structs.ClientStatsResponse
err := client.ClientRPC("ClientStats.Stats", &req, &resp)
require.NotNil(err)
require.EqualError(err, nstructs.ErrPermissionDenied.Error())
}
// Try request with a valid token
{
token := mock.CreatePolicyAndToken(t, server.State(), 1007, "valid", mock.NodePolicy(acl.PolicyRead))
req := &nstructs.NodeSpecificRequest{}
req.AuthToken = token.SecretID
var resp structs.ClientStatsResponse
err := client.ClientRPC("ClientStats.Stats", &req, &resp)
require.Nil(err)
require.NotNil(resp.HostStats)
}
// Try request with a management token
{
req := &nstructs.NodeSpecificRequest{}
req.AuthToken = root.SecretID
var resp structs.ClientStatsResponse
err := client.ClientRPC("ClientStats.Stats", &req, &resp)
require.Nil(err)
require.NotNil(resp.HostStats)
}
}